This is a trivial contribution.

104 views
Skip to first unread message

Igor Galić

unread,
Aug 19, 2014, 9:01:15 AM8/19/14
to puppet-dev
Fellow Humans,

Recently the puppetcla bot has been activated for most puppetlabs-modules.
This has sparked a *lot* of controversies from people who just contribute
the most trivial of fixes,

* https://github.com/puppetlabs/puppetlabs-apache/pull/775
* https://github.com/puppetlabs/puppetlabs-java/pull/63 <<<<
* https://github.com/puppetlabs/puppetlabs-postgresql/pull/448


Now, ignoring the understandable criticism that PRs should be merged faster,
i think we need to have a discussion on what warrants a CLA signing.

Speaking with my Apache Software Foundation hat on: we only ask people to
sign a CLA who are committers - or in git terms, those with merge access.
We entrust *them* to judge patches from third parties.
We have done this since times immemorial. Before we had git. Before there *was*
git. Before it was *this* easy to contribute a patch. It still is. Random
drive-by contributions happen every day, some of them even through GitHub!

At this point i'm kinda stuck for argumentation, from my perspective, and the
expressed bewilderment of many contributors it seems silly we even have to
bring this up at all.


So long,

--
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.g...@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F 4008 F266 55D6 2998 1641

Daniele Sluijters

unread,
Aug 19, 2014, 9:08:40 AM8/19/14
to puppe...@googlegroups.com
Hey,

I'm also fairly annoyed by the CLA bot on modules. Most, if not all, modules have been licensed under the Apache License 2.0 since their publication on Github. As such, contributions are automatically covered by this license. It might be worth mentioning this in a CONTRIBUTORS.md but having the CLA bot involved needlessly complicates the contribution process to modules.

I can understand this happening on the core products because they're dual-licensed, the modules however are not and we should not put up more obstacles for contributors, we should be removing them.

-- 
Daniele Sluijters

Trevor Vaughan

unread,
Aug 19, 2014, 9:10:37 AM8/19/14
to puppe...@googlegroups.com
+1 to removing CLAs on single licensed modules.

This creates an unnecessary barrier to people who may have restrictions from their corporate overlords with the CLA but no issue whatsoever with a pure FOSS contribution.

Trevor


--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/f2ad6f36-f92b-47be-8151-d751c91e40f3%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvau...@onyxpoint.com

-- This account not approved for unencrypted proprietary information --

Dawn Foster

unread,
Aug 19, 2014, 10:55:08 AM8/19/14
to puppet-dev
Hi All,

I'm working on this issue right now. I'm traveling this week, so it
may take a week or 2 for us to sort out. I can't guarantee a
particular resolution, since I need to talk to the person who made the
decision to do this and see if we can come up with a solution that
causes less pain for the community.

Also a quick note (not negating the need to revisit this module CLA
decision), but trivial patches are always exempt from the CLA:
https://docs.puppetlabs.com/community/trivial_patch_exemption.html

Feel free to ping me with a link to the pull request if you are having
any issues with getting a trivial contribution exempted from the CLA.

Regards,
Dawn Foster
Director of Community
http://puppetlabs.com/community
> https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoWw-N6DD9jOqFSVg5kVajQNHPvMBPCTmm8j%2B8R05dVnpw%40mail.gmail.com.

Jeff McCune

unread,
Aug 19, 2014, 1:46:54 PM8/19/14
to puppe...@googlegroups.com
On Tuesday, August 19, 2014 7:55:08 AM UTC-7, Dawn Foster wrote:
Hi All,

I'm working on this issue right now. I'm traveling this week, so it
may take a week or 2 for us to sort out. I can't guarantee a
particular resolution, since I need to talk to the person who made the
decision to do this and see if we can come up with a solution that
causes less pain for the community.

I'm the application owner for the CLA bot, and while I usually don't make decisions about what projects we do and do not enable the CLA bot for, I am involved in the process and we are working on addressing these concerns.

Please understand we're not trying to make the contribution process more difficult and cumbersome and are actively seeking ways to make it smoother and easier.

Also a quick note (not negating the need to revisit this module CLA
decision), but trivial patches are always exempt from the CLA:
https://docs.puppetlabs.com/community/trivial_patch_exemption.html

Feel free to ping me with a link to the pull request if you are having
any issues with getting a trivial contribution exempted from the CLA.

Feel free to CC me as well since Dawn will be traveling.

-Jeff

Jeff McCune

unread,
Aug 19, 2014, 4:54:22 PM8/19/14
to puppe...@googlegroups.com
On Tue, Aug 19, 2014 at 6:01 AM, Igor Galić <i.g...@brainsware.org> wrote:
At this point i'm kinda stuck for argumentation, from my perspective, and the
expressed bewilderment of many contributors it seems silly we even have to
bring this up at all.

I really appreciate that you and others brought this up.  The Puppet community, especially active members like you, Igor, are really important to me and to all of us at Puppet Labs.  This change shouldn't have been made without the involvement of the community.  I've gone ahead and reverted the change that enabled the CLA status on all of the puppetlabs-* modules.  The CLA is now disabled for modules.  We won't re-enable the CLA without first consulting and coordinating with the wider community prior to doing so.

Sorry about the disruption.  Please understand that we're human and make mistakes and will do our best to correct them as quickly as possible.

-Jeff
Reply all
Reply to author
Forward
0 new messages