Notes from PR triage 2014-04-16

[Andy Parker]

Pull request triage - 2014-04-09

 

Joined: Alex, Andy, Felix, Henrik, Joshua, Kylo, Rob, Adrien, Brian

 

Held over:

 

Puppet:

 

2309: Separate out hold state into a separate property:

  - Kylo to ping lollipopman about the decision and see if he wants to carry the change forward

  - [link](https://groups.google.com/forum/#!topic/puppet-dev/_APn8ZXw4Cw)

 

2420: Disambiguation of handling source_or_content for fileservers vs local re...

  - Andy wants to make a few changes. Will pull in and make a few small changes (timeboxed to no more than a few hours)

  - Specs don't make a lot of sense with respect to the issue being fixed

 

1974: enablerepo and disablerepo for yum type:

  - Contributor seemed on board to the approach we suggested, let's see if he follows up. If not we can just take this and fix it ourselves.

  - It's been 2 weeks since we've seen a response to this, it might be be best if we just fixed it up ourselves. Probably won't be able to do it this week though

 

2136: For puppet4 (#11383) support purging of all cronjobs

  - Still on hold. Felix will look at getting a PR for a deprecation warning.

  - Still waiting for the puppet-4 branch to continue forward on this. (2x)

 

2262 - Fix yum/rpm version comparison to work the way RPM actually does:

  - We'll take this into puppet 4.

  - Also waiting for the puppet-4 branch. (2x)

 

2436 - Use metadata.json as canonical metadata source.

  - Andy has decreed that if there are PMT code changes, the Forge team is in charge.

 

2440 - Update `puppet module generate` to create `metadata.json`:

  - ditto

 

2492: (PUP-1381) issue warnings to current users of cron purging

  - Sending back to felix with the suggestion that he try option 3.

 

2495: Implement :enableable for OpenBSD service provider

  - Waiting on Zach to make minor changes

 

2494: Change Crypto Spec in accordance to bettercrypto.org

  - Waiting on Josh C to comment on (Josh is out for a few weeks)

 

2487: (PUP-2098) 'only_uid' property on resources 'user'

  - Adrien to close the PRs (2487 and 2484)

 

Facter:

 

580: (FACT-166) change acceptable fact names to be only lowercase Symbols

  - Skipping over for next week

  - Adrien to talk to jhoblitt

 

642/643: Fun with AIX networking

  - Fixing this up ourselves, bringing it into the sprint.

  - Adrien to follow up

 

559: (FACT-233) Add dhcp_server fact

  - Could use some additional commenting and review

  - Adrien to comment on, but won't necessarily pull into the sprint

 

560: (FACT-234) Add uuid_<partition>

  - Could use some additional commenting and review

  - Adrien to comment on, but won't necessarily pull into the sprint

 

595: Update detection of GCE instances

  - Requires backporting of GCE code onto facter-2, punting on this

 

629: Make kernelmajversion useful in FreeBSD

  - Looks good, just needs an issue and we can merge it

  - Joshua to comment

 

630: Add LXC detection to virtual and is_virtual fact

  - Looks good, just needs to be rebased onto Facter

  - Joshua to comment

 

644: (#7559) Use /sys/hypervisor/version/extra to distinguish AWS VM in VPC

  - Superseded by https://github.com/puppetlabs/facter/pull/661

  - Adrien to comment.

 

658: Cumulus Linux distro to properly report Debian family

  - This has to land in master because we haven't backported the Cumulus Linux

    changes back into facter-2.

  - Joshua to comment about the commit message, we'll merge in when it's fixed.

 

659: Convert-Interface-Names: not replace : and .

  - This change is is more correct backwards incompatible, existing facts will see their names change.

  - Adrien to comment

New pull requests:

 

2515: Add support for 'skip_if_unavailable' to `yumrepo`

  - This will be a candidate for next sprint to go out in 3.6.0

2474: Add docs badge to README

  - Looks kinda cool. Let's get it in there!

  - Kylog has merged it.

  

2477: (PUP-2073) fix for multiple diff_args

  - Needs tests

  - Adrien to comment asking for tests

2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption

  - Adrien to ping domcleal to make sure he has verified that this works

2530: (PUP-2237) Updates to Emacs puppet-mode for indentation, XEmacs, file name matching

  - RyanS to try it out and let us know

  

2524: (maint) Clearer error message to reflect origin.

  - Asked Ashley to update the tests

  

2455: (PUP-2014) Make gem provider match on a single gem name

  - Adrien to ask contributor to add a test for the changed query

  

2470: Tickets/master/11263 (more options for yumrepo)

  - Adrien to comment and let the contributor know that things have been changing. Request for splitting it up into smaller pieces.

  

2472: (PUP-2040) Allow excluding files from module build package

  - Kylo to ping Alex or Ryan and ask where they want to take this.

  

2464: (PUP-2009) Add acceptance test for dynamic environments

  - Joshua to rebase onto master and merge in 

2467: chkconfig should use resetpriorities when enabling services

  - Needs a ticket

  - Adrien commenting to point out some problems with this change

Candidates for the upcoming sprint:

 

  - 2452: Make the digest algorithm used for file checksums configurable:

  - 2494: Change Crypto Spec in accordance to bettercrypto.org

  - 2420: Disambiguation of handling source_or_content for fileservers vs local re

  - 1974: enablerepo and disablerepo for yum type

  - 2515: Add support for 'skip_if_unavailable' to `yumrepo`

 

Tasks broken out by person:

Adrien:

  - 2487: (PUP-2098) 'only_uid' property on resources 'user'

  - 2477: (PUP-2073) fix for multiple diff_args

  - 2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption

  - 2470: Tickets/master/11263 (more options for yumrepo)

  - 2467: chkconfig should use resetpriorities when enabling services

Andy:

  - 2420: Disambiguation of handling source_or_content for fileservers vs local re...

Ashley:

  - 2524: (maint) Clearer error message to reflect origin.

Josh C:

  - 2494: Change Crypto Spec in accordance to bettercrypto.org

Joshua P:

  - 2464: (PUP-2009) Add acceptance test for dynamic environments

 

Kylo:

  - 2309: Separate out hold state into a separate property

  - 2474: Add docs badge to README

  - 2472: (PUP-2040) Allow excluding files from module build package

 

Felix:

  - 2492: (PUP-1381) issue warnings to current users of cron purging

RyanS:

  - 2530: (PUP-2237) Updates to Emacs puppet-mode for indentation, XEmacs, file name matching

 

Zach:

  - 2495: Implement :enableable for OpenBSD service provider

--

Andrew Parker

an...@puppetlabs.com

Freenode: zaphod42

Twitter: @aparker42

Software Developer

Join us at PuppetConf 2014, September 22-24 in San Francisco

Register by May 30th to take advantage of the Early Adopter discount —save $349!

[Felix Frank]

On 04/16/2014 08:29 PM, Andy Parker wrote:
> Joined: Alex, Andy, Felix, Henrik, Joshua, Kylo, Rob, Adrien, Brian

Actually, I was there only in spirit - it was Bowling night, sorry ;)

Happy Easter and hope to catch you guys next week.

[Andy Parker]

Oops. Sorry about saying you were somewhere you weren't. See, I have a bad memory even just a few minutes after something happened :/

Have a good easter!

 

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/534F8409.3090900%40alumni.tu-berlin.de.
For more options, visit https://groups.google.com/d/optout.