Notes from Puppet PR Triage for 2014-04-30
11 views
Skip to first unread message
Andy Parker
Apr 30, 2014, 2:02:18 PM4/30/14
to puppe...@googlegroups.com
Pull request triage - 2014-04-30
Joined: Andy, Charlie, Adrien, JoshC, Hunner, Kylo, Rob, PeterH, BrianLM
Candidates for merging:
- 2492: (PUP-1381) issue warnings to current users of cron purging
- 2455: (PUP-2014) Make gem provider match on a single gem name
- Needs a test added
- 2472: (PUP-2040) Allow excluding files from module build package
- Needs to be rebased
- 2479: (PUP-2031) unless_uid on user is completely broken wrt ranges
- Needs a little rework -> PeterH
- 2536: (maint) Beaker tests useful for reviewing environment status
- 559: (FACT-233) Add dhcp_server fact
- 630: Add LXC detection to virtual and is_virtual fact
Held over:
Puppet:
2309: Separate out hold state into a separate property:
- Kylo to ping lollipopman about the decision and see if he wants to carry the change forward
- Decision made, waiting for contributor to update pull request.
- Adrien to close because of inactivity
2136: For puppet4 (#11383) support purging of all cronjobs
- Still on hold. Felix will look at getting a PR for a deprecation warning.
- Still waiting for the puppet-4 branch to continue forward on this. (3x)
- Next step Felix to rebase onto puppet 4 branch.
2262 - Fix yum/rpm version comparison to work the way RPM actually does:
- We'll take this into puppet 4.
- Also waiting for the puppet-4 branch. (2x)
- Next step Jantman to rebase onto puppet 4 branch.
2492: (PUP-1381) issue warnings to current users of cron purging
- Sending back to felix with the suggestion that he try option 3.
- Felix to keep tinkering on it, Andy to look more closely.
2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption
- domcleal verified it works, Adrien to pull into this week's sprint
- Adrien commented that using 'yum update-check' might be better
- Discussion is still ongoing
2455: (PUP-2014) Make gem provider match on a single gem name
- Adrien to ask contributor to add a test for the changed query
- Josh to update with the file to add the test to
- Waiting for test from contrubitor
- Two weeks have elapsed, but it is so trivial that we'll just do this ourselves.
2472: (PUP-2040) Allow excluding files from module build package
- ping Alex or Ryan and ask where they want to take this. (2x)
- Still no clear direction from Ryan and Co about where this should go (I think we should close it)
2467: chkconfig should use resetpriorities when enabling services
- Needs a ticket
- Adrien commenting to point out some problems with this change
- Waiting on response from contributor
- No activity for 2 weeks. Adrien to close
2468: Add mechanism to allow template files to be copied without getting parsed
- This is a modules/forge team, Adrien to ping everybody remotely related to the forge
- The changes that were blocking this have landed. Kylo pinging pvande again.
2453: Add parser function digest, that calculates a checksum using the configured `digest_algorithm`
- Based on top of GH-2452 which was rewritten, needs to be updated on top of 2537
- Comment that we're still working on prereqs
- JoshC to ask contributor to rebase now that all of the other changes are in.
2532: (PUP-2240) Add unfold of array using splat unary * operator
- Issue targeted at 3.7, deferring on this.
2478: (PUP-2074) resourses unless_uid depends on unless_system_user
- Needs tests and could use a more comprehensive commit message
- Adrien to close because of inactivity
2479: (PUP-2031) unless_uid on user is completely broken wrt ranges
- This removes pseudo ranges from unless_uid, adds comma separated values
- Further simplify inputs to [String | Integer | Array<String | Integer>]
- PeterH to take
- PeterH didn't get to it. PeterH to take now
2536: (maint) Beaker tests useful for reviewing environment status
- Andy and Joshua to follow up on as part of environment work
2549: (PUP-2298) add support for Type#in_valid_catalog? methods to transaction
- What sort of hooks do we want to define over the application lifetime?
- Implement validate method on Type ancestor class, change method name something like `#check_constraints`
- Latest set of changes looks good, but the pre_run_check should happen on the catalog evaluation
Facter:
643: Fun with AIX networking
- Fixing this up ourselves, bringing it into the sprint.
- "/etc/ifconfig" doesn't seem to be present on modern
- Already in sprint, sorting out what's going on
- Closed by Adrien. Won't be using
559: (FACT-233) Add dhcp_server fact
- Looks pretty good, Adrien to pull in
- Kylo to review and merge into facter-2 if it looks good
560: (FACT-234) Add uuid_<partition>
- Could use some additional commenting and review
- Adrien to comment/close
595: Update detection of GCE instances
- Requires backporting of GCE code onto facter-2
- Since we'll be overhauling this, Josh to close and comment
- Josh closed
630: Add LXC detection to virtual and is_virtual fact
- Looks good, just needs to be rebased onto Facter
- Still needs rebase, Josh to ping Jeff
- Adrien to look into merging into the facter-2 branch
644: (#7559) Use /sys/hypervisor/version/extra to distinguish AWS VM in VPC
- Superseded by https://github.com/puppetlabs/facter/pull/661
- Josh to comment since GH-661 was merged
- This shouldn't be targetted at stable.
- This is already fixed in the facter 2 branch
- Josh to close because facter 2 already handles this case.
New:
Puppet:
2569: (PUP-1736) Log master and agent locale information
- Think this should be a more universal debug message.
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperRegister by May 30th to take advantage of the Early Adopter discount —save $349!
Reply all
Reply to author
Forward
0 new messages