Notes from the January 15th, 2014 PR Triage
36 views
Skip to first unread message
Andy Parker
Jan 15, 2014, 1:43:17 PM1/15/14
to puppe...@googlegroups.com
Names in bold are the person assigned the task.
Joined:
Adrien, Dan, Peter, Andy, Kylo, Jeff Bachtel, Johannes Fabian Russek
To address after review of actions from last time::
Puppet:
2034: is it a property? is it a parameter? OH GOD! Let's just go with it being a property. Kylo: merge it in as is
2137: Held off last week because of CI failures. Adrien will grab right now
2200: We appear to have coverage of the pkg provider in our acceptance tests. Commits are mostly good. Peter will fix up 2 commits (no bug number prefix) and then merge it in.
2234: Dan is going to add a test, fix up the commit message to mention the issue (PUP-1401) and merge it in.
2212: ping haus. Dan took a look and it looks like we just need to know the origin of the patches. Note added
New:
Puppet:
628: Looks to be pretty good. A few concerns about the range type, but if a ruby hash with a range is created outside of the DSL and fed into create_resources, this could be encountered. It would be great to have a range expression in the DSL, but that is a separate concern. Rob to handle rebasing, updating comments to reference PUP-1447.
1942: After a little more discussion, we are going to take it mostly as is. Joshua just needs to rebase it onto master, update the commits to reference PUP-1448 and check that all of the tests are passing.
Facter:
skipping because Facter-2 is in the works and will dramatically alter the landscape
Hiera:
172: Looks ok, also it is fine that it is missing tests. Andy: Clean up the commits, add a ticket, and merge it in.
stdlib:
176: closing because we can't take it for a while. As long as PE 2.8/puppet 2.7 is around it would just break things :( Closed
198: Commented. Asked one of the contributors to handle the renaming.
201: Just waiting for some tests. Adrien: will just add the tests right now.
204: Closed. The change was strange and the real issue seems to be inside puppet
213: Delaying until the next PR triage where Henrik is available.
-- Adrien, Dan, Peter, Andy, Kylo, Jeff Bachtel, Johannes Fabian Russek
To address after review of actions from last time::
Puppet:
2034: is it a property? is it a parameter? OH GOD! Let's just go with it being a property. Kylo: merge it in as is
2137: Held off last week because of CI failures. Adrien will grab right now
2200: We appear to have coverage of the pkg provider in our acceptance tests. Commits are mostly good. Peter will fix up 2 commits (no bug number prefix) and then merge it in.
2234: Dan is going to add a test, fix up the commit message to mention the issue (PUP-1401) and merge it in.
2212: ping haus. Dan took a look and it looks like we just need to know the origin of the patches. Note added
New:
Puppet:
628: Looks to be pretty good. A few concerns about the range type, but if a ruby hash with a range is created outside of the DSL and fed into create_resources, this could be encountered. It would be great to have a range expression in the DSL, but that is a separate concern. Rob to handle rebasing, updating comments to reference PUP-1447.
1942: After a little more discussion, we are going to take it mostly as is. Joshua just needs to rebase it onto master, update the commits to reference PUP-1448 and check that all of the tests are passing.
Facter:
skipping because Facter-2 is in the works and will dramatically alter the landscape
Hiera:
172: Looks ok, also it is fine that it is missing tests. Andy: Clean up the commits, add a ticket, and merge it in.
stdlib:
176: closing because we can't take it for a while. As long as PE 2.8/puppet 2.7 is around it would just break things :( Closed
198: Commented. Asked one of the contributors to handle the renaming.
201: Just waiting for some tests. Adrien: will just add the tests right now.
204: Closed. The change was strange and the real issue seems to be inside puppet
213: Delaying until the next PR triage where Henrik is available.
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperJoin us at PuppetConf 2014, September 23-24 in San Francisco
Jeff McCune
Jan 15, 2014, 2:39:51 PM1/15/14
to puppe...@googlegroups.com
Andy, is this intent of this email to broadcast what the action items are for pull requests that recently came in are?
Andy Parker
Jan 15, 2014, 2:44:04 PM1/15/14
to puppe...@googlegroups.com
On Wed, Jan 15, 2014 at 11:39 AM, Jeff McCune <je...@puppetlabs.com> wrote:
Andy, is this intent of this email to broadcast what the action items are for pull requests that recently came in are?
Recent or not so recent :) It is just a summary of what happened in the PR triage that we've been holding on wednesday mornings.
----
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAOXx1vEhfS42SqwyZfUNjCnd3U%2BE_NutoXXsjDH0mUA%2Bz%2B8eZw%40mail.gmail.com.
For more options, visit https://groups.google.com/groups/opt_out.
Jeff McCune
Jan 15, 2014, 2:51:09 PM1/15/14
to puppe...@googlegroups.com
On Wed, Jan 15, 2014 at 11:44 AM, Andy Parker <an...@puppetlabs.com> wrote:
On Wed, Jan 15, 2014 at 11:39 AM, Jeff McCune <je...@puppetlabs.com> wrote:
Andy, is this intent of this email to broadcast what the action items are for pull requests that recently came in are?Recent or not so recent :) It is just a summary of what happened in the PR triage that we've been holding on wednesday mornings.
Got it. I'm trying to understand what I should expect to happen with the PR I submitted a week ago [1]. At this point I don't know what to expect so it feels like it may just be sitting there and will continue to do so, know what I mean?
Andy Parker
Jan 15, 2014, 3:01:21 PM1/15/14
to puppe...@googlegroups.com
So the process that we are following now is a weekly triage with most of the team and in a public hangout. It lasts about 1.5 - 2 hours and so we get through quite a few, but there is a lot there, so I don't think we've made it through everything yet. Last week we started at the top (newest first) of the Puppet PRs. Today I decided to try and clear out some of the older ones, so, after reviewing everything that we had decided from last week, we started at the end and then took a look at the other projects. Next week we'll probably start from the top again so that new ones don't sit for too long without some guaranteed review.
Sorry that it is taking a while to get to yours.
--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAOXx1vG4Y7dHXmaXpfPzJQZ7prPk6OG5AB1O3N3v1_PQ1D2f9w%40mail.gmail.com.
Jeff McCune
Jan 21, 2014, 1:35:54 PM1/21/14
to puppe...@googlegroups.com
On Wed, Jan 15, 2014 at 12:01 PM, Andy Parker <an...@puppetlabs.com> wrote:
Got it. I'm trying to understand what I should expect to happen with the PR I submitted a week ago [1]. At this point I don't know what to expect so it feels like it may just be sitting there and will continue to do so, know what I mean?So the process that we are following now is a weekly triage with most of the team and in a public hangout. It lasts about 1.5 - 2 hours and so we get through quite a few, but there is a lot there, so I don't think we've made it through everything yet. Last week we started at the top (newest first) of the Puppet PRs. Today I decided to try and clear out some of the older ones, so, after reviewing everything that we had decided from last week, we started at the end and then took a look at the other projects. Next week we'll probably start from the top again so that new ones don't sit for too long without some guaranteed review.Sorry that it is taking a while to get to yours.
No need to apologize, I'm really only trying to get a sense of what to expect, which I have now.
No rush on the PR, whenever it gets reviewed is when it gets reviewed.
Reply all
Reply to author
Forward
0 new messages