Puppet PR Triage Notes 2014-06-25

[Andy Parker]

Joined: Andy, Adrien, Felix

Candidates for merging:

  * Puppet/2637: Make puppet master compile honor configured logdest

    - Candidate, but we'd like to have the contributor fix it up first (saves us the time)

  * Puppet/2753: (PUP-2737) purge sshkeys with spaces in the title

  * Puppet/2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600

  * Puppet/2783: (PUP-2801) Describe ca subcommands in puppet help

  * Facter/653: Patch blockdevices to work around Kernel bug

  * Puppet/2779: (PUP-2802) add slot support for packages in portage.rb

  * Puppet/2770: Allow version and held states of a package to specified as separate properties

  * Puppet/2761: (PUP-1100) Fix error message with create_resource and auto-loaded class

New:

2798: (MAINT) Small openbsd package spec tweaks

  - Merged

2797: (PE-3758) Puppet should support HTTP proxy authentication

  - Needs a PUP ticket

  - Needs to sign the CLA

2793: (PUP-2822) Improve description of disable_warnings setting

  - Looks good

  - Adrien merging

2783: (PUP-2801) Describe ca subcommands in puppet help

  - Needs a very small cleanup.

2779: (PUP-2802) add slot support for packages in portage.rb

  - Adrien needs to take it an review it for correctness/more intensive review

  - Commits need to be updated to contributing guidelines

2770: Allow version and held states of a package to specified as separate properties

  - Pull in for more intensive analysis

  - Commits need to be updated to contributing guidelines

2761: (PUP-1100) Fix error message with create_resource and auto-loaded class

  - Pull in for more analysis. Looks pretty good though.

Puppet:

2614: (PUP-2452) Refresh support for Package type

  - Looks reasonable.

  - There is a question from the contributor about if there needs to be something changed to use this.

  - The answer to the question is, "yes, having a use of this is ideal".

  - Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does.

  - Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify.

  - This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality.

  - Adrien to write up the concerns in the PR and start a thread on puppet-dev to come to a decision about how to better control refresh events.

2637: Make puppet master compile honor configured logdest

  - Needs a ticket associated with it

  - Other than that looks good

2753: (PUP-2737) purge sshkeys with spaces in the title

  - Looks alright.

2754: (maint) spec: allow expectations of resources from compiled manifests

  - Looks like a useful helper method, but need an example of use.

  - Andy merged

2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600

  - Some questions about windows, but Peter thinks it should be fine

2709 (PUP-2701): Add PMT build metadata.json tests

  - Joshua Partlow to verify these on a few platforms before merging

  - Found some failures on centos6; will update prs and then ask if Kurt can continue

2716 (PUP-???): zypper should always be the default package provider for SUSE osfamily

  - Needs a PUP-ticket

  - Those present are not totally sure if zypper is the appropriate default and whether

    or not this could break existing Puppet installs.  Adrien is contacting colleague

    at Attachmate / Novell?

  - Rug was the previous default, but modern systems appear to be defaulting to zypper

  - Adrien will retarget to puppet-4 (and update ticket reference) because we don't want to change default providers in a minor release

2468 (PUP-2079): Add mechanism to allow template files to be copied without getting parsed

  - This is a modules/forge team, Adrien to ping everybody remotely related to the forge

  - The changes that were blocking this have landed. Kylo pinging pvande again.

  - Need to ping pvande again to verify / merge

  - Still no response, will wait another week

  - Pieter responded on 6/5 with some comments but won't have time to review more deeply until after PE release

Facter:

653: Patch blockdevices to work around Kernel bug

  - No activity for a long time.

  - The bug doesn't contain any information about how the bug exhibits, what kernels it affects, or any information about the bug in kernel mailing lists.

  - Adrien has some information about the location of the bug. He will add it to the issue.

  - We'll fix up the rest and merge it in.

689 (FACT-547) Limit the output of prtdiag on Solaris

  - Felix leaving a line note about the pathing for the 'head' command on the pipe

Hiera:

188: Allow for return of complex values across hiera

  - This will end up changing the behavior of some current queries.

  - Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no

  - This is a big problem, we need to open it to discussion

--

Andrew Parker

an...@puppetlabs.com

Freenode: zaphod42

Twitter: @aparker42

Software Developer

Join us at PuppetConf 2014, September 22-24 in San Francisco

Register by May 30th to take advantage of the Early Adopter discount —save $349!