Module PR Triage Notes 2014-06-12

9 views
Skip to first unread message

Morgan Haskel

unread,
Jun 12, 2014, 3:02:03 PM6/12/14
to puppe...@googlegroups.com
This week we triaged PRs for puppetlabs-xinetd and puppetlabs-rabbitmq.

puppetlabs-xinetd:
Merged:
  - 35: Allow configuring log_on_* operator 
Reviewed/commented on:
  - 34: Added 'env' and 'passenv' service parameters
         - Missing doc updates, tests, and needs a rebase
  - 33: Added redirect option
          - Missing doc updates, tests, and needs a rebase
  - 31: Removed default values from xinetd.conf and added params for each (and tests!)
          - Missing doc updates
          - Needs template updates

puppetlabs-rabbitmq:
Merged:
  - 202: cleanup of leaning toothpicks (as much as possible, anyway)
  - 200: Adding missing ssl_ parameters from rabbitmq::config class
  - 199: adding ssl_only parameter, which disables all non-encrypted tcp listeners
  - 193: added property tags to rabbitmq_user provider
  - 170: remove string validation on package source
Reviewed/commented on:
  - 206: Use valid ensure value similar to ldap_auth when stomp_ensure = true
           - Missing tests
           - Want code updated to validate against correct values
  - 204: Fix for stomp_ensure type error
            - Want code updates to work more like #206
  - 201: Support for configuring the rabbitmq_management web UI
           - Missing tests
  - 192: Types for federation
           - Missing docs and tests

--
Morgan Haskel
Module Engineer

Join us at PuppetConf 2014September 20-24 in San Francisco
Register by July 31st to take advantage of the Early Bird discount —save $249!
Reply all
Reply to author
Forward
0 new messages