Patch for "Add an "Expire" parameter to the User type reference"

[Dean Wilson]

I've attached a patch for a possible fix to
http://projects.puppetlabs.com/issues/2224 (among other similar
tickets). It's my first attempt at modifying an existing provider and
adding a new feature so before I start looking at specs for it I'd
appreciate a once over by experienced eyes.

Thanks,
Dean
--
Dean Wilson               http://www.unixdaemon.net
Profanity is the one language all programmers understand
--- Anon

[James Turnbull]

Dean Wilson wrote:
> I've attached a patch for a possible fix to
> http://projects.puppetlabs.com/issues/2224 (among other similar
> tickets). It's my first attempt at modifying an existing provider and
> adding a new feature so before I start looking at specs for it I'd
> appreciate a once over by experienced eyes.

+1 from me.

James

--
Puppet Labs - http://www.puppetlabs.com
C: 503-734-8571

[Dean Wilson]

On 26 August 2010 21:33, James Turnbull <ja...@puppetlabs.com> wrote:
> Dean Wilson wrote:
>> I've attached a patch for a possible fix to
>> http://projects.puppetlabs.com/issues/2224 (among other similar

> +1 from me.

I've attached a rebased version that includes some simple specs and
should apply cleanly against master.

[James Turnbull]

Dean Wilson wrote:
> On 26 August 2010 21:33, James Turnbull <ja...@puppetlabs.com> wrote:
>> Dean Wilson wrote:
>>> I've attached a patch for a possible fix to
>>> http://projects.puppetlabs.com/issues/2224 (among other similar
>
>> +1 from me.
>
> I've attached a rebased version that includes some simple specs and
> should apply cleanly against master.
>
> Dean

Dean

Do you have a GitHub/Git repo I can pull this from?

Thanks

James Turnbull

[Dean Wilson]

Will this do?

http://github.com/deanwilson/puppet/tree/user_expiry

> --
> You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
> To post to this group, send email to puppe...@googlegroups.com.
> To unsubscribe from this group, send email to puppet-dev+...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.

[James Turnbull]

Dean Wilson wrote:
> Will this do?
>
> http://github.com/deanwilson/puppet/tree/user_expiry
>

Perfect!

James

[Markus Roberts]

+1; the only thing that caught my eye that I might have done
differently would be the clunky way we accumulate command arguments,
but that's a pre-existing issue & the submitted code looks correct and
consistent with the present system, so no worries.

-----------------------------------------------------------
The power of accurate observation is
commonly called cynicism by those
who have not got it.  ~George Bernard Shaw
------------------------------------------------------------