[SCM] Puppet - System Automation branch, 0.25.x, updated. 0.25.1-19-gadc0a4e

0 views

Skip to first unread message

git version control

unread,

Nov 13, 2009, 2:35:10 AM11/13/09

to puppet...@googlegroups.com

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Puppet - System Automation".

The branch, 0.25.x has been updated
via adc0a4ed939a717e8735485d493bde28ceab5ac0 (commit)
from 65f601a99a0ca7ebacfda7a6becd8af9fe9eaacb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit adc0a4ed939a717e8735485d493bde28ceab5ac0
Author: Markus Roberts <Mar...@reality.com>
Date: Mon Oct 19 21:51:32 2009 -0700

Fix for #2661 and related issues

If setup code for a process depends on network connectivity
it needs to be protected with a rescue clause as much as the
main body of the process.

Further, Timeout exceptions aren't under StandardError and thus
aren't caught by an un-typed rescue clause. This doesn't matter
if we've morphed the exception, but will cause the program to
fail if we haven't.

There are many places where these concerns _might_ cause a problem
but in most cases they never will in practice; this patch addresses
the five cases where I have been able to confirm that it actually
can cause the client daemon to exit and two more where I suspect
(but can not prove) that it could.

This is an extension of the prior patch to cover additional cases
found by automated testing (repeated catalog runs with a 1% chance
of timeout forced on all timeout-bound operations, ~5000 runs).

The new cases recurred multiple times (>100 each) and in a final pass
with these corrected (~2500 runs) no additional cases were found.

-----------------------------------------------------------------------

Summary of changes:
lib/puppet/agent.rb | 4 ++--
lib/puppet/configurer.rb | 2 +-
lib/puppet/configurer/fact_handler.rb | 5 ++---
lib/puppet/indirector/ldap.rb | 2 +-
4 files changed, 6 insertions(+), 7 deletions(-)