[puppetlabs/puppet] e118d2: (PUP-3239) Refactor node environment validation

[GitHub]

Branch: refs/heads/master
Home: https://github.com/puppetlabs/puppet
Commit: e118d22cd9ea16222bbe3ce119165b53ff603c80
https://github.com/puppetlabs/puppet/commit/e118d22cd9ea16222bbe3ce119165b53ff603c80
Author: Britt Gresham <br...@puppetlabs.com>
Date: 2014-10-03 (Fri, 03 Oct 2014)

Changed paths:
M lib/puppet/node/environment.rb
M lib/puppet/parser/compiler.rb
M spec/unit/node/environment_spec.rb
M spec/unit/parser/compiler_spec.rb

Log Message:
-----------
(PUP-3239) Refactor node environment validation

Prior to this, the compiler was responsible for testing the environment
and producing an error message. This change pulls the validation step
into node environment, breaking the error message up so that any
component can check if an environment has setting conflicts and return a
uniform error message. This will make it easier to add other
environment checks.

We refrained from including a more general error message handling
mechanism similar to what is currently in POPS because generalizing that
is a bigger task more suited to a broader internationalization epic.


Commit: 1e1412dfa719354854ea551fa20eea8a0ec448de
https://github.com/puppetlabs/puppet/commit/1e1412dfa719354854ea551fa20eea8a0ec448de
Author: Josh Partlow <jpar...@glatisant.org>
Date: 2014-10-03 (Fri, 03 Oct 2014)

Changed paths:
M lib/puppet/node/environment.rb
M lib/puppet/parser/compiler.rb
M spec/unit/node/environment_spec.rb
M spec/unit/parser/compiler_spec.rb

Log Message:
-----------
Merge pull request #3117 from demophoon/feature/master/pup-3239-environment-validation

(PUP-3239) Stop compilation if $environment has bad manifest settings


Compare: https://github.com/puppetlabs/puppet/compare/7ce23ac2b9cb...1e1412dfa719