Jira (FACT-1357) puppet-agent build fails on facter unit test if bundle is installed

[Michael Smith (JIRA)]

Michael Smith assigned an issue to Unassigned

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed Change By: Michael Smith Assignee: Michael Smith Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

[Michael Smith (JIRA)]

Michael Smith updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Michael Smith Story Points: 2 Summary: puppet-agent build fails on facter unit test if  ruby  bundle  is installed Sprint: Client Triage Scrum Team: Client Platform The facter test runs  '  {{ bundle exec rspec ' }} if {{bundle}} is found , however  '  {{ bundle install ' }}  has not been executed. Note this issue is not specific to the local engine, but other engines will likely be running the build in an environment where  ruby  {{bundle}}  is not installed. The Facter documentation says "If a ruby was found during configuration, execute the following command before running tests: $ bundle install --gemfile lib/Gemfile" The CMakeLists.txt file checks for the existence of the ruby and bundle commands. If both are found, the test is added. Error: {code} 2: Test command: /tmp/ruby/gems/bin/bundle "exec" "rspec" 2: Test timeout computed to be: 9.99988e+06 2: /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/resolver.rb:354:in `block in verify_gemfile_dependencies_are_found!': Could not find gem 'rspec (~> 2.11.0)' in any of the gem sources listed in your Gemfile or available on this machine. (Bundler::GemNotFound) 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/resolver.rb:330:in `each' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/resolver.rb:330:in `verify_gemfile_dependencies_are_found!' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/resolver.rb:199:in `start' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/resolver.rb:183:in `resolve' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/definition.rb:198:in `resolve' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/definition.rb:137:in `specs' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/definition.rb:182:in `specs_for' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/definition.rb:171:in `requested_specs' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/environment.rb:18:in `requested_specs' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/runtime.rb:13:in `setup' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler.rb:92:in `setup' 2:  from /tmp/ruby/gems/gems/bundler-1.11.2/lib/bundler/setup.rb:18:in `<top (required)>' 2:  from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' 2:  from /opt/puppetlabs/puppet/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require' 2/3 Test #2: libfacter specs ..................***Failed    0.34 sec test 3     Start 3: facter smoke {code}

Add Comment

[Michael Smith (JIRA)]

Michael Smith commented on FACT-1357

Re: puppet-agent build fails on facter unit test if bundle is installed The way we handle rspec is messy and requires manual setup. This causes packaging to fail if trying to do a local packaging build. We could do bundle setup in the project bin directory as part of make test, and use it to run specs; or separate rspec out of make test, and require multiple manual steps. This could also be fixed by running bundle install before make test in puppet-agent.

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg updated an issue

Facter / FACT-1357

puppet-agent build fails on facter unit test if bundle is installed

Change By: Kylo Ginsberg Sprint: Client  Triage  2016-04-10 (C++)

Add Comment

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Steve Barlow Fix Version/s: FACT 3.x

Add Comment

This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)

[Steve Barlow (JIRA)]

Steve Barlow updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Steve Barlow Sprint: Client 2016-04-06 (C++)

Add Comment

[Branan Riley (JIRA)]

Branan Riley commented on FACT-1357

Re: puppet-agent build fails on facter unit test if bundle is installed I'm inclined to make this a p-a ticket and just run the bundle install. That seems like the lowest-resistance path to cleaning it up

Add Comment

[Michael Smith (JIRA)]

Michael Smith commented on FACT-1357

Re: puppet-agent build fails on facter unit test if bundle is installed

That could potentially impact packaging, depending on what Ruby you install bundle into.

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1357

puppet-agent build fails on facter unit test if bundle is installed

Change By: Branan Riley Story Points: 2

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Branan Riley Sprint: Agent Grooming

Add Comment

[Branan Riley (JIRA)]

Branan Riley commented on FACT-1357

Re: puppet-agent build fails on facter unit test if bundle is installed Per discussion in triage, we don't think we've ever gotten any value out of running these during the vanagon build. We are inclined to just remove that step from the Vanagon project. We already disable them on several platforms where running them is difficult.

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1357

puppet-agent build fails on facter unit test if bundle is installed

Change By: Branan Riley Labels: triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Moses Mendoza Labels: triaged

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Branan Riley Team: Agent

Add Comment

[Geoff Nichols (JIRA)]

Geoff Nichols updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Geoff Nichols Sprint: Agent Grooming

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Branan Riley Labels: triaged

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1357 puppet-agent build fails on facter unit test if bundle is installed

Change By: Branan Riley Fix Version/s: FACT 3.y

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-1357

Re: puppet-agent build fails on facter unit test if bundle is installed This is no longer an issue in puppet-agent#main and we don't have plans on fixing this in puppet-agent#6.x, so I'm going to close.

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)