Jira (PUP-7520) Puppet profiling timers do not use a monotonic clock

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock Change By: Charlie Sharpsteen Puppet has support for timing and profiling execution through the {{Puppet::Util::Profiler::WallClock}} class, used for profiling Puppet Server operations, and the {{Puppet::Util.thinmark}} method, used for measuring things like resource application. Historically these methods have measured time by calling {{Time.now}}. However, this method returns a value from the OS REALTIME clock, which can be affected by  thinks  events  like NTP updates. Since the puppet agent often initiates a NTP update, these jumps can create confusing profile resullts. In 2.1.0, Ruby added methods to access a monotonic clock which isn't affected by things like NTP updates. We should prefer this clock for profiling timers when it is available: https://ruby-doc.org/core-2.1.0/Process.html Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen created an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Issue Type: Bug Affects Versions: PUP 4.10.1 Assignee: Unassigned Created: 2017/05/11 9:17 AM Priority: Normal Reporter: Charlie Sharpsteen Puppet has support for timing and profiling execution through the Puppet::Util::Profiler::WallClock class, used for profiling Puppet Server operations, and the Puppet::Util.thinmark method, used for measuring things like resource application. Historically these methods have measured time by calling Time.now. However, this method returns a value from the OS REALTIME clock, which can be affected by thinks like NTP updates. Since the puppet agent often initiates a NTP update, these jumps can create confusing profile resullts.

In 2.1.0, Ruby added methods to access a monotonic clock which isn't affected by things like NTP updates. We should prefer this clock for profiling timers when it is available: https://ruby-doc.org/core-2.1.0/Process.html

Add Comment

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: Charlie Sharpsteen Puppet has support for timing and profiling execution through the {{Puppet::Util::Profiler::WallClock}} class, used for profiling Puppet Server operations, and the {{Puppet::Util.thinmark}} method, used for measuring things like resource application. Historically these methods have measured time by calling {{Time.now}}. However, this method returns a value from the OS REALTIME clock, which can be affected by events like NTP updates. Since the puppet agent often initiates a NTP update, these jumps can create confusing profile  resullts  results .

In 2.1.0, Ruby added methods to access a monotonic clock which isn't affected by things like NTP updates. We should prefer this clock for profiling timers when it is available: https://ruby-doc.org/core-2.1.0/Process.html

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: Josh Cooper Labels: performance triaged

Add Comment

[Charlie Sharpsteen (JIRA)]

Charlie Sharpsteen updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: Charlie Sharpsteen Method Found: Inspection

Add Comment

[Austin Boyd (Jira)]

Austin Boyd updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: Austin Boyd Zendesk Ticket Count: 1 Zendesk Ticket IDs: 38432

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Austin Boyd (Jira)]

Austin Boyd updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: Austin Boyd Labels: jira_escalated performance

Add Comment

[David McTavish (Jira)]

David McTavish updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: David McTavish Labels: final_triage jira_escalated nice-to-have performance

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[David McTavish (Jira)]

David McTavish updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: David McTavish Priority: Normal Low

Add Comment

[Charlie Sharpsteen (Jira)]

Charlie Sharpsteen commented on PUP-7520

Re: Puppet profiling timers do not use a monotonic clock Re-opening this one as inaccurate profiling results are far, far worse than not having any profiler functionality. This condition is uncommon, but Puppet does manage the sort of system configuration that can cause clock jumps. This change probably doesn't even need to wait for a semver major like Puppet 8 at this point as Ruby 2.1 and older are deeply end of life.

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Maggie Dreyer (Jira)]

Maggie Dreyer updated an issue

Puppet / PUP-7520

Puppet profiling timers do not use a monotonic clock

Change By: Maggie Dreyer Team: Froyo Phoenix

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: Josh Cooper

Labels: final_triage jira_escalated nice-to-have performance

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7520 Puppet profiling timers do not use a monotonic clock

Change By: Josh Cooper Epic Link: PUP-5773

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)