Jira (PUP-2368) using booleans result in unmanaged property

[Arney (JIRA)]

Arney commented on PUP-2368

Re: using booleans result in unmanaged property This problem is still present in Puppet 4.3.2 and here is a minimal example: puppet/type/foo.rb require 'puppet/property/boolean'   Puppet::Type.newtype(:foo) do newparam(:name) newproperty(:boolprop, parent: Puppet::Property::Boolean) end puppet/provider/foo/bar.rb Puppet::Type.type(:foo).provide(:bar) do   def boolprop # Force change, always return the opposite !resource.should(:boolprop) end   def boolprop=(value) p "Setting value: #{value}" end   end $ puppet resource foo works boolprop=true "Setting value: true" Notice: /Foo[works]/boolprop: boolprop changed 'false' to 'true' foo { 'works': boolprop => 'false', } $ puppet resource foo broken boolprop=false foo { 'broken': boolprop => 'true', } Setting a boolean property to false will never trigger its setter. Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-2368

using booleans result in unmanaged property

Change By: Maggie Dreyer Labels: triaged

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Puppet / PUP-2368 using booleans result in unmanaged property

Change By: Maggie Dreyer Team: Agent

Add Comment

[Maggie Dreyer (JIRA)]

Maggie Dreyer commented on PUP-2368

Re: using booleans result in unmanaged property This is still broken in Puppet 5, see https://github.com/puppetlabs/puppet/blob/master/lib/puppet/transaction/resource_harness.rb#L123.

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Puppet / PUP-2368

using booleans result in unmanaged property

Change By: Moses Mendoza Labels: triaged

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-2368 using booleans result in unmanaged property

Change By: Josh Cooper Sub-team: Coremunity

Add Comment

This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-2368 using booleans result in unmanaged property

Change By: Josh Cooper Sprint: Platform Core Grooming

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-2368

Re: using booleans result in unmanaged property PUP-8442 should resolve the issue for parameter defaults. This issue is related, but different because properties are managed and we want to be able to set the current value to false.

Add Comment

[David Schmitt (JIRA)]

David Schmitt commented on PUP-2368

Re: using booleans result in unmanaged property

This is far enough up the stack that it also affects the Resource API.

Add Comment

[David Schmitt (JIRA)]

David Schmitt commented on PUP-2368

Re: using booleans result in unmanaged property

The Resource API now carries a workaround for that: https://github.com/puppetlabs/puppet-resource_api/pull/62 , basically using :true and :false when talking to puppet. This does not affect the provider, which still can work with regular booleans.

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-2368

using booleans result in unmanaged property

Change By: Josh Cooper Sprint: Platform Core Grooming

Add Comment

[Mykhailo Danylenko (JIRA)]

Mykhailo Danylenko commented on PUP-2368

Re: using booleans result in unmanaged property Hey, could this be finally fixed in some way? I've spent this week digging through puppet internals to understand, why my resource isn't being managed (as it turned out, only boolean properties were not managed, but they comprise the majority of my resource). Or at least documented in the source, so that developers don't waste their time debugging their code, when the problem lies in puppet's. P.S. I am using puppet 5.5.6 from the official debian repo.

Add Comment

[David Schmitt (JIRA)]

David Schmitt commented on PUP-2368

Re: using booleans result in unmanaged property

Mykhailo Danylenko to avoid this (and many other issues) please use the Resource API: https://puppet.com/docs/puppet/6.0/custom_resources.html The Resource API is available to install on puppet 4 and 5 as a gem (there is also a module for that), and it is shipped fully supported with puppet 6.

Add Comment

[Mykhailo Danylenko (JIRA)]

Mykhailo Danylenko commented on PUP-2368

Re: using booleans result in unmanaged property

David Schmitt thanks for the suggestion. Well, if it's the future, I guess I'll switch to that. Still, I think a note in the Puppet::Property::Boolean class would be helpful.

Add Comment

[Trevor Vaughan (Jira)]

Trevor Vaughan commented on PUP-2368

Re: using booleans result in unmanaged property

The Resource API hasn't reached parity with the underlying API so this will still need to be addressed at some point. Documentation outside of this ticket would be great.

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Trevor Vaughan (Jira)]

Trevor Vaughan commented on PUP-2368

Re: using booleans result in unmanaged property

Removing the inheritance on Puppet::Property::Boolean and adding the following appears to do the trick: def should return nil unless defined?(@should) (@should - [true,:true]).empty? end It's possible that the underlying puppet code could detect whether or not the thing is a boolean in the native should code and "do the right thing".

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Puppet / PUP-2368

using booleans result in unmanaged property

Change By: Michael Hashizume Team: Coremunity Phoenix

Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)