Jira (PDB-5134) PuppetDB terminus not profiling catalog submission

Austin Blatt (Jira)

unread,

May 19, 2021, 5:37:04 PM5/19/21

to puppe...@googlegroups.com

Austin Blatt created an issue

PuppetDB /

PDB-5134

PuppetDB terminus not profiling catalog submission

Issue Type:	Bug
Assignee:	Austin Blatt
Created:	2021/05/19 2:36 PM
Fix Versions:	PDB 7.3.2
Priority:	Normal
Reporter:	Austin Blatt

looks like there is a failure in puppetserver’s puppetdb integration test, where it looks like the metric command_submit_replace_catalog is missing from the puppetdb-metrics

16:49:12 * Validate PuppetDB metrics captured by puppet-profiler service

16:49:12

16:49:12   unplowed-climb.delivery.puppetlabs.net (unplowed-climb.delivery.puppetlabs.net) 23:49:12$ curl -k https://localhost:8140/status/v1/services/puppet-profiler?level=debug

16:49:12       % Total    % Re    ceived % Xferd  Average Speed       Time    Time     Time  Current

16:49:12                                      D    load  Upload   Total   Spent    Left  Speed

16:49:12       0     0    0     0    0     0      0          0 --:--:-- --:--:-- --:--:--     0    100  1068  100  1068    0     0   8754      0 --:--:-- --:--:-- --:--:--  8754

16:49:12     {"service_version":"7.1.3-SNAPSHOT","service_status_version":1,"detail_level":"debug","state":"running","status":{"experimental":{"function-metrics":[{"function":"lookup","count":2,"mean":46,"aggregate":92},{"function":"puppetdb_query","count":1,"mean":51,"aggregate":51}],"resource-metrics":[{"resource":"Class[main]","count":2,"mean":202,"aggregate":404}],"catalog-metrics":[{"metric":"compile","count":2,"mean":680,"aggregate":1360},{"metric":"find_node","count":2,"mean":20,"aggregate":40}],"puppetdb-metrics":[{"metric":"resource_search","count":8,"mean":22,"aggregate":176},{"metric":"command_submit_replace_facts","count":2,"mean":81,"aggregate":162},{"metric":"command_submit_store_report","count":2,"mean":50,"aggregate":100},{"metric":"query","count":1,"mean":49,"aggregate":49},{"metric":"catalog_munge","count":2,"mean":22,"aggregate":44},{"metric":"report_convert_to_wire_format_hash","count":2,"mean":16,"aggregate":32},{"metric":"facts_encode","count":2,"mean":2,"aggregate":4}],"inline-metrics":[]}},"active_alerts":[],"service_name":"puppet-profiler"}

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

Austin Blatt (Jira)

unread,

May 19, 2021, 5:38:05 PM5/19/21

to puppe...@googlegroups.com

Austin Blatt updated an issue

PuppetDB /

PDB-5134

PuppetDB terminus not profiling catalog submission

Change By:	Austin Blatt
Method Found:	Needs Assessment Automated Test

Add Comment

Austin Blatt (Jira)

unread,

May 19, 2021, 5:39:04 PM5/19/21

to puppe...@googlegroups.com

Austin Blatt commented on

PDB-5134

Re: PuppetDB terminus not profiling catalog submission

The note here was right https://github.com/puppetlabs/puppetserver/blob/6.x/acceptance/suites/tests/00_smoke/puppetdb_integration.rb

# NOTE: If these tests fail, then likely someone changed a metric

    # name passed to Puppet::Util::Profiler.profile over in the Ruby

    # terminus code of the PuppetDB project without realizing that is a

    # breaking change to metrics critical for measuring compiler performance.

%w[

      facts_encode command_submit_replace_facts

      catalog_munge command_submit_replace_catalog

      report_convert_to_wire_format_hash command_submit_store_report

      resource_search query

    ].each do |metric_name|

In ~~PDB-5107~~ we accidentally dropped some the the profiling that the terminus does for catalog submission which meant that the metric name didn't exist