Jira (BOLT-1166) Windows compatibility for orchestrator_client-ruby persistent http connections

6 views
Skip to first unread message

Cas Donoghue (JIRA)

unread,
Mar 6, 2019, 1:06:05 PM3/6/19
to puppe...@googlegroups.com
Cas Donoghue created an issue
 
Puppet Task Runner / Bug BOLT-1166
Windows compatibility for orchestrator_client-ruby persistent http connections
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2019/03/06 10:05 AM
Priority: Normal Normal
Reporter: Cas Donoghue

A new feature was introduced with https://github.com/puppetlabs/orchestrator_client-ruby/pull/19 that allowed persistent HTTP connections. The implementation has a dependency on https://github.com/drbrain/net-http-persistent which is an unmaintained project that is currently not compatible with Bolt on windows. This feature was released to Rubygems with an increment in the minor version from (from 0.3.x to 0.4.x) along with the work in https://tickets.puppetlabs.com/browse/BOLT-1076

In order to satisfy BOLT-1076, the persistent http connection commits will be reverted and a new patch version in the 0.3.x series will be released with the BOLT-1076 commits. The http persistence commits should be "un-reverted" and then re-factored to use gems that are compatible with bolt while providing the same persistent connection behavior and released as a 0.4.x version.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Cas Donoghue (JIRA)

unread,
Mar 19, 2019, 12:18:03 PM3/19/19
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
A new feature was introduced with https://github.com/puppetlabs/orchestrator_client-ruby/pull/19 that allowed persistent HTTP connections. The implementation has a dependency on https://github.com/drbrain/net-http-persistent which is an unmaintained project that is currently not compatible with Bolt on windows. This feature was released to Rubygems with an increment in the minor version from (from 0.3.x to 0.4.x) along with the work in https://tickets.puppetlabs.com/browse/BOLT-1076

In order to satisfy BOLT-1076, the persistent http connection commits will be reverted and a new patch version in was implemented such that it only uses the 0.3.x series will be released with the BOLT net - 1076 commits. The http persistence commits should be "un - reverted" and then re persistent gem on non - factored windows. Look in to use gems that are compatible with bolt while providing the same persistent connection behavior and released as a 0 windows compatability . 4.x version.

Cas Donoghue (JIRA)

unread,
Mar 19, 2019, 12:19:02 PM3/19/19
to puppe...@googlegroups.com

Alex Dreyer (JIRA)

unread,
May 15, 2019, 5:28:03 PM5/15/19
to puppe...@googlegroups.com
Alex Dreyer updated an issue
Change By: Alex Dreyer
A new feature was introduced with https://github.com/puppetlabs/orchestrator_client-ruby/pull/19 that allowed persistent HTTP connections. The implementation has a dependency on https://github.com/drbrain/net-http-persistent which is an unmaintained project that is currently not compatible with Bolt on windows. This feature was released to Rubygems with an increment in the minor version from (from 0.3.x to 0.4.x) along with the work in https://tickets.puppetlabs.com/browse/BOLT-1076

In order to satisfy BOLT-1076, the persistent http connection was implemented such that it only uses the net-http-persistent gem on non-windows. Look in to windows compatability.

The docs for how to configure orchestrator client are inaccurate now too. They should be updated as part of this work.

Alex Dreyer (JIRA)

unread,
May 15, 2019, 5:28:04 PM5/15/19
to puppe...@googlegroups.com

Thomas Kishel (JIRA)

unread,
May 16, 2019, 6:08:03 PM5/16/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages