Jira (PUP-2301) puppet module list --tree output shows dependencies incorrectly

11 views
Skip to first unread message

John Duarte (JIRA)

unread,
Jul 17, 2015, 2:24:10 PM7/17/15
to puppe...@googlegroups.com
John Duarte commented on Bug PUP-2301
 
Re: puppet module list --tree output shows dependencies incorrectly

Ping. Are we still interested in fixing this?

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
Atlassian logo

Anderson Mills (JIRA)

unread,
Jul 20, 2015, 2:05:11 PM7/20/15
to puppe...@googlegroups.com

John, this has been lower priority than many other PMT issues that have come up. It's still on the active list, but not at the top.

Maggie Dreyer (JIRA)

unread,
May 16, 2017, 2:37:05 PM5/16/17
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
 
Puppet / Bug PUP-2301
Change By: Maggie Dreyer
Labels: docs_reviewed  triaged
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Moses Mendoza (JIRA)

unread,
May 18, 2017, 1:49:22 PM5/18/17
to puppe...@googlegroups.com
Moses Mendoza updated an issue
Change By: Moses Mendoza
Labels: docs_reviewed  triaged

Tim Mooney (Jira)

unread,
Apr 24, 2020, 3:57:04 PM4/24/20
to puppe...@googlegroups.com
Tim Mooney commented on Bug PUP-2301
 
Re: puppet module list --tree output shows dependencies incorrectly

Re-opening this issue, as it's still present in very recent puppet.

$ rpm -qa | egrep puppet
puppet-agent-6.14.0-1.el7.x86_64
puppet6-release-6.0.0-8.el7.noarch
puppetserver-6.9.2-1.el7.noarch

/etc/puppetlabs/code/environments/production/forge-modules
├─┬ puppetlabs-apache (v5.2.0)
│ ├── puppetlabs-stdlib (v4.20.0)
│ └─┬ puppetlabs-concat (v6.2.0)
│   └── puppetlabs-translate (v1.1.0)
├── mosen-cups (v1.2.1)
├─┬ puppetlabs-java (v6.2.0)
│ └── puppet-archive (v1.3.0)
├── puppetlabs-mailalias_core (v1.0.6)
├── puppetlabs-mysql (v10.0.0)
├── Slashbunny-phpfpm (v0.0.8)
├─┬ puppetlabs-rabbitmq (v5.5.0)
│ ├── puppetlabs-apt (v2.2.2)
│ └── puppet-staging (v1.0.7)
├── stschulte-rpmkey (v1.0.3)
└── puppetlabs-tomcat (v4.0.0)

But note that `puppetlabs-tomcat` has dependencies that are not listed in that view:

 

$ grep -A 13 dependencies tomcat/metadata.json
  "dependencies": [
    {
      "name": "puppetlabs/stdlib",
      "version_requirement": ">= 4.6.0 < 7.0.0"
    },
    {
      "name": "puppetlabs/concat",
      "version_requirement": ">= 1.1.0 < 7.0.0"
    },
    {
      "name": "puppet/archive",
      "version_requirement": ">= 1.0.0 < 5.0.0"
    }
  ],

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Tim Mooney (Jira)

unread,
Apr 24, 2020, 3:58:04 PM4/24/20
to puppe...@googlegroups.com
Tim Mooney updated an issue
 
Change By: Tim Mooney
Affects Version/s: PUP 6.14.0

Josh Cooper (Jira)

unread,
Apr 27, 2020, 7:37:04 PM4/27/20
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Unassigned
Change By: Josh Cooper
Assignee: Anderson Mills

Greg (Jira)

unread,
May 22, 2020, 4:25:03 PM5/22/20
to puppe...@googlegroups.com
Greg commented on Bug PUP-2301
 
Re: puppet module list --tree output shows dependencies incorrectly

If you're up for dirty hacks, in lib/puppet/face/module/list.rb it's the line 

next if @seen[(mod.forge_name or mod.name)]

in list_build_tree.  Comment it out and you'll get a full tree (with lots of 'repeats') that more accurately reflects reality.

Josh Cooper (Jira)

unread,
Jun 9, 2020, 11:52:03 AM6/9/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Team: Puppet Developer Experience

Josh Cooper (Jira)

unread,
Jan 27, 2021, 1:19:04 AM1/27/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Puppet Developer Experience Night's Watch

Josh Cooper (Jira)

unread,
Jun 9, 2021, 6:40:01 PM6/9/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-2301
 
Re: puppet module list --tree output shows dependencies incorrectly

We don't have plans on fixing this anytime soon, so I'm going to close it. However, if someone would like to contribute a pull request, we'd be happy to help. Most likely we'd want to:

1. Add an option to lib/puppet/face/module/list.rb, something like '--all'?
2. In list_build_tree, lookup the value of the option and conditionally output all dependencies or not.

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages