Jira (FACT-2618) Incorrect log format on non-executable external fact scripts

[Garrett Guillotte (Jira)]

Garrett Guillotte created an issue

Facter / FACT-2618 Incorrect log format on non-executable external fact scripts Issue Type: Bug Affects Versions: FACT 3.14.9 Assignee: Ciprian Badescu Created: 2020/05/15 5:57 PM Fix Versions: FACT 3.14.10 Priority: Normal Reporter: Garrett Guillotte Ciprian Badescu in https://github.com/puppetlabs/facter/commit/76a7bab5c75ff0b1b6a46cc7242582c24adf701d: Before this change, the log message format is wrong and the following is logged in case external facts file is not proper executable: 2020-04-09 15:07:49.499276 ERROR puppetlabs.facter - error while processing "%1%" for external facts: %2% After this fix, the proper message will be logged: 2020-04-09 15:10:49.546980 ERROR puppetlabs.facter - error while processing "/opt/puppetlabs/facter/facts.d/a.sh" for external facts: child process returned non-zero exit status (8). Filing this as a bug ticket and resolving it so we can reference this fix. Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Garrett Guillotte (Jira)]

Garrett Guillotte updated an issue

Facter / FACT-2618 Incorrect log format on non-executable external fact scripts

CC Jean Bond — this was an issue fixed in Facter 3.14.10/PE 2019.7 but did not have a JIRA ticket prior to the release. Can we get a release note for this? Change By: Garrett Guillotte Release Notes: Bug Fix Release Notes Summary: If an external fact script cannot be executed, Facter 3.14.9's logging will not indicate what happened, and instead outputs `error while processing "%1%" for external facts: %2%`. This is fixed in Facter 3.14.10, which will output the reported error.

Add Comment

[Jean Bond (Jira)]

Jean Bond commented on FACT-2618

Re: Incorrect log format on non-executable external fact scripts Thanks for the heads up, Garrett Guillotte. Claire Cadman, could you please add this release note for Facter?

Add Comment

[Garrett Guillotte (Jira)]

Garrett Guillotte updated an issue

Facter / FACT-2618

Incorrect log format on non-executable external fact scripts

Change By: Garrett Guillotte [~ciprian.badescu] in https://github.com/puppetlabs/facter/commit/76a7bab5c75ff0b1b6a46cc7242582c24adf701d: {quote}Before this change, the log message format is wrong and the following is logged in case external facts file is not proper executable: {code} 2020-04-09 15:07:49.499276 ERROR puppetlabs.facter - error while processing "%1%" for external facts: %2% {code}

After this fix, the proper message will be logged:

{code}

2020-04-09 15:10:49.546980 ERROR puppetlabs.facter - error while processing "/opt/puppetlabs/facter/facts.d/a.sh" for external facts: child process returned non-zero exit status (8).

{code}{quote}

Filing this as a bug ticket and resolving it so we can reference this fix.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman commented on FACT-2618

Re: Incorrect log format on non-executable external fact scripts Added: https://puppet.com/docs/puppet/latest/release_notes_facter.html#resolved-issues.

Add Comment