Jira (FACT-1597) "Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug." on AIX

2 views
Skip to first unread message

Geoff Nichols (JIRA)

unread,
Oct 7, 2017, 8:45:02 PM10/7/17
to puppe...@googlegroups.com
Geoff Nichols updated an issue
 
Facter / Bug FACT-1597
"Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug." on AIX
Change By: Geoff Nichols
Summary: WARN  puppetlabs.facter - "  Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. " on AIX
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Jeremiah Powell (JIRA)

unread,
Jan 24, 2018, 3:41:04 PM1/24/18
to puppe...@googlegroups.com
Jeremiah Powell updated an issue
Change By: Jeremiah Powell
Attachment: facter_trace_20180124.txt
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Jeremiah Powell (JIRA)

unread,
Jan 29, 2018, 2:29:03 PM1/29/18
to puppe...@googlegroups.com
Jeremiah Powell commented on Bug FACT-1597
 
Re: "Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug." on AIX

As reported on an AIX 7.1 system (oslevel 7100-04-04-1717). The code symbol returned is different each time.

{{2018-01-30 03:07:09.343582 INFO puppetlabs.facter - executed with command line: --puppet --debug --trace disks.
2018-01-30 03:07:09.347249 INFO leatherman.ruby:138 - ruby loaded from "/opt/puppetlabs/puppet/lib/libruby.so.2.1.0".
2018-01-30 03:07:09.396240 INFO leatherman.ruby:187 - using ruby version 2.1.9
2018-01-30 03:07:09.396477 INFO puppetlabs.facter - requested queries: disks.
2018-01-30 03:07:09.396659 DEBUG puppetlabs.facter - fact "facterversion" has resolved to "3.6.7".
2018-01-30 03:07:09.396759 DEBUG puppetlabs.facter - fact "aio_agent_version" has resolved to "1.10.8".
...
2018-01-30 03:07:40.465423 DEBUG puppetlabs.facter - got a disk: hdisk128
2018-01-30 03:07:40.465557 WARN puppetlabs.facter - Expected a Disk or SCSI disk device, got device co
de '!'. This is probably a Facter bug. Please report it, and include this error message.
2018-01-30 03:07:40.465648 DEBUG puppetlabs.facter - got a disk: hdisk127
2018-01-30 03:07:40.465750 WARN puppetlabs.facter - Expected a Disk or SCSI disk device, got device co
de '!'. This is probably a Facter bug. Please report it, and include this error message.
2018-01-30 03:07:40.465834 DEBUG puppetlabs.facter - got a disk: hdisk126
2018-01-30 03:07:40.465934 WARN puppetlabs.facter - Expected a Disk or SCSI disk device, got device co
de '!'. This is probably a Facter bug. Please report it, and include this error message.}}

This is an Oracle ASM system. ASM disks are not mounted or part of a logical volume. The are used by Oracle:

{{root@[servername]:/# ps -ef|grep -i pmon
oracle 42992018 1 0 Jan 28 - 2:18 ora_pmon_p[dbname]11
oracle 4653704 1 0 Nov 16 - 20:54 asm_pmon_+ASM1
root 10224434 24642096 0 01:38:17 pts/2 0:00 grep -i pmon}}

Disk devices are present for hdisk126 through hdisk128:
{{
[root@[servername]:/j# ls /dev/hdisk*
/dev/hdisk0 /dev/hdisk118 /dev/hdisk22 /dev/hdisk41 /dev/hdisk60 /dev/hdisk82
/dev/hdisk1 /dev/hdisk119 /dev/hdisk23 /dev/hdisk42 /dev/hdisk61 /dev/hdisk83
/dev/hdisk10 /dev/hdisk120 /dev/hdisk24 /dev/hdisk43 /dev/hdisk62 /dev/hdisk84
/dev/hdisk100 /dev/hdisk121 /dev/hdisk25 /dev/hdisk44 /dev/hdisk63 /dev/hdisk85
/dev/hdisk101 /dev/hdisk122 /dev/hdisk26 /dev/hdisk45 /dev/hdisk64 /dev/hdisk86
/dev/hdisk102 /dev/hdisk123 /dev/hdisk27 /dev/hdisk46 /dev/hdisk65 /dev/hdisk87
/dev/hdisk103 /dev/hdisk124 /dev/hdisk28 /dev/hdisk47 /dev/hdisk66 /dev/hdisk88
/dev/hdisk104 /dev/hdisk125 /dev/hdisk29 /dev/hdisk48 /dev/hdisk67 /dev/hdisk89
/dev/hdisk105 /dev/hdisk126 /dev/hdisk3 /dev/hdisk49 /dev/hdisk68 /dev/hdisk9
/dev/hdisk106 /dev/hdisk127 /dev/hdisk30 /dev/hdisk5 /dev/hdisk69 /dev/hdisk90
/dev/hdisk107 /dev/hdisk128 /dev/hdisk31 /dev/hdisk50 /dev/hdisk7 /dev/hdisk91
/dev/hdisk108 /dev/hdisk13 /dev/hdisk32 /dev/hdisk51 /dev/hdisk70 /dev/hdisk92
/dev/hdisk109 /dev/hdisk14 /dev/hdisk33 /dev/hdisk52 /dev/hdisk74 /dev/hdisk93
/dev/hdisk110 /dev/hdisk15 /dev/hdisk34 /dev/hdisk53 /dev/hdisk75 /dev/hdisk94
/dev/hdisk111 /dev/hdisk16 /dev/hdisk35 /dev/hdisk54 /dev/hdisk76 /dev/hdisk95
/dev/hdisk112 /dev/hdisk17 /dev/hdisk36 /dev/hdisk55 /dev/hdisk77 /dev/hdisk96
/dev/hdisk113 /dev/hdisk18 /dev/hdisk37 /dev/hdisk56 /dev/hdisk78 /dev/hdisk97
/dev/hdisk114 /dev/hdisk19 /dev/hdisk38 /dev/hdisk57 /dev/hdisk79 /dev/hdisk98
/dev/hdisk115 /dev/hdisk2 /dev/hdisk39 /dev/hdisk58 /dev/hdisk8 /dev/hdisk99
/dev/hdisk116 /dev/hdisk20 /dev/hdisk4 /dev/hdisk59 /dev/hdisk80
/dev/hdisk117 /dev/hdisk21 /dev/hdisk40 /dev/hdisk6 /dev/hdisk81}}

Most do not have volumes on them:

{{root@[servername]:/# lspv | egrep '12[2-8]'
hdisk123 none None
hdisk124 none None
hdisk125 none None
hdisk75 00f88063d14dc128 dv2_disk1
hdisk122 none None}}

and the disks show up in the device list:

root@asiapwap1:/# lsdev -Cc disk | egrep 'hdisk12[2-8]'
hdisk122 Available 07-00-02 EMC INVISTA FCP MPIO Disk
hdisk123 Available 07-00-02 EMC INVISTA FCP MPIO Disk
hdisk124 Available 07-00-02 EMC INVISTA FCP MPIO Disk
hdisk125 Available 07-00-02 EMC INVISTA FCP MPIO Disk
hdisk126 Available 00-01-02 MPIO Other FC SCSI Disk Drive
hdisk127 Available 00-01-02 MPIO Other FC SCSI Disk Drive
hdisk128 Available 00-01-02 MPIO Other FC SCSI Disk Drive

but return odd status in the ODM:

root@[servername]:/# /usr/lib/methods/cfgscsidisk -l hdisk128
root@[servername]:/# echo $?
82

82 is code for 'not configured.' This would be expected for an ASM disk.

These ASM disks do correctly report attribute details:

{{root@[servername]:/# lsattr -El hdisk128
PCM PCM/friend/fcpother Path Control Module False
PR_key_value none Persistant Reserve Key Value True+
algorithm fail_over Algorithm True+
clr_q no Device CLEARS its Queue on error True
dist_err_pcnt 0 Distributed Error Percentage True
dist_tw_width 50 Distributed Error Sample Time True
hcheck_cmd test_unit_rdy Health Check Command True+
hcheck_interval 60 Health Check Interval True+
hcheck_mode nonactive Health Check Mode True+
location Location Label True+
lun_id 0x0 Logical Unit Number ID False
lun_reset_spt yes LUN Reset Supported True
max_coalesce 0x40000 Maximum Coalesce Size True
max_retry_delay 60 Maximum Quiesce Time True
max_transfer 0x80000 Maximum TRANSFER Size True
node_name 0x2ff70002ac009266 FC Node Name False
pvid 00f8806330a069a60000000000000000 Physical volume identifier False
q_err yes Use QERR bit True
q_type simple Queuing TYPE True
queue_depth 16 Queue DEPTH True+
reassign_to 120 REASSIGN time out value True
reserve_policy no_reserve Reserve Policy True+
rw_timeout 30 READ/WRITE time out value True
scsi_id 0x301aa0 SCSI ID False
start_timeout 60 START unit time out value True
timeout_policy fail_path Timeout Policy True+
unique_id 251000B200009266000002VV083PARdatafcp Unique device identifier False
ww_name 0x22220002ac009266 FC World Wide Name False}}

Also some disks without errors in facter don't list as expected in the ODM:

{{root@[servername]:/# root@asiapwap1:/# cfgmgr
Method error (/usr/lib/methods/cfgscsidisk -l hdisk10 ):
0514-082 The requested function could only be performed for some of
the specified paths.
Method error (/usr/lib/methods/cfgscsidisk -l hdisk10 ):
0514-082 The requested function could only be performed for some of
the specified paths.
Method error (/usr/lib/methods/cfgscsidisk -l hdisk10 ):
0514-082 The requested function could only be performed for some of
the specified paths.
Method error (/usr/lib/methods/cfgefscsi -l fscsi3 ):
0514-061 Cannot find a child device.
Method error (/usr/lib/methods/cfgefscsi -l fscsi5 ):
0514-061 Cannot find a child device.
Method error (/usr/lib/methods/cfgscsidisk -l hdisk10 ):
0514-082 The requested function could only be performed for some of
the specified paths.}}

Halim Wijaya (JIRA)

unread,
Feb 7, 2018, 1:27:03 AM2/7/18
to puppe...@googlegroups.com
Halim Wijaya updated an issue
 
Change By: Halim Wijaya
Priority: Normal Major
Running Puppet Enterprise 2017.1.1
Previous facter: 3.5.0 (commit 872c5707799c1c30925b632f20eab763ec03b5a4)
New facter: 3.6.2 (commit 36e4f036cfab9e283f6b47bd5e3890a4de54c5ff)

After upgrading AIX Client with puppet-agent-1.9.3-1.aix7.1.ppc.rpm, new version of facter returns warning below.

# facter

2017-03-28 13:10:48.912233 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
2017-03-28 13:10:48.912822 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
2017-03-28 13:10:48.913030 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
2017-03-28 13:10:48.913236 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
2017-03-28 13:10:48.913441 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
2017-03-28 13:10:48.914954 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
2017-03-28 13:10:48.915236 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
2017-03-28 13:10:48.915448 WARN  puppetlabs.facter - Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug. Please report it, and include this error message.
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

Geoff Nichols (JIRA)

unread,
Feb 8, 2018, 1:29:04 PM2/8/18
to puppe...@googlegroups.com

Branan Riley (JIRA)

unread,
Feb 8, 2018, 1:33:04 PM2/8/18
to puppe...@googlegroups.com
Branan Riley commented on Bug FACT-1597
 
Re: "Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug." on AIX

Generally, Facter outputs warnings when it knows fact output is going to be wrong. In this case, we can determine that some disk information is going to be missing from the output. The warning should be more clear on which disk is broken, at least.

Branan Riley (JIRA)

unread,
Feb 8, 2018, 1:35:03 PM2/8/18
to puppe...@googlegroups.com

Sean McDonald (JIRA)

unread,
Feb 20, 2018, 7:06:06 PM2/20/18
to puppe...@googlegroups.com

Branan Riley (JIRA)

unread,
Mar 26, 2018, 12:57:09 PM3/26/18
to puppe...@googlegroups.com
Branan Riley updated an issue
Change By: Branan Riley
Fix Version/s: FACT 3.6.10
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Branan Riley (JIRA)

unread,
Mar 26, 2018, 12:57:13 PM3/26/18
to puppe...@googlegroups.com

Branan Riley (JIRA)

unread,
Mar 26, 2018, 12:58:16 PM3/26/18
to puppe...@googlegroups.com
Branan Riley updated an issue
Change By: Branan Riley
Release Notes Summary: Facter now properly checks for errors when gathering disk information on AIX, so it should no longer warn or report bogus results for devices assigned to special uses such as databases.

Branan Riley (JIRA)

unread,
Mar 26, 2018, 1:00:12 PM3/26/18
to puppe...@googlegroups.com
Branan Riley commented on Bug FACT-1597
 
Re: "Expected a Disk or SCSI disk device, got device code ' '. This is probably a Facter bug." on AIX

The fix I've implemented mostly improves our error checking so we don't try to report on devices which are missing from /dev, or devices which return an error when we attempt to collect their size information.

I'm hopeful this will clean up all the bogus warnings, but I can't know for sure until the build goes out. If customers are still seeing this after the next release goes out to them, we can address what's particular about those cases in more detail

Enis Inan (JIRA)

unread,
Apr 9, 2018, 3:27:03 PM4/9/18
to puppe...@googlegroups.com

Enis Inan (JIRA)

unread,
Apr 13, 2018, 4:13:03 PM4/13/18
to puppe...@googlegroups.com

Austin Boyd (JIRA)

unread,
Dec 5, 2019, 6:37:04 AM12/5/19
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages