Jira (PUP-11689) Enable strict mode by default

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-11689 Enable strict mode by default Issue Type: Improvement Assignee: Unassigned Created: 2022/12/12 8:25 AM Fix Versions: PUP 8.0.0 Priority: Normal Reporter: Josh Cooper Puppet supports various strict language related settings. These were added in 2016 (puppet 4.x) and it's time to enable strict behavior by default. strict strict_variables Add Comment

This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)

[Ben Ford (Jira)]

Ben Ford commented on PUP-11689

Re: Enable strict mode by default I could be mistaken, but I think this means that spec-puppet has had strict_variables on for at least seven years. https://github.com/rodjek/rspec-puppet/blame/master/lib/rspec-puppet/adapters.rb#L153

Add Comment

[Morgan Rhodes (Jira)]

Morgan Rhodes updated an issue

Puppet / PUP-11689

Enable strict mode by default

Change By: Morgan Rhodes

Puppet supports various strict language related settings. These were added in 2016 (puppet 4.x) and it's time to enable strict behavior by default.

[strict|https://github.com/puppetlabs/puppet/blob/381a3e2b2e6858570fcc6e755bfae9eeff1226f1/lib/puppet/defaults.rb#L191] [strict_variables|https://github.com/puppetlabs/puppet/blob/381a3e2b2e6858570fcc6e755bfae9eeff1226f1/lib/puppet/defaults.rb#L2212] A good thing to verify - take a module like stdlib, test against puppet8 gem, change the setting for strict variables, and make sure the spec tests still pass. Note you can use the PUPPET_GEM_VERSION to pin to a local checkout of puppet rather than building a gem.

Add Comment

[Morgan Rhodes (Jira)]

Morgan Rhodes updated an issue

Puppet / PUP-11689 Enable strict mode by default

Change By: Morgan Rhodes Story Points: 2

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11689

Re: Enable strict mode by default Unfortunately, no. The adapter code just maps rspec config settings to puppet like: https://github.com/puppetlabs/rspec-puppet/blob/587617c7314e9ea26cb77eed66c08a756fd4f18a/lib/rspec-puppet/adapters.rb#L27-L32 The default for strict_varibles is defined in https://github.com/puppetlabs/rspec-puppet/blob/587617c7314e9ea26cb77eed66c08a756fd4f18a/lib/rspec-puppet.rb#L52 And I don't see one for strict so I assume it inherits the behavior from whatever puppet version is being used.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11689

Re: Enable strict mode by default

Ah these are defined in the pdk-templates, see https://github.com/puppetlabs/pdk-templates/commit/192de183ec39420a7f018b1b2c3e6426aa26114a (in 2020) and https://github.com/puppetlabs/pdk-templates/commit/7b2647cfb75c94564084330a7c1e54dc296796d1 (in 2018)

Add Comment

[Aria Li (Jira)]

Aria Li updated an issue

Puppet / PUP-11689

Enable strict mode by default

Change By: Aria Li Sprint: Phoenix 2023-01-18

Add Comment

[Aria Li (Jira)]

Aria Li assigned an issue to Aria Li

Puppet / PUP-11689 Enable strict mode by default

Change By: Aria Li Assignee: Aria Li

Add Comment

[Morgan Rhodes (Jira)]

Morgan Rhodes updated an issue

Puppet / PUP-11689 Enable strict mode by default

Change By: Morgan Rhodes Sprint: Phoenix 2023-01-18 , Phoenix 2023-02-01

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11689

Re: Enable strict mode by default I think changing the default for strict_variables is fine, but changing the default for strict to error affects several things like coercing strings/numbers, parsing module metadata, serializing pcore data, ... We should chat about that and likely split "strict" into a separate ticket.

Add Comment