| There seems to be enough inefficiency in instaparse such that large(ish) sets of OR clauses can eat up available memory. In a 2021.7.2 e2-custom-4-10240 GCP test instance with 1G allocated to puppetdb's heap, this query was enough to oom in ~3m:
reports { |
latest_report? = true and ( |
certname = "foo22" or |
certname = "foo21" or |
certname = "foo20" or |
certname = "foo19" or |
certname = "foo18" or |
certname = "foo17" or |
certname = "foo16" or |
certname = "foo15" or |
certname = "foo14" or |
certname = "foo13" or |
certname = "foo12" or |
certname = "foo11" or |
certname = "foo10" or |
certname = "foo9" or |
certname = "foo8" or |
certname = "foo7" or |
certname = "foo6" or |
certname = "foo5" or |
certname = "foo4" or |
certname = "foo3" or |
certname = "foo2" or |
certname = "foo1" |
) |
}
|
The effect is exponential. Calling it with 21 OR clauses, the query succeeded in 31s, with 20 in 7s, with 19 in 4s, and so on back down to <1 once you reach 16 clauses. We'll need to see if our grammar can be tweaked again to avoid this, similar to what Rob did in PDB-5260, or if we're looking at a parser re-write to fix this. |
