Jira (PUP-9509) Puppet 3 API functions should be loaded from thepluginsync location as part of the cache system loader

[Glenn Sarti (JIRA)]

Glenn Sarti updated an issue

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader Change By: Glenn Sarti Summary: {brief summary Puppet 3 API functions should be loaded from the pluginsync location as part of issue} the cache system loader Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Glenn Sarti (JIRA)]

Glenn Sarti updated an issue

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader Change By: Glenn Sarti

*Puppet Version:* 6.3.0 *Puppet Server Version:* N/A *OS Name/Version:* Windows 10 - 1803 Ruby 2.5 Describe your issue in as much detail as possible... Describe steps to reproduce... *Desired Behavior:* Puppet 3 API functions that are plugin sync'd should be loaded from the cache libdir *Actual Behavior:* Puppet 3 API functions are missing Previously in PUP-6964 (https://github.com/puppetlabs/puppet/pull/7019) the system loader was modified to to be able to load Puppet 3 API functions; of note - https://github.com/puppetlabs/puppet/pull/7019/files#diff-83a8daf215ff39828e0e3758c2e5a866R34 See how the system loader has loadables of { { [:func_4x, :func_3x, :datatype]} } However when the system cache loader was introduced in PUP-9035 (https://github.com/puppetlabs/puppet/commit/7404ee14745c78bd4a3173c79cac198809faea74 ) the loadables specified did not include the Puppet 3 API functions. of note - https://github.com/puppetlabs/puppet/pull/6963/files#diff-83a8daf215ff39828e0e3758c2e5a866R30 See how the cache loader has loadables of { { [:func_4x, :datatype]} } The comment at https://github.com/puppetlabs/puppet/pull/6963/files#diff-83a8daf215ff39828e0e3758c2e5a866R22 says they should be the same but is clear they are not. Also note that the acceptance tests do not test for this; https://github.com/puppetlabs/puppet/pull/6963/files#diff-d3791ca879b2c6c0586dd8974a7bec0eR25 That is just a Puppet 4 API location

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa updated an issue

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Jorie Tappa Team: Server

Add Comment

[Jorie Tappa (JIRA)]

Jorie Tappa updated an issue

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Jorie Tappa Sub-team: Language

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-9509

Re: Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader Earlier it was questionable if 3.x functions should be loaded at all as there are many 3.x functions that has unsafe implementations (adding methods to Scope, or every Object). As we now have safety checks when loading 3.x functions this is less of a concern. Adding 3.x loading as Glenn Sarti shows should be easy and then "just work".

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-9509

Re: Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Merged to master in 49926022c9 and 8dd3bbe88e. Passed CI in a0e7c84236

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper commented on PUP-9509

Re: Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Glenn Sarti Can you add release notes?

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9509

Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Josh Cooper Team: Server Coremunity

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Josh Cooper Fix Version/s: PUP 6.11.0

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper assigned an issue to Glenn Sarti

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Josh Cooper Assignee: Glenn Sarti

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti commented on PUP-9509

Re: Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader Josh Cooper Added.

Add Comment

[Glenn Sarti (JIRA)]

Glenn Sarti updated an issue

Puppet / PUP-9509

Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Glenn Sarti Release Notes Summary: Legacy Ruby Functions, also known as Version 3 Functions, will now be available from the cached lib directory.  Previously only Version functions were available.  Note that functions that exist in both Version 3 and Version 4, will still use the Version 4 implementation. Release Notes: Bug Fix

Add Comment

[Heston Hoffman (JIRA)]

Heston Hoffman updated an issue

Puppet / PUP-9509 Puppet 3 API functions should be loaded from the pluginsync location as part of the cache system loader

Change By: Heston Hoffman Labels: resolved-issue-added

Add Comment