Jira (PUP-6591) Recurse option on nested directories silently omits files

0 views
Skip to first unread message

Adam Bottchen (JIRA)

unread,
Aug 8, 2016, 3:14:42 PM8/8/16
to puppe...@googlegroups.com
Adam Bottchen created an issue
 
Puppet / Bug PUP-6591
Recurse option on nested directories silently omits files
Issue Type: Bug Bug
Affects Versions: PUP 4.5.2
Assignee: Kylo Ginsberg
Components: Client
Created: 2016/08/08 12:08 PM
Priority: Normal Normal
Reporter: Adam Bottchen

If you create a file resource with recurse => remote for a subdirectory of a directory that is also managed by a file resource with recurse => remote, the top level directory will be silently left unmanaged.

To recreate:

# cat recurse/manifests/init.pp
class recurse {
  file { "/tmp/level1":
    ensure  => directory,
    source  => 'puppet:///modules/recurse/level1',
    recurse => 'remote',
  }
 
  file { "/tmp/level1/level2":
    ensure  => directory,
    source  => 'puppet:///modules/recurse/optional',
    recurse => 'remote',
  }
}
# tree recurse/files/
recurse/files/
├── level1
│   └── level2
│       ├── file1
│       └── file2
└── optional
    ├── file3
    └── file4
 
3 directories, 4 files

The expected behavior is that the first file resource will create /tmp/level1/level2 with the file1 and file2 and the second resource will tack on file3 and file4. The actual results are:

# puppet apply -e "include recurse"
Notice: Compiled catalog for pe-201620-master.puppetdebug.vlan in environment production in 0.05 seconds
Notice: /Stage[main]/Recurse/File[/tmp/level1]/ensure: created
Notice: /Stage[main]/Recurse/File[/tmp/level1/level2]/ensure: created
Notice: /Stage[main]/Recurse/File[/tmp/level1/level2/file3]/ensure: defined content as '{md5}d41d8cd98f00b204e9800998ecf8427e'
Notice: /Stage[main]/Recurse/File[/tmp/level1/level2/file4]/ensure: defined content as '{md5}d41d8cd98f00b204e9800998ecf8427e'
Notice: Applied catalog in 0.30 seconds

The files from the second file resource (file3 and file4) are pulled in, and the ones in the original resource are silently left out. This manifest should either handle the nested resources and pull all files or generate an error regarding nested file resources.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Atlassian logo

Adam Bottchen (JIRA)

unread,
Aug 8, 2016, 3:17:26 PM8/8/16
to puppe...@googlegroups.com
Adam Bottchen updated an issue
Change By: Adam Bottchen
CS Priority: Needs Priority

Bill Niestempski (JIRA)

unread,
Aug 9, 2016, 11:49:03 AM8/9/16
to puppe...@googlegroups.com
Bill Niestempski updated an issue

CS Priority: Major
CS Frequency: 2
CS Severity: 4
CS Business Value: 5

Change By: Bill Niestempski
CS Priority: Needs Priority Reviewed

David Kramer (JIRA)

unread,
Aug 17, 2016, 12:50:03 PM8/17/16
to puppe...@googlegroups.com
David Kramer commented on Bug PUP-6591
 
Re: Recurse option on nested directories silently omits files

In the short term we should definitely improve the logging for when this situation occurs. There might be an opportunity to improve this more in a future X release.

Kenn Hussey (JIRA)

unread,
Sep 29, 2016, 2:59:12 PM9/29/16
to puppe...@googlegroups.com
Kenn Hussey updated an issue
 
Change By: Kenn Hussey
Sprint: Client Triage
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Joe Pinsonault (JIRA)

unread,
May 16, 2017, 5:13:05 PM5/16/17
to puppe...@googlegroups.com

Joe Pinsonault (JIRA)

unread,
May 16, 2017, 5:13:07 PM5/16/17
to puppe...@googlegroups.com

Adam Bottchen (JIRA)

unread,
May 25, 2017, 6:56:03 PM5/25/17
to puppe...@googlegroups.com
Adam Bottchen updated an issue
Change By: Adam Bottchen
Method Found: Customer Feedback

Adam Bottchen (JIRA)

unread,
Jan 23, 2019, 5:00:08 PM1/23/19
to puppe...@googlegroups.com
Adam Bottchen updated an issue
Change By: Adam Bottchen
CS Priority: Reviewed Major
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 11, 2020, 2:28:04 AM6/11/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP-7548
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages