Jira (PUP-8480) Puppet::Util::Execution.execute should always default failonfail to true, even if other options are set

Melissa Stone (JIRA)

unread,

Feb 21, 2018, 12:06:03 PM2/21/18

to puppe...@googlegroups.com

Melissa Stone created an issue

Puppet /

PUP-8480

Puppet::Util::Execution.execute should always default failonfail to true, even if other options are set

Issue Type:	Task
Assignee:	Unassigned
Created:	2018/02/21 9:05 AM
Fix Versions:	PUP 6.0.0
Priority:	Normal
Reporter:	Melissa Stone

Currently, failonfail defaults to true UNLESS any other options are passed in to the execute command (even if they do not modify failonfail). In this case, failonfail will switch to false. This is unexpected and should not happen. Failonfail should always be true unless explicitely set to false.

Add Comment

This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)

Josh Cooper (JIRA)

unread,

Aug 3, 2018, 1:38:03 PM8/3/18

to puppe...@googlegroups.com

Josh Cooper commented on

PUP-8480

Re: Puppet::Util::Execution.execute should always default failonfail to true, even if other options are set

For this ticket, I think we want to create a new API with sane semantics. There's no telling how many modules/providers we'd break changing the current API.