Jira (PUP-11119) Remove "extra" cli option

21 views
Skip to first unread message

Josh Cooper (Jira)

unread,
Jun 16, 2021, 11:37:03 AM6/16/21
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-11119
Remove "extra" cli option
Issue Type: Task Task
Assignee: Unassigned
Created: 2021/06/16 8:36 AM
Priority: Normal Normal
Reporter: Josh Cooper

puppet face applications accept an extra argument, which is forwarded as an options hash to the indirector request, but the argument is unusable. In PUP-8700 the argument was hidden. In Pupppet 8, we should remove it.
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 17, 2021, 1:16:02 PM6/17/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Night's Watch

Josh Cooper (Jira)

unread,
Aug 30, 2021, 7:11:03 PM8/30/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 8.0.0

Josh Cooper (Jira)

unread,
Sep 2, 2022, 3:21:01 PM9/2/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PA-4664
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Josh Cooper (Jira)

unread,
Sep 2, 2022, 3:21:02 PM9/2/22
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Night's Watch Phoenix

Josh Cooper (Jira)

unread,
Mar 9, 2023, 12:50:04 PM3/9/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Phoenix 2023-03-29

Josh Cooper (Jira)

unread,
Mar 9, 2023, 1:25:04 PM3/9/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
puppet face applications accept an extra argument, which is forwarded as an options hash to the indirector request, but the argument is unusable. In PUP-8700 the argument was hidden. In Pupppet 8, we should remove it.


Remove this hack https://github.com/puppetlabs/puppet/commit/aa3520d059a7a594df78a329339487f881626963
Find where "extra" is documented for face application and remove it
Remove cases where "options[:extra]" is passed through the application to the indirector request.
When running {{puppet facts --help}} there should not be an "--extra" option in documentation.

Josh Cooper (Jira)

unread,
Mar 9, 2023, 1:26:02 PM3/9/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Story Points: 2

Josh Cooper (Jira)

unread,
Mar 15, 2023, 1:11:02 AM3/15/23
to puppe...@googlegroups.com
Josh Cooper updated an issue
puppet face applications accept an extra argument, which is forwarded as an options hash to the indirector request, but the argument is unusable. The "--extra" CLI option was added in ae360034c07f9b16467f5ae245ac6d037789ee13 but never worked because you couldn't pass a Hash on the command line. In PUP-8700 the argument was hidden. In And in Pupppet 8, we should remove it . :

Remove this hack * remove the "--extra" command line argument from: https://github.com/puppetlabs/puppet/ commit blob / aa3520d059a7a594df78a329339487f881626963
Find where "extra" is documented for 180c62d28e7ff1d5c4a72b36308cb4a3f264a487/lib/puppet/indirector/ face application and remove it .rb#L57-L65
Remove * In cases where " we were passing options[:extra] , such as https://github.com/puppetlabs/puppet/blob/180c62d28e7ff1d5c4a72b36308cb4a3f264a487/lib/puppet/indirector/face.rb#L84, instead pass an empty " {}" which is equivalent to what we were doing before.
* We can probably remove this hack, since "extra" should never be passed through the application to the indirector request : https://github . com/puppetlabs/puppet/commit/aa3520d059a7a594df78a329339487f881626963

Acceptance Criteria:

When running {{puppet facts --help}} there should not be an "--extra" option in documentation.

Michael Hashizume (Jira)

unread,
Mar 17, 2023, 1:09:03 PM3/17/23
to puppe...@googlegroups.com
Michael Hashizume assigned an issue to Michael Hashizume
Change By: Michael Hashizume
Assignee: Michael Hashizume

Michael Hashizume (Jira)

unread,
Apr 12, 2023, 4:37:02 PM4/12/23
to puppe...@googlegroups.com
Michael Hashizume updated an issue
Change By: Michael Hashizume
Release Notes: Deprecation
Release Notes Summary: The "extra" CLI option, which has been hidden from users since 2021, has been entirely removed.

Parker Leach (Jira)

unread,
Apr 19, 2023, 2:56:01 PM4/19/23
to puppe...@googlegroups.com
Parker Leach updated an issue
Change By: Parker Leach
Labels: docs_reviewed
Reply all
Reply to author
Forward
0 new messages