Jira (PUP-7931) Support HTTPS Compression on report upload

10 views
Skip to first unread message

Adrian (JIRA)

unread,
Sep 11, 2017, 10:09:03 AM9/11/17
to puppe...@googlegroups.com
Adrian created an issue
 
Puppet / New Feature PUP-7931
Support HTTPS Compression on report upload
Issue Type: New Feature New Feature
Affects Versions: PUP 5.1.0
Assignee: Adrian
Created: 2017/09/11 7:08 AM
Environment:

All OS, all agents etc.
Priority: Normal Normal
Reporter: Adrian

On very low bandwidth connections (cellular and such) the reports can be very costly.

I have developed a patch which I will be submitting shortly to enable optional HTTPS compression for the report uploads.

While this is not supported directly by puppet-server, having a proxy in front allows for the compression and gives more options for low bandwidth connections
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Adrien Thebo (JIRA)

unread,
Sep 11, 2017, 5:07:03 PM9/11/17
to puppe...@googlegroups.com
Adrien Thebo updated an issue
Change By: Adrien Thebo
Team: Platform Core

Josh Cooper (JIRA)

unread,
Nov 16, 2017, 2:53:03 PM11/16/17
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-7931
 
Re: Support HTTPS Compression on report upload

. The trick is that the agent speaks first, so if server doesn't support whatever compression was used (gzip, inflate, etc), then the agent will have to send the report twice. We'd like to use HTTP expect/continue so that the master can reply with HTTP 100 Continue or 415 Unsupported Media Type between the time the agent sends the HTTP headers and the report body.
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Josh Cooper (JIRA)

unread,
Dec 1, 2017, 5:20:02 PM12/1/17
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Unassigned
 
Change By: Josh Cooper
Assignee: Adrian

Craig Gomes (JIRA)

unread,
Feb 2, 2018, 1:38:03 PM2/2/18
to puppe...@googlegroups.com
Craig Gomes updated an issue
Change By: Craig Gomes
Sub-team: Coremunity

Jacob Helwig (JIRA)

unread,
Feb 8, 2018, 6:19:02 PM2/8/18
to puppe...@googlegroups.com
Jacob Helwig commented on New Feature PUP-7931
 
Re: Support HTTPS Compression on report upload

We should limit the compression used to gzip for simplicity.
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

Jacob Helwig (JIRA)

unread,
Feb 8, 2018, 6:22:02 PM2/8/18
to puppe...@googlegroups.com
Jacob Helwig updated an issue
 
Change By: Jacob Helwig
Fix Version/s: PUP 5.y

Jacob Helwig (JIRA)

unread,
Feb 8, 2018, 6:40:04 PM2/8/18
to puppe...@googlegroups.com
Jacob Helwig updated an issue
Change By: Jacob Helwig
Sprint: Platform Core Hopper

Jorie Tappa (JIRA)

unread,
Feb 26, 2018, 12:33:03 PM2/26/18
to puppe...@googlegroups.com
Jorie Tappa assigned an issue to Jorie Tappa
Change By: Jorie Tappa
Assignee: Jorie Tappa

Jorie Tappa (JIRA)

unread,
Feb 26, 2018, 12:34:03 PM2/26/18
to puppe...@googlegroups.com
Jorie Tappa updated an issue
Change By: Jorie Tappa
Sprint: Platform Core Hopper KANBAN

Kenn Hussey (JIRA)

unread,
Feb 28, 2018, 12:29:03 AM2/28/18
to puppe...@googlegroups.com
Kenn Hussey updated an issue
Change By: Kenn Hussey
Fix Version/s: PUP 5.y
Fix Version/s: PUP 5.5.0

Jorie Tappa (JIRA)

unread,
Mar 14, 2018, 12:40:04 PM3/14/18
to puppe...@googlegroups.com
Jorie Tappa updated an issue
Change By: Jorie Tappa
Fix Version/s: PUP 5.5.0
Fix Version/s: PUP 5.5.z
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Josh Cooper (JIRA)

unread,
Mar 26, 2018, 5:17:03 PM3/26/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 5.5.1
Fix Version/s: PUP 6.0.0

Craig Gomes (JIRA)

unread,
Apr 2, 2018, 5:04:06 PM4/2/18
to puppe...@googlegroups.com
Craig Gomes updated an issue
Change By: Craig Gomes
Sprint: Platform Core KANBAN Hopper

Craig Gomes (JIRA)

unread,
Apr 2, 2018, 5:04:08 PM4/2/18
to puppe...@googlegroups.com
Craig Gomes assigned an issue to Unassigned
Change By: Craig Gomes
Assignee: Jorie Tappa

Josh Cooper (JIRA)

unread,
Jul 10, 2018, 2:12:04 PM7/10/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core Hopper Grooming

Josh Cooper (JIRA)

unread,
Jul 10, 2018, 2:12:04 PM7/10/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core Grooming

Josh Cooper (JIRA)

unread,
Jul 16, 2018, 5:13:06 PM7/16/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 6.0.0

Rob Braden (JIRA)

unread,
Feb 3, 2020, 1:04:04 PM2/3/20
to puppe...@googlegroups.com
Rob Braden updated an issue
Change By: Rob Braden
Sprint: Coremunity Hopper

Josh Cooper (JIRA)

unread,
Feb 5, 2020, 12:25:04 PM2/5/20
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-7931
 
Re: Support HTTPS Compression on report upload

This may not be implementable yet due to https://tickets.puppetlabs.com/browse/SERVER-1828?focusedCommentId=587904&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-587904. For now see what happens if Puppet::HTTP::Service::Report#put_report compresses the request body and sends the Content-Encoding: gzip header. Does puppetserver reject it?

Josh Cooper (JIRA)

unread,
Feb 24, 2020, 1:26:03 PM2/24/20
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-7931

In my testing puppetserver rejects compressed request bodies. So more work is required in puppetserver to support that, and for the agent to take advantage of it. I've created a separate epic, and move the compression related tickets.

Josh Cooper (Jira)

unread,
Mar 2, 2020, 2:23:04 PM3/2/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Sprint: Coremunity Hopper
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Tom Parker (Jira)

unread,
Apr 26, 2021, 6:04:02 PM4/26/21
to puppe...@googlegroups.com
Tom Parker commented on New Feature PUP-7931
 
Re: Support HTTPS Compression on report upload

Hello,  has there been any progress on this ticket? 

Would it be possible to also include the same for puppet facts upload?  It would also benefit from compression.

Could it not just be a puppet.conf setting for compress_uploads = true (–compress_uploads) and let the administrator enable it once they are sure their server side can handle decompressing the payloads?
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 11, 2021, 4:24:02 PM6/11/21
to puppe...@googlegroups.com
Josh Cooper commented on New Feature PUP-7931

No progress yet. Compressing facts makes sense, but will also require server side changes, since the facts are submitted in the body of the catalog POST.
Reply all
Reply to author
Forward
0 new messages