Jira (PUP-8014) Create an environment_ttl setting to clear short-lived puppet environments from memory

[Garrett Guillotte (JIRA)]

Garrett Guillotte updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory Change By: Garrett Guillotte Summary: Create an  evironment_ttl  environment_ttl  setting to clear short-lived puppet environments from memory Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Team: Platform Core

Add Comment

This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)

[Nick Walker (JIRA)]

Nick Walker updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Nick Walker Priority: Normal Major

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Team: Coremunity Froyo

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Melissa Stone (Jira)]

Melissa Stone commented on PUP-8014

Re: Create an environment_ttl setting to clear short-lived puppet environments from memory Nick Walker  it sounds like you want per-environment control? Is what you're proposing in this ticket still a direction you want to go in?

Add Comment

[Nick Walker (Jira)]

Nick Walker commented on PUP-8014

Re: Create an environment_ttl setting to clear short-lived puppet environments from memory

Melissa Stone this should be a global setting IMO ( stated in the last sentence of "the solution").  Everything in the ticket still looks correct in today's world.

Add Comment

[Molly Waggett (Jira)]

Molly Waggett commented on PUP-8014

Re: Create an environment_ttl setting to clear short-lived puppet environments from memory

off the top of my head, I think the only difference with versioned-deploys would be that we'd presumably want to clean up all versions of an environment. But even then, any leftover dirs should get cleaned up by the versioned-dirs-ttl.

Add Comment

[Nick Walker (Jira)]

Nick Walker updated an issue

Puppet / PUP-8014

Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Nick Walker Labels: ondeck1

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Epic Link: PUP-7563

Add Comment

[Maggie Dreyer (Jira)]

Maggie Dreyer updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Maggie Dreyer Epic Link: PUP- 7563 10593

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8014

Re: Create an environment_ttl setting to clear short-lived puppet environments from memory I think the easiest approach would be to define an environment_ttl setting in puppet and a new type of cache entry (https://github.com/puppetlabs/puppet/blob/ec8bcbd5287ccdd67ff06618bb2d0d568a3f2328/lib/puppet/environments.rb#L437-L447) that keeps track of when the environment was last accessed. In order to eagerly evict environments, we could use Concurrent::TimerTask to evict expired environments. We'd also need to remove the environment_timeout setting at the same time. I think it would be difficult to implement this in puppetserver, because we still need to support the "never cache" vs "cache if unused after" use cases, where "never cache" would still be the default.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-8014

Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Team: Froyo Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Sprint: Platform Core KANBAN

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Fix Version/s: PUP 6.19.0 Fix Version/s: PUP 7.0.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8014

Re: Create an environment_ttl setting to clear short-lived puppet environments from memory Merged to master in https://github.com/puppetlabs/puppet/commit/ea9fbe7f2dbcfa592d190f054f976d486ef8b2fa

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-8014

Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Josh Cooper Release Notes: New Feature Release Notes Summary: Adds a new setting `environment_ttl` which is controls the environment cache like the `environment_timeout` setting. However, `environment_ttl` will evict environments from the cache if they haven't been recently used to compile a catalog within the last `environment_ttl` seconds. This is different from the `environment_timeout` setting which will evict environments at a specific time, regardless of whether the environment has been recently used or not. For the `environment_ttl` setting, a value of `0` will disable caching. This setting can also be set to`unlimited`, which will cache environments until the server is restarted or told to refresh the cache. All other values will result in Puppet server evicting environments that have not been accessed within that ttl. You should change this setting once your Puppet deployment is doing non-trivial work. We chose the default value of `0` because it lets new users update their code without any extra steps, but it lowers the performance of your Puppet server. We recommend setting this to a number that will keep your most actively used environments cached, but allow testing environments to fall out of the cache and reduce memory usage. A value of 3 minutes (3m) is a reasonable value. Once you set `environment_ttl` to a non-zero value, you need to tell Puppet server to read new code from disk using the `environment-cache` API endpoint after you deploy new code. See the docs for the Puppet Server [administrative API](https://puppet.com/docs/puppetserver/latest/admin-api/v1/environment-cache.html). If the `environment_ttl` setting is explicitly configured in `puppet.conf` then it will override whatever global `environment_timeout` is set in `puppet.conf` and any per-environment `environment_timeout` set in `$codedir/environments/<environment>/environment.conf`.

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-8014 Create an environment_ttl setting to clear short-lived puppet environments from memory

Change By: Claire Cadman Labels: doc_reviewed ondeck1

Add Comment

[Claire Cadman (Jira)]

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8014

Re: Create an environment_ttl setting to clear short-lived puppet environments from memory Passed CI in e813e2078e

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-8014

Re: Create an environment_ttl setting to clear short-lived puppet environments from memory

Reopening this issue as we don't want to ship with environment_ttl. PR incoming.

Add Comment