Jira (FACT-1050) can't find facts specified on CLI when defined in ini file containing spaces around =

[Eric Thompson (JIRA)]

Eric Thompson created an issue

Facter / FACT-1050 can't find facts specified on CLI when defined in ini file containing spaces around = Issue Type: Bug Assignee: Unassigned Created: 2015/06/17 3:14 PM Priority: Normal Reporter: Eric Thompson i've seen this in both native and ruby facter. if you define an external non-executable fact containing a space in an ini txt file, and there are spaces around the '=' the fact key appears to have a trailing space in it. In facter2, IIRC you can get the fact using 'foo ', but this doesn't appear to work in native facter. In either case you can find the fact in the entire output with grep. ./external/foo.txt foo = bar bar=foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ foo   [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'foo '   [root@lks2ze2y006q9pk ~]# facter --external-dir external/ | grep foo bar => foo foo => bar [root@lks2ze2y006q9pk ~]# facter --external-dir external/ bar foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'bar' foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'bar ' foo Add Comment

This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)

[Eric Thompson (JIRA)]

Eric Thompson updated an issue

Facter / FACT-1050 can't find facts specified on CLI when defined in ini file containing spaces around =

Change By: Eric Thompson

i've seen this in both native and ruby facter. if you define an external non-executable fact containing a space in an ini txt file, and there are spaces around the '=' the fact key appears to have a trailing space in it. In facter2, IIRC you can get the fact using 'foo ', but this doesn't appear to work in native facter.  In either case you can find the fact in the entire output with grep. ./external/foo.txt

{code} foo = bar bar=foo {code} {code}

[root@lks2ze2y006q9pk ~]# facter --external-dir external/ foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'foo ' [root@lks2ze2y006q9pk ~]# facter --external-dir external/ | grep foo bar => foo foo  =>  bar [root@lks2ze2y006q9pk ~]# facter --external-dir external/ bar foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'bar' foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'bar ' foo

{code} it appears native facter is stripping the spaces off the key on the CLI, but not in the inifile it appears facter 2 is doing neither.

Add Comment

[Eric Thompson (JIRA)]

Eric Thompson updated an issue

Facter / FACT-1050 can't find facts specified on CLI when defined in ini file containing spaces around = Change By: Eric Thompson

i've seen this in both native and ruby facter. if you define an external non-executable fact containing a space in an ini txt file, and there are spaces around the '=' the fact key appears to have a trailing space in it. In facter2, IIRC you can get the fact using 'foo ', but this doesn't appear to work in native facter.  In either case you can find the fact in the entire output with grep. ./external/foo.txt {code} foo = bar bar=foo {code}

native facter:

{code} [root@lks2ze2y006q9pk ~]# facter --external-dir external/ foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'foo ' [root@lks2ze2y006q9pk ~]# facter --external-dir external/ | grep foo bar => foo foo  =>  bar [root@lks2ze2y006q9pk ~]# facter --external-dir external/ bar foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'bar' foo [root@lks2ze2y006q9pk ~]# facter --external-dir external/ 'bar ' foo {code} it appears native facter is stripping the spaces off the key on the CLI, but not in the inifile it appears facter 2 is doing neither.

Add Comment

[Kylo Ginsberg (JIRA)]

Kylo Ginsberg commented on FACT-1050

Re: can't find facts specified on CLI when defined in ini file containing spaces around = Fwiw, the CLI behavior in facter 3 is not specific to external facts.

Add Comment

This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Facter / FACT-1050

can't find facts specified on CLI when defined in ini file containing spaces around =

Change By: Josh Cooper Labels: puppethack

Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

[Josh Cooper (JIRA)]

Josh Cooper commented on FACT-1050

Re: can't find facts specified on CLI when defined in ini file containing spaces around = This would be a change in https://github.com/puppetlabs/facter/blob/3.1.3/lib/src/facts/external/text_resolver.cc#L24-L33

Add Comment

[Sean McDonald (JIRA)]

Sean McDonald updated an issue

Facter / FACT-1050

can't find facts specified on CLI when defined in ini file containing spaces around =

Change By: Sean McDonald Team: Agent

Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Maggie Dreyer (JIRA)]

Maggie Dreyer updated an issue

Facter / FACT-1050 can't find facts specified on CLI when defined in ini file containing spaces around =

Change By: Maggie Dreyer Labels: puppethack  triaged

Add Comment

[Moses Mendoza (JIRA)]

Moses Mendoza updated an issue

Facter / FACT-1050 can't find facts specified on CLI when defined in ini file containing spaces around =

Change By: Moses Mendoza Labels: puppethack  triaged

Add Comment

[Branan Riley (JIRA)]

Branan Riley updated an issue

Facter / FACT-1050 can't find facts specified on CLI when defined in ini file containing spaces around =

Change By: Branan Riley Labels: Easy puppethack triaged

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Facter / FACT-1050 can't find facts specified on CLI when defined in ini file containing spaces around =

Change By: Josh Cooper Component/s: Facter 4 Component/s: Facter 3

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Josh Cooper (Jira)]

Josh Cooper commented on FACT-1050

Re: can't find facts specified on CLI when defined in ini file containing spaces around = Facter 3 and 4 are consistent: # cat external/foo.txt foo = bar # /opt/puppetlabs/puppet/bin/facter --version 3.14.23 (commit 46e6e6ffdecff72b75853af43a11acdf2d36752c) # # /opt/puppetlabs/puppet/bin/facter --external-dir external/ foo   # /opt/puppetlabs/puppet/bin/facter --external-dir external/ | grep foo foo => bar # /opt/puppetlabs/puppet/bin/facter-ng --version 4.2.8 # /opt/puppetlabs/puppet/bin/facter-ng --external-dir external/ foo   # /opt/puppetlabs/puppet/bin/facter-ng --external-dir external/ | grep foo foo => bar

Add Comment