Jira (PUP-8235) When running with --tasks Scope.to_s should shorten paths to modules

2 views
Skip to first unread message

Henrik Lindberg (JIRA)

unread,
Dec 9, 2017, 5:21:02 AM12/9/17
to puppe...@googlegroups.com
Henrik Lindberg created an issue
 
Puppet / Improvement PUP-8235
When running with --tasks Scope.to_s should shorten paths to modules
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2017/12/09 2:20 AM
Priority: Normal Normal
Reporter: Henrik Lindberg

When calling any of the logging functions they output information about the scope the call to log came from. When compiling a catalog the scope information is the name of the resource (class, define), but when running tasks there is no such resource - scope will instead use the path to the file where the logging call takes place.

Those paths can be quite long and clutters the output (makes it hard to read). The logic already shortens paths that are "in the environment", but should also do that for paths into a module.

See TODO comment in Scope.to_s

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Dec 14, 2017, 11:53:03 AM12/14/17
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Dec 14, 2017, 11:56:02 AM12/14/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Release Notes Summary: When puppet is used for scripting with Bolt (tasks and plans), logging output will now use shortened paths inside of the {{Scope()}} identifier found in every logged message. Instead of showing the full path, a path to a module on the module path is shown as {{<module>/name/<rest>.pp}} or the same using {{<env>}} for a path to a .pp file in an environment.
Sprint: Platform Core KANBAN
Release Notes: New Feature

Henrik Lindberg (JIRA)

unread,
Dec 14, 2017, 11:56:03 AM12/14/17
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Dec 14, 2017, 11:58:02 AM12/14/17
to puppe...@googlegroups.com
Henrik Lindberg commented on Improvement PUP-8235
 
Re: When running with --tasks Scope.to_s should shorten paths to modules

Ping Alex Dreyer - kind of a small detail, but pinging since you may want to release-note for Bolt.

Alex Dreyer (JIRA)

unread,
Dec 14, 2017, 12:42:03 PM12/14/17
to puppe...@googlegroups.com

Alex Dreyer (JIRA)

unread,
Dec 14, 2017, 12:43:03 PM12/14/17
to puppe...@googlegroups.com
Alex Dreyer commented on Improvement PUP-8235
 
Re: When running with --tasks Scope.to_s should shorten paths to modules

unless it's bothering someone I think we'll just wait for 0.12.0 next week

Thomas Hallgren (JIRA)

unread,
Dec 15, 2017, 5:26:02 AM12/15/17
to puppe...@googlegroups.com

Thomas Hallgren (JIRA)

unread,
Dec 15, 2017, 5:28:02 AM12/15/17
to puppe...@googlegroups.com
Thomas Hallgren assigned an issue to Unassigned
 
Change By: Thomas Hallgren
Assignee: Thomas Hallgren

Josh Cooper (JIRA)

unread,
Jan 9, 2018, 11:46:04 AM1/9/18
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Feb 1, 2018, 4:32:02 AM2/1/18
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Release Notes Summary: When puppet is used for scripting with Bolt (tasks and plans), logging output will now use shortened paths inside of the {{Scope()}} identifier found in every logged message. Instead of showing the full path, a path to a module on the module path is shown as {{<module>/name/<rest -of-path >.pp}} or the same using {{<env>}} for a path to a .pp file in an environment.

Henrik Lindberg (JIRA)

unread,
Feb 1, 2018, 4:32:03 AM2/1/18
to puppe...@googlegroups.com

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:50:05 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages