Jira (FACT-2493) Test community supported modules with Facter 4

[Mihai Buzgau (Jira)]

Mihai Buzgau created an issue

Facter / FACT-2493 Test community supported modules with Facter 4 Issue Type: Task Assignee: Unassigned Components: Facter 4 Created: 2020/03/25 3:38 AM Priority: Normal Reporter: Mihai Buzgau Test the following modules with Facter 4: - https://github.com/simp/pupmod-simp-simp - https://github.com/voxpupuli/puppet-collectd - https://github.com/voxpupuli/puppet-zabbix - https://github.com/voxpupuli/puppet-prometheus Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Mihai Buzgau (Jira)]

Mihai Buzgau commented on FACT-2493

Re: Test community supported modules with Facter 4 https://github.com/simp/pupmod-simp-simp has a dependency simp-rspec-puppet-facts: https://github.com/simp/pupmod-simp-simp/blob/master/Gemfile#L19 The simp-rspec-puppet-facts __ gem has a runtime dependency to Facter that locks the Facter gem to >= 2.5.0, < 3.0: https://github.com/simp/rubygem-simp-rspec-puppet-facts/blob/master/simp-rspec-puppet-facts.gemspec#L24 All the modules that use this gem will not get the Facter 4 bump.

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau assigned an issue to Mihai Buzgau

Facter / FACT-2493

Test community supported modules with Facter 4

Change By: Mihai Buzgau Assignee: Mihai Buzgau

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau commented on FACT-2493

Re: Test community supported modules with Facter 4 https://github.com/voxpupuli/puppet-collectd The tests for test_with_coveralls pass using Facter 4: ** Invoke parallel_spec_standalone (first_time) ** Execute parallel_spec_standalone 8 processes for 113 specs, ~ 14 specs per process No facts were found in the FacterDB for Facter v3.14.0, using v3.9.0 instead ...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Finished in 1 minute 26.83 seconds (files took 56.52 seconds to load) 230 examples, 0 failures.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Finished in 2 minutes 0.9 seconds (files took 54.22 seconds to load) 282 examples, 0 failures...................................................................................Finished in 1 minute 54.22 seconds (files took 1 minute 2.54 seconds to load) 230 examples, 0 failures.............................................................................................................................................................................................................................................................Finished in 2 minutes 6.1 seconds (files took 56.48 seconds to load) 225 examples, 0 failures.............................................................................................................................................................................................................................................................................................................Finished in 1 minute 43.19 seconds (files took 1 minute 26.18 seconds to load) 208 examples, 0 failures.....................................................................................................................Finished in 1 minute 46.59 seconds (files took 1 minute 26.48 seconds to load) 1335 examples, 0 failures......................................................................................................................................................................................................................................................................................................................................Finished in 2 minutes 45.4 seconds (files took 1 minute 27.83 seconds to load) 676 examples, 0 failures.Total resources: 583 Touched resources: 258 Resource coverage: 44.25% mihai:puppet-collectd mihai.buzgau$ bundle exec facter --version 4.0.12 The tests from this module that use beaker will not get Facter 4 as we are still providing Puppet Agent AIO with Facter 3 Here you've got a travis job that was executed with Facter 4:  https://travis-ci.org/github/voxpupuli/puppet-collectd/jobs/666691008#L1033

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau commented on FACT-2493

Re: Test community supported modules with Facter 4

https://github.com/voxpupuli/puppet-zabbix test_with_coveralls are passing with Facter 4: 8 processes for 18 specs, ~ 2 specs per process ...........................................................................................................................................Finished in 6.91 seconds (files took 3.85 seconds to load) 139 examples, 0 failuresCoverage report generated for (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 71 / 548 LOC (12.96%) covered.COVERAGE: 12.96% -- 71/548 lines in 16 files+----------+---------------------------------------------------+-------+--------+---------------------------------------------------------------------------------------------------------------------------------------................ 3 file(s) with 100% coverage not shown.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Finished in 52.49 seconds (files took 2 minutes 23.7 seconds to load) 235 examples, 0 failures.Coverage report generated for (2/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 71 / 548 LOC (12.96%) covered.COVERAGE: 12.96% -- 71/548 lines in 16 files.+----------+---------------------------------------------------+-------+--------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+ .................... +----------+---------------------------------------------------+-------+--------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 3 file(s) with 100% coverage not shown ............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Finished in 2 minutes 17.1 seconds (files took 2 minutes 24.5 seconds to load) 719 examples, 0 failures..Coverage report generated for (2/8), (3/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 71 / 548 LOC (12.96%) covered.COVERAGE: 12.96% -- 71/548 lines in 16 files..+----------+---------------------------------------------------+-------+--------+---------------------------------------------------------------------------------------------------------------------............ 3 file(s) with 100% coverage not shown ....................................................................................................................................................................................................................................................................Finished in 24.59 seconds (files took 4 minutes 26.4 seconds to load) 209 examples, 0 failures...Coverage report generated for (2/8), (3/8), (4/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 71 / 548 LOC (12.96%) covered.COVERAGE: 12.96% -- 71/548 lines in 16 files.+----------+---------------------------------------------------+-------+--------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+ ....................   3 file(s) with 100% coverage not shown .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Finished in 2 minutes 0.1 seconds (files took 4 minutes 27.9 seconds to load) 726 examples, 0 failuresCoverage report generated for (2/8), (3/8), (4/8), (5/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 87 / 533 LOC (16.32%) covered.COVERAGE: 16.32% -- 87/533 lines in 16 files+----------+---------------------------------------------------+-------+--------+-------------------------------------------------------------------------------------------------------........................................... 4 file(s) with 100% coverage not shown .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Finished in 3 minutes 54.1 seconds (files took 4 minutes 27.7 seconds to load) 582 examples, 0 failuresCoverage report generated for (2/8), (3/8), (4/8), (5/8), (7/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 161 / 416 LOC (38.7%) covered.COVERAGE: 38.70% -- 161/416 lines in 16 files+----------+---------------------------------------------------+-------+--------+---------------------------------------------------------------------------------------------------................................................. 5 file(s) with 100% coverage not shown .........................................................................................................................................................Finished in 3 minutes 32.5 seconds (files took 5 minutes 58 seconds to load) 574 examples, 0 failuresCoverage report generated for (2/8), (3/8), (4/8), (5/8), (6/8), (7/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 161 / 416 LOC (38.7%) covered.COVERAGE: 38.70% -- 161/416 lines in 16 files+----------+---------------------------------------------------+-------+--------+--------------------------------------------------------------------------------------------............................ 5 file(s) with 100% coverage not shown .Total resources: 82 Touched resources: 74 Resource coverage: 90.24%Untouched resources: Apache::Vhost[localhost] Apt::Key[zabbix-A1848F5] Apt::Key[zabbix-FBABD5F] Postgresql::Server::Db[zabbix_proxy] Selinux::Module[zabbix-agent] Selinux::Module[zabbix-server-ipc] Selinux::Module[zabbix-server] Zabbix::Resources::Userparameters[rspec_Zabbix_Proxy] Finished in 7 minutes 6 seconds (files took 2 minutes 25.2 seconds to load) 1330 examples, 0 failuresCoverage report generated for (1/8), (2/8), (3/8), (4/8), (5/8), (6/8), (7/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-zabbix/coverage. 161 / 416 LOC (38.7%) covered.COVERAGE: 38.70% -- 161/416 lines in 16 files+----------+---------------------------------------------------+-------+--------+-------------------------------------------------------------------------...................................................... 5 file(s) with 100% coverage not shown4514 examples, 0 failuresTook 572 seconds (9:32) [Coveralls] Outside the CI environment, not sending data. mihai:puppet-zabbix mihai.buzgau$ bundle exec facter --version 4.0.12 Tests that are executed with Beaker and Agent are not impacted as we still provide Facter 3 in the Puppet Agent AIO

Add Comment

[Mihai Buzgau (Jira)]

Mihai Buzgau commented on FACT-2493

Re: Test community supported modules with Facter 4

for https://github.com/voxpupuli/puppet-prometheus the test_with_coveralls are passing with Facter 4:  Finished in 5 minutes 5 seconds (files took 17.56 seconds to load) 280 examples, 0 failuresCoverage report generated for (1/8), (2/8), (3/8), (4/8), (5/8), (6/8), (7/8), (8/8) to /Users/mihai.buzgau/work/code/modules/puppet-prometheus/coverage. 4 / 7 LOC (57.14%) covered.COVERAGE: 57.14% -- 4/7 lines in 1 files+----------+-------------------------------------+-------+--------+---------+ | coverage | file | lines | missed | missing | +----------+-------------------------------------+-------+--------+---------+ | 57.14% | lib/facter/alert_manager_running.rb | 7 | 3 | 7-8, 10 | +----------+-------------------------------------+-------+--------+---------+2555 examples, 0 failuresTook 323 seconds (5:23)

[Coveralls] Outside the CI environment, not sending data.

mihai:puppet-prometheus mihai.buzgau$ bundle exec facter --version 4.0.12     Add Comment