Jira (PUP-7930) Array delete does not work according to spec when right hand side is hash

[Thomas Hallgren (JIRA)]

Thomas Hallgren created an issue

Puppet / PUP-7930 Array delete does not work according to spec when right hand side is hash Issue Type: Bug Assignee: Unassigned Created: 2017/09/10 9:10 PM Priority: Minor Reporter: Thomas Hallgren The following sample can be found in the the Puppet Specifications chapter on Expression, section on "- operator" / Delete: [1,2,b] - {a => 1, b => 20} # => [2] but when evaluating the expression in puppet, the result is [1, 2, b]. Internally, puppet does roughly this: array - hash.to_a and since hash.to_a returns an array of 2-element arrays (key pairs) one of two things should change. Either the example should be changed into: [[1,2],[b,20]] - {a => 1, b => 20} # => [[1,2]] or the code should change to: array - hash.to_a.flatten Add Comment

This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-7930

Re: Array delete does not work according to spec when right hand side is hash The specification is vague. The example shown for "an array - a hash" is wrong given how the operation is specified (RHS if not an Array is turned into one before deleting). That means that the example should be updated. It is however questionable if it is at all meaningful to treat a hash as a set of key-value tuples that are deleted from the LHS array. It is good if the LHS is the result of a hash to array conversion, but for all other purposes it just seems wrong. What if you have an array of hashes and want to delete a particular hash - that simply cannot be done. I therefore think that an "an array - a hash" should really be "an array - [a hash]" to delete it as a value. Other use cases are then supported by first converting the Hash to an Array. If agreeing to this, the spec needs to specify what "RHS is converted to an array" means (i.e. that it is wrapped in an array).

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7930

Array delete does not work according to spec when right hand side is hash

Change By: Josh Cooper Team: Coremunity Server

Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-7930 Array delete does not work according to spec when right hand side is hash

Change By: Josh Cooper Sub-team: Language

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-7930 Array delete does not work according to spec when right hand side is hash

Change By: Henrik Lindberg Fix Version/s: PUP 7.0.0

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-7930

Re: Array delete does not work according to spec when right hand side is hash For PUP 7.0.0 I think we should implement what I proposed above - delete of a hash deletes the entire hash as a value - other types is up to the user by first transforming the hash value (use the keys, use tuples, use values, or something else).

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7930

Array delete does not work according to spec when right hand side is hash

Change By: Josh Cooper Epic Link: PUP-10591

Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7930 Array delete does not work according to spec when right hand side is hash

Change By: Josh Cooper Team: Froyo Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7930

Re: Array delete does not work according to spec when right hand side is hash

It is however questionable if it is at all meaningful to treat a hash as a set of key-value tuples that are deleted from the LHS array.

I agree that it is questionable and the change is not hard diff --git a/lib/puppet/pops/evaluator/evaluator_impl.rb b/lib/puppet/pops/evaluator/evaluator_impl.rb index 8bf13d22e8..9c03c069d4 100644 --- a/lib/puppet/pops/evaluator/evaluator_impl.rb +++ b/lib/puppet/pops/evaluator/evaluator_impl.rb @@ -1264,7 +1264,6 @@ class EvaluatorImpl when Array y = case y when Array then y - when Hash then y.to_a else [y] end But we have tests that exercise the behavior of deleting hash key tuples from the LHS array, see https://github.com/puppetlabs/puppet/blob/c2b87527385516b64fbe3ef991ea4417df346e9e/spec/unit/pops/evaluator/collections_ops_spec.rb#L64 https://github.com/puppetlabs/puppet/blob/c2b87527385516b64fbe3ef991ea4417df346e9e/spec/unit/pops/evaluator/evaluating_parser_spec.rb#L102 Given that, I'm inclined to update the specification to match the current behavior and add a note warning about the hash to array conversion. Note deleting hashes from the array works provided the RHS is given as an array of hashes for 1 and 2 level hashes: $ bx puppet apply -e "notice([{1 => 2}, {3 => 4}] - [{1 => 2}])" Notice: Scope(Class[main]): [{3 => 4}] .. $ bx puppet apply -e "notice([{1 => {2 => 3}}, {3 => 4}] - [{1 => {2 => 3}}])" Notice: Scope(Class[main]): [{3 => 4}]

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7930

Re: Array delete does not work according to spec when right hand side is hash

Talked this over with Nick Lewis and we concluded that puppet consistently treats a hash as an array of key-value pairs for set addition and subtraction: [1,2] + {1 => 2} # => [1,2,[1,2]] [1,2,[3,4]] - {3 => 4} # => [1,2] [1,2,3,4] - {3 => 4} # => [1,2,3,4] So we should update the specification to match the current behavior.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7930

Re: Array delete does not work according to spec when right hand side is hash

PR submitted in https://github.com/puppetlabs/puppet-specifications/pull/150

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-7930

Array delete does not work according to spec when right hand side is hash

Change By: Josh Cooper Fix Version/s: PUP 7.0.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7930

Re: Array delete does not work according to spec when right hand side is hash Merged in https://github.com/puppetlabs/puppet-specifications/commit/12b1ed7daed35fa9aee65d09a4c32cc73faaa87f

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-7930

Re: Array delete does not work according to spec when right hand side is hash

Docs already look correct https://puppet.com/docs/puppet/6.17/lang_expressions.html#-(removal), so resolving this.

Add Comment