Jira (PUP-10509) Drop support for ruby < 2.5

29 views
Skip to first unread message

Josh Cooper (Jira)

unread,
May 14, 2020, 1:23:02 PM5/14/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Task PUP-10509
Drop support for ruby < 2.5
Issue Type: Task Task
Assignee: Unassigned
Created: 2020/05/14 10:22 AM
Fix Versions: PUP 7.0.0
Priority: Normal Normal
Reporter: Josh Cooper

Puppet (the gem) currently supports ruby 2.3 and up, but 2.3 and 2.4 are EOL (https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/). We should drop those versions in puppet 7, remove monkey patches relating to older versions, and reduce our CI testing matrix.

Bolt already requires 2.5

JRuby 9.2 supports ruby 2.5 so that shouldn't affect puppetserver. /cc Maggie Dreyer, Justin Stoller
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Justin Stoller (Jira)

unread,
May 14, 2020, 1:39:03 PM5/14/20
to puppe...@googlegroups.com
Justin Stoller commented on Task PUP-10509
 
Re: Drop support for ruby < 2.5

9.2 does report 2.5 though JRuby doesn't always fully support the version it reports as. As long as we keep 9.2 in the test matrix I think we're good.

Josh Cooper (Jira)

unread,
May 14, 2020, 2:19:04 PM5/14/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Puppet (the gem) currently supports ruby 2.3 and up, but 2.3 and 2.4 are EOL (https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/). We should drop those versions in puppet 7, remove monkey patches relating to older versions, and reduce our CI testing matrix. Also drop distinction between Bignum and Fixnum (they were unified as Integer in 2.4).

Bolt already requires 2.5

JRuby 9.2 supports ruby 2.5 so that shouldn't affect puppetserver. /cc [~maggie], [~justin]

Josh Cooper (Jira)

unread,
Jul 21, 2020, 12:55:02 PM7/21/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Epic Link: PUP- 9120 10592

Rob Braden (Jira)

unread,
Jul 22, 2020, 7:05:03 PM7/22/20
to puppe...@googlegroups.com
Rob Braden updated an issue
Change By: Rob Braden
Labels: platform_7

Josh Cooper (Jira)

unread,
Aug 20, 2020, 8:35:03 PM8/20/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Team: Coremunity Night's Watch

Josh Cooper (Jira)

unread,
Aug 20, 2020, 8:39:04 PM8/20/20
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10509
 
Re: Drop support for ruby < 2.5

I think all of these monkey patches can be deleted: https://github.com/puppetlabs/puppet/blob/main/lib/puppet/util/monkey_patches.rb#L85-L150

There's also some conditional spec logic in:

spec/unit/functions/camelcase_spec.rb:  it 'performs capitalize of international UTF-8 characters', :if => RUBY_VERSION >= "2.4" do
 
spec/unit/functions/capitalize_spec.rb:  it 'performs capitalize of international UTF-8 characters', :if => RUBY_VERSION >= "2.4" do
 
spec/unit/functions/downcase_spec.rb:  it 'performs capitalize of international UTF-8 characters', :if => RUBY_VERSION >= "2.4" do
 
spec/unit/functions/upcase_spec.rb:  it 'performs capitalize of international UTF-8 characters', :if => RUBY_VERSION >= "2.4" do
 
spec/unit/http/factory_spec.rb:  it "disables ruby's max retry on 2.5 and up", if: RUBY_VERSION.to_f >= 2.5 do
 
spec/unit/util/run_mode_spec.rb:    @gte_ruby_2_4 ||= SemanticPuppet::Version.parse(RUBY_VERSION) >= SemanticPuppet::Version.parse('2.4.0')
 
spec/unit/util_spec.rb:    @gte_ruby_2_4 ||= SemanticPuppet::Version.parse(RUBY_VERSION) >= SemanticPuppet::Version.parse('2.4.0')

Mihai Buzgau (Jira)

unread,
Aug 26, 2020, 3:41:04 AM8/26/20
to puppe...@googlegroups.com
Mihai Buzgau commented on Task PUP-10509

Some of the work for removing EOL Ruby version support was done here: https://tickets.puppetlabs.com/browse/PUP-10625 

We can update the distinction between fixnum and bignum as part of this ticket.

Mihai Buzgau (Jira)

unread,
Aug 26, 2020, 3:42:03 AM8/26/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
 
Change By: Mihai Buzgau
Story Points: 1

Mihai Buzgau (Jira)

unread,
Aug 26, 2020, 3:42:03 AM8/26/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09-16

Mihai Buzgau (Jira)

unread,
Aug 26, 2020, 4:05:03 AM8/26/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09- 16 01

Gabriel Nagy (Jira)

unread,
Aug 31, 2020, 10:44:03 AM8/31/20
to puppe...@googlegroups.com
Gabriel Nagy assigned an issue to Gabriel Nagy
Change By: Gabriel Nagy
Assignee: Gabriel Nagy

Mihai Buzgau (Jira)

unread,
Sep 2, 2020, 5:19:03 AM9/2/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-09-01 , NW - 2020-09-16

Josh Cooper (Jira)

unread,
Sep 9, 2020, 8:29:04 PM9/9/20
to puppe...@googlegroups.com

Gabriel Nagy (Jira)

unread,
Sep 11, 2020, 7:16:03 AM9/11/20
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
 
Change By: Gabriel Nagy
Release Notes: Enhancement
Release Notes Summary: Replace usage of Fixnum and Bignum with Integer as part of dropping support for Rubies older than 2.5.

Josh Cooper (Jira)

unread,
Sep 14, 2020, 9:31:04 PM9/14/20
to puppe...@googlegroups.com
Josh Cooper commented on Task PUP-10509
 
Re: Drop support for ruby < 2.5

Passed CI in e2a883df7e

Claire Cadman (Jira)

unread,
Nov 9, 2020, 11:51:03 AM11/9/20
to puppe...@googlegroups.com
Claire Cadman updated an issue
 
Change By: Claire Cadman
Labels: doc_reviewed platform_7
Reply all
Reply to author
Forward
0 new messages