Jira (PUP-10294) Order dependent test failure with recent pidlock changes

14 views
Skip to first unread message

Josh Cooper (JIRA)

unread,
Feb 13, 2020, 7:58:05 PM2/13/20
to puppe...@googlegroups.com
Josh Cooper created an issue
 
Puppet / Bug PUP-10294
Order dependent test failure with recent pidlock changes
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/02/13 4:57 PM
Priority: Normal Normal
Reporter: Josh Cooper 

$ bundle exec ruby --version
 
ruby 2.3.8p459 (2018-10-18 revision 65136) [x86_64-darwin18]
 
$ git rev-parse HEAD
 
88cb4f20657b9ea7b9eafc34a6039bde5102c5cd
 
$ bundle exec rspec spec/unit/agent_spec.rb:220  spec/unit/util/pidlock_spec.rb:23
 
...
 
  1) Puppet::Util::Pidlock#ps pid argument on posix should allow ps execution
 
     Failure/Error: expect(@lock).to be_locked
 
       expected `#<Puppet::Util::Pidlock:0x00007fd1d5a5f308 @lockfile=#<Puppet::Util::Lockfile:0x00007fd1d5a5f2e0 @fil...ers/8m/d6146zxd6bv_3h8y4ykvvxh40000gn/T/rspecrun20200213-39510-1m2gjzq/lock20200213-39510-15x8lj0">>.locked?` to return true, got false
 
     # ./spec/unit/util/pidlock_spec.rb:23:in `block (3 levels) in <top (required)>'
 
     # ./spec/spec_helper.rb:180:in `block (2 levels) in <top (required)>'
 
 
 
Finished in 0.11031 seconds (files took 0.99606 seconds to load)
 
2 examples, 1 failure

Running the pidlock spec in isolation works fine, so something about the agent_spec is leaking into the other test.
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Mihai Buzgau (JIRA)

unread,
Feb 14, 2020, 5:16:04 AM2/14/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-02-19

Mihai Buzgau (JIRA)

unread,
Feb 14, 2020, 5:16:04 AM2/14/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Story Points: 1

Luchian Nemes (JIRA)

unread,
Feb 14, 2020, 10:03:03 AM2/14/20
to puppe...@googlegroups.com
Luchian Nemes assigned an issue to Luchian Nemes
Change By: Luchian Nemes
Assignee: Luchian Nemes

Josh Cooper (JIRA)

unread,
Feb 14, 2020, 1:24:04 PM2/14/20
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 6.14.0

Mihai Buzgau (JIRA)

unread,
Feb 19, 2020, 6:19:06 AM2/19/20
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2020-02-19 , NW - 2020-03-04

Luchian Nemes (JIRA)

unread,
Feb 20, 2020, 9:17:03 AM2/20/20
to puppe...@googlegroups.com
Luchian Nemes commented on Bug PUP-10294
 
Re: Order dependent test failure with recent pidlock changes

Added full explanation of the issue in the pull request.

 

Also created PUP-10302 for solving the agent_spec leakage issue.
Reply all
Reply to author
Forward
0 new messages