Jira (PUP-8089) Pluginsync locale files

2 views
Skip to first unread message

Maggie Dreyer (JIRA)

unread,
Oct 25, 2017, 1:59:02 PM10/25/17
to puppe...@googlegroups.com
Maggie Dreyer created an issue
 
Puppet / Sub-task PUP-8089
Pluginsync locale files
Issue Type: Sub-task Sub-task
Assignee: Unassigned
Created: 2017/10/25 10:58 AM
Priority: Normal Normal
Reporter: Maggie Dreyer

The first part of getting module translations visible on the the agent is to actually download the locale files along with the other module data. This involves the following steps:

  • Add a new mount in file_serving/mount to find locale files in modules on the master.
  • Add a new Downloader to the DownloaderFactory for downloading locale files. This downloader should put the files into a directory structure like $vardir/locales/<locale>/<module_name>.po. For the time being, we should sync all of the available locales, not just the one detected on the system. This can be optimized later if needed.
  • Add the relevant settings for the new downloader (e.g. localedest and localesource) to the settings defaults.
  • Add tests for the new Downloader to the downloader factor specs.
  • Update the tests in the plugin handler specs to exercise the locale downloader.

Other pieces may fall out of this, and other tests may need to be updated, but this is a good start. Note that this will not cause any module translations to actually be displayed; this ticket's other subtask describes the work needed to load the translation files from $vardir once they are present.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Maggie Dreyer (JIRA)

unread,
Oct 25, 2017, 2:08:04 PM10/25/17
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
Change By: Maggie Dreyer
The first part of getting module translations visible on the the agent is to actually download the locale files along with the other module data. This involves the following steps:
- Add a new mount in [file_serving/mount|https://github.com/puppetlabs/puppet/tree/master/lib/puppet/file_serving/mount] to find locale files in modules on the master.
- Add a new Downloader to the [DownloaderFactory|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/configurer/downloader_factory.rb] for downloading locale files. This downloader should put the files into a directory structure like {{$vardir/locales/<locale>/<module_name>.po}}. For the time being, we should sync all of the available locales, not just the one detected on the system. This can be optimized later if needed.
- Add the relevant settings for the new downloader (e.g. {{localedest}} and {{localesource}}) to the [settings defaults|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/defaults.rb
#L1690-L1729 ].
- Add tests for the new Downloader to the [downloader factor specs|https://github.com/puppetlabs/puppet/blob/master/spec/unit/configurer/downloader_factory_spec.rb].
- Update the tests in the [plugin handler specs|https://github.com/puppetlabs/puppet/blob/master/spec/unit/configurer/plugin_handler_spec.rb] to exercise the locale downloader.


Other pieces may fall out of this, and other tests may need to be updated, but this is a good start. Note that this will not cause any module translations to actually be displayed; this ticket's other subtask describes the work needed to load the translation files from {{$vardir}} once they are present.

Maggie Dreyer (JIRA)

unread,
Oct 26, 2017, 7:09:17 PM10/26/17
to puppe...@googlegroups.com
Maggie Dreyer assigned an issue to Maggie Dreyer
Change By: Maggie Dreyer
Assignee: Maggie Dreyer

Maggie Dreyer (JIRA)

unread,
Oct 27, 2017, 12:34:02 PM10/27/17
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
The  first  second  part of getting module translations visible on the the agent is to actually download the locale files along with the other module data. This involves the following steps:
- Add a new mount in [file_serving/mount|https://github.com/puppetlabs/puppet/tree/master/lib/puppet/file_serving/mount] to find locale files in modules on the master.
- Add a new Downloader to the [DownloaderFactory|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/configurer/downloader_factory.rb] for downloading locale files. This downloader should put the files into a directory structure like {{$vardir/locales/<locale>/<module_name>.po}}. For the time being, we should sync all of the available locales, not just the one detected on the system. This can be optimized later if needed.
- Add the relevant settings for the new downloader (e.g. {{localedest}} and {{localesource}}) to the [settings defaults|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/defaults.rb#L1690-L1729].

- Add tests for the new Downloader to the [downloader factor specs|https://github.com/puppetlabs/puppet/blob/master/spec/unit/configurer/downloader_factory_spec.rb].
- Update the tests in the [plugin handler specs|https://github.com/puppetlabs/puppet/blob/master/spec/unit/configurer/plugin_handler_spec.rb] to exercise the locale downloader.

Other pieces may fall out of this, and other tests may need to be updated, but this is a good start. Note that this will not cause any module translations to actually be displayed; this ticket's other subtask describes the work needed to load the translation files from {{$vardir}} once they are present.

Maggie Dreyer (JIRA)

unread,
Oct 27, 2017, 12:53:52 PM10/27/17
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
The second part of getting module translations visible on the the agent is to actually download the locale files along with the other module data. This involves the following steps:


- Add a new Downloader to the [DownloaderFactory|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/configurer/downloader_factory.rb] for downloading locale files. This downloader should put the files into a directory structure like {{$vardir/locales/<locale>/<module_name>.po}}. For the time being, we should sync all of the available locales, not just the one detected on the system. This can be optimized later if needed.
- Add the relevant settings for the new downloader (e.g. {{localedest}} and {{localesource}}) to the [settings defaults|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/defaults.rb#L1690-L1729].
- Add tests for the new Downloader to the [downloader  factor  factory  specs|https://github.com/puppetlabs/puppet/blob/master/spec/unit/configurer/downloader_factory_spec.rb].

- Update the tests in the [plugin handler specs|https://github.com/puppetlabs/puppet/blob/master/spec/unit/configurer/plugin_handler_spec.rb] to exercise the locale downloader.

Other pieces may fall out of this, and other tests may need to be updated, but this is a good start. Note that this will not cause any module translations to actually be displayed; this ticket's other subtask describes the work needed to load the translation files from {{$vardir}} once they are present.

Maggie Dreyer (JIRA)

unread,
Nov 3, 2017, 7:27:03 PM11/3/17
to puppe...@googlegroups.com
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Dec 11, 2017, 10:09:02 AM12/11/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Fix Version/s: PUP 5.4.0

Maggie Dreyer (JIRA)

unread,
Feb 6, 2018, 5:39:02 PM2/6/18
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
Change By: Maggie Dreyer
Release Notes Summary: During pluginsync, the agent will now download module translation files along with the rest of the module data.
Release Notes: New Feature
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:49:04 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages