Jira (FACT-2825) Facter 4 leaks threads in puppet server on jruby

11 views
Skip to first unread message

Bogdan Irimie (Jira)

unread,
Oct 2, 2020, 2:58:05 AM10/2/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
 
Facter / Bug FACT-2825
Facter 4 leaks threads in puppet server on jruby
Change By: Bogdan Irimie
Summary: Facter 4 leaks threads in puppet server on jruby
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Bogdan Irimie (Jira)

unread,
Oct 2, 2020, 4:12:04 AM10/2/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Integration test for puppetserver test for thread leakage https://github.com/puppetlabs/puppetserver/pull/2424/files

The tests fail with Facter 4, this might be due to Facter::Core::Execution

Oana Tanasoiu (Jira)

unread,
Oct 2, 2020, 7:51:03 AM10/2/20
to puppe...@googlegroups.com
Oana Tanasoiu updated an issue
Change By: Oana Tanasoiu
Facter::Core::Execution is working with a timeout since this [Facter PR|[https://github.com/puppetlabs/facter/pull/2080] . ] This change leads to a failure of a [puppet-server test|https://github.com/puppetlabs/puppetserver/blob/b903fb69c2a2064c25d30757370a35bf1ce093a8/test/integration/puppetlabs/services/jruby/jruby_puppet_pool_int_test.clj#L625] because Timeout class in Jruby leads to thread leaking.

Oana Tanasoiu (Jira)

unread,
Oct 2, 2020, 7:51:04 AM10/2/20
to puppe...@googlegroups.com
Oana Tanasoiu updated an issue
Integration Facter::Core::Execution is working with a timeout since this [Facter PR|[https://github.com/puppetlabs/facter/pull/2080].] This change leads to a failure of a [puppet-server test for puppetserver test for thread leakage | https://github.com/puppetlabs/puppetserver/ pull blob / 2424 b903fb69c2a2064c25d30757370a35bf1ce093a8 / files

The tests fail with Facter 4, this might be due
test/integration/puppetlabs/services/jruby/jruby_puppet_pool_int_test.clj#L625] because Timeout class in Jruby leads to Facter::Core::Execution thread leaking.

Oana Tanasoiu (Jira)

unread,
Oct 2, 2020, 7:51:05 AM10/2/20
to puppe...@googlegroups.com
Oana Tanasoiu updated an issue
Facter::Core::Execution is working with a timeout since this [Facter PR|[https://github.com/puppetlabs/facter/pull/2080]] This change leads to a failure of a [puppet-server test|https://github.com/puppetlabs/puppetserver/blob/b903fb69c2a2064c25d30757370a35bf1ce093a8/test/integration/puppetlabs/services/jruby/jruby_puppet_pool_int_test.clj#L625] because Timeout class in Jruby leads to thread leaking.

Oana Tanasoiu (Jira)

unread,
Oct 2, 2020, 7:52:04 AM10/2/20
to puppe...@googlegroups.com
Oana Tanasoiu updated an issue
Facter::Core::Execution is working with a timeout since this  [ Facter PR | [https://github.com/puppetlabs/facter/pull/2080] ]   . This change leads to a failure of a [puppet-server test|https://github.com/puppetlabs/puppetserver/blob/b903fb69c2a2064c25d30757370a35bf1ce093a8/test/integration/puppetlabs/services/jruby/jruby_puppet_pool_int_test.clj#L625] because Timeout class in Jruby leads to thread leaking.

Bogdan Irimie (Jira)

unread,
Oct 7, 2020, 9:14:03 AM10/7/20
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Oct 7, 2020, 9:15:03 AM10/7/20
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ready for triage ghost-14.10

Oana Tanasoiu (Jira)

unread,
Oct 8, 2020, 3:44:04 AM10/8/20
to puppe...@googlegroups.com
Oana Tanasoiu commented on Bug FACT-2825
 
Re: Facter 4 leaks threads in puppet server on jruby

The problem was that the puppetserver test checked all the threads from timeout library instead of the object ID so it detected Facter's timeout thread like a leak thread. The test was updated in https://github.com/puppetlabs/puppetserver/pull/2424 and Facter doesn't impact the puppetserver any longer.

Oana Tanasoiu (Jira)

unread,
Oct 8, 2020, 6:47:04 AM10/8/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages