Jira (PUP-10959) Lock loaders using a single central lock

19 views
Skip to first unread message

Maggie Dreyer (Jira)

unread,
Mar 9, 2021, 8:11:03 PM3/9/21
to puppe...@googlegroups.com
Maggie Dreyer created an issue
 
Puppet / Improvement PUP-10959
Lock loaders using a single central lock
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2021/03/09 5:10 PM
Priority: Normal Normal
Reporter: Maggie Dreyer

Currently, we lock each individual loader object with its own lock. This can result in deadlocks, when loaders call into other loaders in the process of loading.

Instead, we want to try a single, central, high-level lock, perhaps in the base load function, that is tied to the environment/loaders object. So only one thing can be loaded for a given environment at a time. This should avoid deadlocks.

We'll probably want to try profiling this a little, but it should avoid the issue that is currently making multithreaded with environment caching unusable. See SERVER-2860 and PE-30479.

This solution is an alternative to PUP-10958.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Gene Liverman (Jira)

unread,
Mar 10, 2021, 10:54:08 AM3/10/21
to puppe...@googlegroups.com
Gene Liverman updated an issue
Change By: Gene Liverman
Labels: customer0

Cas Donoghue (Jira)

unread,
Mar 10, 2021, 4:30:02 PM3/10/21
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Story Points: 5

Cas Donoghue (Jira)

unread,
Mar 10, 2021, 4:30:03 PM3/10/21
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Sprint: Froyo - 03/24/2021

Patrick Carlisle (Jira)

unread,
Mar 17, 2021, 12:25:03 PM3/17/21
to puppe...@googlegroups.com
Patrick Carlisle assigned an issue to Patrick Carlisle
Change By: Patrick Carlisle
Assignee: Patrick Carlisle

Cas Donoghue (Jira)

unread,
Mar 24, 2021, 4:07:03 PM3/24/21
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Sprint: Froyo - 03/24/2021 , Froyo - 04/7/2021

Josh Cooper (Jira)

unread,
Apr 7, 2021, 12:51:04 AM4/7/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 7.6.0
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Patrick Carlisle (Jira)

unread,
Apr 7, 2021, 2:33:03 PM4/7/21
to puppe...@googlegroups.com
Patrick Carlisle updated an issue
Change By: Patrick Carlisle
Release Notes: Not Needed

Christine Yoon (Jira)

unread,
Apr 8, 2021, 3:07:03 PM4/8/21
to puppe...@googlegroups.com
Christine Yoon commented on Improvement PUP-10959
 
Re: Lock loaders using a single central lock

Melissa Amos This ticket resolves the known issue in PE-30479

Was not sure if I should add this as a resolved issue to 2021.1.0 if this is fixed in PUP 7.6.0? 

 

Maggie Dreyer (Jira)

unread,
Apr 8, 2021, 3:49:03 PM4/8/21
to puppe...@googlegroups.com

We should probably verify with customer0 that this actually fixes the issue before committing to documenting the fix.

Reply all
Reply to author
Forward
0 new messages