Jira (PUP-10967) Puppet always prints errors in debug when trying to resolve account to SID

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-10967 Puppet always prints errors in debug when trying to resolve account to SID Issue Type: Bug Affects Versions: PUP 7.5.0 Assignee: Unassigned Created: 2021/03/16 6:16 PM Priority: Minor Reporter: Josh Cooper Puppet on Windows shows the following errors when running with debugging: C:\> puppet agent -t --debug ... Debug: Processing report from xxx with processor Puppet::Reports::Store Debug: Could not retrieve raw SID bytes from 'Administrator': Failed to convert string SID: Administrator: The security ID structure is invalid. Debug: Could not retrieve raw SID bytes from 'Administrator': Failed to convert string SID: Administrator: The security ID structure is invalid. This debugging was added in https://github.com/puppetlabs/puppet/commit/bea9ff75d5946dbb92c90ef068cf6c2d4cb0db85. However, the name_to_principal method is sometimes called with valid account names like Administrator, so the call to string_to_sid_ptr fails with (ERROR_INVALID_SID 0x539 and the debug message is printed. I think it'd be better to check if name starts with something like S-\d+-\d+ or only log the error if e.code != 0x539. For example, if the SID string refers to an account that doesn't exist, you'll get 0x534 ERROR_NONE_MAPPED. Add Comment

This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10967 Puppet always prints errors in debug when trying to resolve account to SID

Change By: Ciprian Badescu Sprint: NW-2021-06-30

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10967 Puppet always prints errors in debug when trying to resolve account to SID

Change By: Ciprian Badescu Team: Night's Watch

Add Comment

[Ciprian Badescu (Jira)]

Ciprian Badescu updated an issue

Puppet / PUP-10967 Puppet always prints errors in debug when trying to resolve account to SID

Change By: Ciprian Badescu Story Points: 1

Add Comment

[Luchian Nemes (Jira)]

Luchian Nemes assigned an issue to Luchian Nemes

Puppet / PUP-10967 Puppet always prints errors in debug when trying to resolve account to SID

Change By: Luchian Nemes Assignee: Luchian Nemes

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10967

Re: Puppet always prints errors in debug when trying to resolve account to SID Merged to 6.x in https://github.com/puppetlabs/puppet/commit/31515a6f30ddd3113be40183fbe5e7fd302b581d

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10967

Puppet always prints errors in debug when trying to resolve account to SID

Change By: Josh Cooper Fix Version/s: PUP 7.9.0 Fix Version/s: PUP 6.24.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-10967

Re: Puppet always prints errors in debug when trying to resolve account to SID Passed CI in b7c9dd387a

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-10967

Puppet always prints errors in debug when trying to resolve account to SID

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Puppet no longer prints an unnecessary error message when resolving account names to SIDs on Windows

Add Comment

[Claire Cadman (Jira)]

Claire Cadman updated an issue

Puppet / PUP-10967 Puppet always prints errors in debug when trying to resolve account to SID

Change By: Claire Cadman Labels: doc-reviewed

Add Comment