Jira (PUP-11438) An iterable returned by tree_each iterator does not work with reduce

[Alex Tayts (Jira)]

Alex Tayts created an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce Issue Type: Bug Affects Versions: PUP 7.13.1, PUP 7.12.0, PUP 7.14.0 Assignee: Unassigned Components: Language Created: 2022/01/28 9:27 AM Environment: Tested on Debian 10,11/Ubuntu 18.04,20.04/Red Hat 7,8/Oracle Linux 7,8/CentOS 7,8. Tested on the latest puppet agent versions, but likely this has been around since forever. Priority: Major Reporter: Alex Tayts tree_each function returns an iterator, which is supposed to chain with revers_each, filter, map and reduce according to the documentation In practice one of the chained functions, reduce does not work. The minimal code to reproduce with puppet apply: $tree = {} notice $tree.tree_each.reduce({}) |$m, $v| { $m } This results in an error: Error: Evaluation Error: Error while evaluating a Method call, undefined method `reduce' for #<Puppet::Pops::Types::Iterable::DepthFirstTreeIterator:0x00005653899c8280> Did you mean?  rescue (file: /srv/production/site/profile/manifests/test.pp, line: 2, column: 30) on node ruthenium-dev joshalso  Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Alex Tayts (Jira)]

Alex Tayts updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce

Change By: Alex Tayts _tree_each_ function returns an iterator, which is supposed to chain with _revers_each,_ _filter, map_ and _reduce_ according to the [documentation| [https://puppet.com/docs/puppet/7/function.html #tree-each].] In practice one of the chained functions, _reduce_ does not work. The minimal code to reproduce with {_}puppet apply{_}: {code:java} $tree = {} notice $tree.tree_each.reduce({}) |$m, $v| { $m } {code}

This results in an error:

{code:java}

Error: Evaluation Error: Error while evaluating a Method call, undefined method `reduce' for #<Puppet::Pops::Types::Iterable::DepthFirstTreeIterator:0x00005653899c8280>

Did you mean?  rescue (file: /srv/production/site/profile/manifests/test.pp, line: 2, column: 30) on node ruthenium-dev{code} [~ joshalso josh ]

Add Comment

[Alex Tayts (Jira)]

Alex Tayts updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce Change By: Alex Tayts

_tree_each_ function returns an iterator, which is supposed to chain with _revers_each,_ _filter, map_ and _reduce_ according to the [ [ documentation| https://puppet.com/docs/puppet/7/function.html #tree-each] . |#tree-each ]   . In practice one of the chained functions, _reduce_ does not work.

The minimal code to reproduce with {_}puppet apply{_}: {code:java}$tree = {} notice $tree.tree_each.reduce({}) |$m, $v| { $m } {code} This results in an error: {code:java}Error: Evaluation Error: Error while evaluating a Method call, undefined method `reduce' for #<Puppet::Pops::Types::Iterable::DepthFirstTreeIterator:0x00005653899c8280> Did you mean?  rescue (file: /srv/production/site/profile/manifests/test.pp, line: 2, column: 30) on node ruthenium-dev{code}

[~josh]

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce

Change By: Josh Cooper Priority: Major Normal

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce Change By: Josh Cooper

_tree_each_ function returns an iterator, which is supposed to chain with _revers_each,_ _filter, map_ and _reduce_ according to the [ [ documentation|https://puppet.com/docs/puppet/7/function.html#tree-each ] |#tree-each]. In practice one of the chained functions, _reduce_ does not work.

The minimal code to reproduce with {_}puppet apply{_}: {code:java}$tree = {} notice $tree.tree_each.reduce({}) |$m, $v| { $m } {code} This results in an error: {code:java}Error: Evaluation Error: Error while evaluating a Method call, undefined method `reduce' for #<Puppet::Pops::Types::Iterable::DepthFirstTreeIterator:0x00005653899c8280> Did you mean?  rescue (file: /srv/production/site/profile/manifests/test.pp, line: 2, column: 30) on node ruthenium-dev{code} [~josh]

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11438

Re: An iterable returned by tree_each iterator does not work with reduce ruthenium It seems like this has never worked. Is there another way to accomplish your use case?

Add Comment

[Alex Tayts (Jira)]

Alex Tayts commented on PUP-11438

Re: An iterable returned by tree_each iterator does not work with reduce

Yes, there is. I have actually chatted about this with Henrik Lindberg and his workaround to coerce the tree_each output into an array before passing on to reduce works for me. Nevertheless he considered it to be a bug that should be fixed and asked me to submit it. I do agree with him because there is really no reason for this not to work. $tree = {} notice Array($tree.tree_each).reduce({}) |$m, $v| { $m } # works! If there are no plans to fix that, I think the documentation should be updated to exclude reduce from the list of the functions that could be chained to tree_each.

Add Comment

[Nirupama Mantha (Jira)]

Nirupama Mantha commented on PUP-11438

Re: An iterable returned by tree_each iterator does not work with reduce

We currently don't plan to address this, you can submit a PR if you would like us to review it. We will update our documentation to remove it from our list. cc/heston.hoffman

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11438

An iterable returned by tree_each iterator does not work with reduce

Change By: Josh Cooper Team: Phoenix

Add Comment

[Heston Hoffman (Jira)]

Heston Hoffman assigned an issue to Heston Hoffman

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce

Change By: Heston Hoffman Assignee: Heston Hoffman

Add Comment

[Heston Hoffman (Jira)]

Heston Hoffman assigned an issue to Unassigned

[Christopher Thorn (Jira)]

Christopher Thorn updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce

Change By: Christopher Thorn Fix Version/s: PUP 7.15.0 Fix Version/s: PUP 6.27.0

Add Comment

[Christopher Thorn (Jira)]

Christopher Thorn updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce

Change By: Christopher Thorn Release Notes: Not Needed Release Notes Summary: Just a docs change to make things clear reduce isn't supported.

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce

Change By: Josh Cooper

Fix Version/s: PUP 7.15.0 Fix Version/s: PUP 6.27.0

Add Comment

[Michael Hashizume (Jira)]

Michael Hashizume updated an issue

Puppet / PUP-11438 An iterable returned by tree_each iterator does not work with reduce

Change By: Michael Hashizume Fix Version/s: PUP 6.27.0

Add Comment