Jira (PUP-8436) puppet should only ignore pot files when syncing locales

1 view
Skip to first unread message

Josh Cooper (JIRA)

unread,
Feb 7, 2018, 4:18:02 PM2/7/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Puppet / Bug PUP-8436
puppet should only ignore pot files when syncing locales
Change By: Josh Cooper
Summary: puppet should only ignore pot files when syncing l locales
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
Atlassian logo

Josh Cooper (JIRA)

unread,
Feb 7, 2018, 4:28:02 PM2/7/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 5.3.5

Josh Cooper (JIRA)

unread,
Feb 7, 2018, 4:28:02 PM2/7/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
*Puppet Version: 5.3.4*
*Puppet Server Version: n/a*
*OS Name/Version:*

*Desired Behavior:*

Puppet should only ignore {{*.pot}} files when syncing {{locales}}, but not for {{plugins}} or {{pluginfacts}}.

*Actual Behavior:*

The default {{pluginsignore}} applies to all plugin related requests. We should instead exclude {{*.pot}} files in the same way we do for {{config.yaml}}, in the locales-specific downloader.


If you create an executable script named {{my.pot}} in the {{facts.d}} directory of a module, the agent won't download the file. On master:

{noformat}
$ echo <<END > ~/.puppetlabs/etc/code/environments/production/modules/acl/facts.d/my.pot
heredoc> #!/bin/sh
heredoc> echo "foo=bar"
heredoc> END
$ chmod a+x  ~/.puppetlabs/etc/code/environments/production/modules/acl/facts.d/my.pot
{noformat}

On agent, the file isn't downloaded:

{noformat}
$ bx puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
...
$ find  ~/.puppetlabs/opt/puppet/cache/facts.d
/Users/josh/.puppetlabs/opt/puppet/cache/facts.d
{noformat}

Kenn Hussey (JIRA)

unread,
Feb 8, 2018, 1:51:02 PM2/8/18
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Feb 8, 2018, 2:36:04 PM2/8/18
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Feb 8, 2018, 4:49:03 PM2/8/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Sprint: Platform Core KANBAN

Josh Cooper (JIRA)

unread,
Feb 9, 2018, 12:32:02 PM2/9/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
Fix Version/s: PUP 5.4.0

Josh Cooper (JIRA)

unread,
Feb 9, 2018, 12:46:02 PM2/9/18
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Feb 9, 2018, 12:46:02 PM2/9/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Feb 9, 2018, 12:55:03 PM2/9/18
to puppe...@googlegroups.com

Kenn Hussey (JIRA)

unread,
Feb 12, 2018, 9:56:02 AM2/12/18
to puppe...@googlegroups.com
Kenn Hussey commented on Bug PUP-8436
 
Re: puppet should only ignore pot files when syncing locales

Josh Cooper please add release notes for this issue, if needed. Thanks!

Josh Cooper (JIRA)

unread,
Feb 12, 2018, 12:13:03 PM2/12/18
to puppe...@googlegroups.com
Josh Cooper updated an issue
 
Change By: Josh Cooper
Release Notes Summary: Puppet will now only exclude *.pot files when downloading translation files from the locales mount point, instead of for all pluginsync related mount points.
Release Notes: Bug Fix

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:57:04 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages