Jira (PUP-3995) Prevent node resource names from potentially overlapping with other resources

1 view
Skip to first unread message

Hailee Kenney (JIRA)

unread,
Feb 10, 2015, 3:02:41 PM2/10/15
to puppe...@googlegroups.com
Hailee Kenney created an issue
 
Puppet / Bug PUP-3995
Prevent node resource names from potentially overlapping with other resources
Issue Type: Bug Bug
Assignee: Henrik Lindberg
Components: DSL, Language, Server
Created: 2015/02/10 12:02 PM
Priority: Normal Normal
Reporter: Hailee Kenney

Before the pull request for PUP-3167 was submitted, if a node with a regex name matched the name of of another resource (like a class), then it was possible that the two would step on each other. This is pretty clearly illustrated by the example given in the original ticket:

 class foo {
  $bar = 'one'
}
 
node /foo/ {
  $bar = 'two'
  include foo
  notice("${::foo::bar}")
} 

Although the issue was fixed for nodes specified with a regex, we were unable to fix the issue for all node names, since that fix would have been significantly more complicated than the one we implemented for regular expressions (see Henrik's comment on PUP-3167). As such, we need to find a way to prevent resource names for non-regex nodes and other resources from overlapping.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a)
Atlassian logo

Henrik Lindberg (JIRA)

unread,
Feb 10, 2015, 3:45:41 PM2/10/15
to puppe...@googlegroups.com
Henrik Lindberg commented on Bug PUP-3995
 
Re: Prevent node resource names from potentially overlapping with other resources

We tried mangling the name with severe side effects. The solution is probably t debug where the search for a class 'foo' to find the node 'foo' - that should simply not happen.

Henrik Lindberg (JIRA)

unread,
Sep 7, 2016, 6:12:24 PM9/7/16
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
 
Change By: Henrik Lindberg
Team: Puppet Developer Support
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Atlassian logo

Moses Mendoza (JIRA)

unread,
May 15, 2017, 8:03:06 PM5/15/17
to puppe...@googlegroups.com

Moses Mendoza (JIRA)

unread,
May 18, 2017, 1:49:36 PM5/18/17
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
May 19, 2017, 10:30:03 AM5/19/17
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
May 19, 2017, 10:30:07 AM5/19/17
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
May 19, 2017, 10:31:02 AM5/19/17
to puppe...@googlegroups.com
 
Re: Prevent node resource names from potentially overlapping with other resources

It would be great if someone could help write a unit test that shows a failure of a node named foo and a class foo.

David Schmitt (JIRA)

unread,
Aug 3, 2017, 1:50:03 PM8/3/17
to puppe...@googlegroups.com
David Schmitt updated an issue
 
Change By: David Schmitt
Team: Puppet Developer Experience Platform Core

Henrik Lindberg (JIRA)

unread,
Nov 21, 2017, 8:14:01 AM11/21/17
to puppe...@googlegroups.com
Henrik Lindberg assigned an issue to Unassigned
Change By: Henrik Lindberg
Assignee: Henrik Lindberg
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 9, 2021, 2:35:02 PM6/9/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-3995
 
Re: Prevent node resource names from potentially overlapping with other resources

The problem is indeed that "logic that forgets to check if it is a class or a *node* that was found", see PUP-1357. Since we allow regex to coexist and the fix for PUP-1357 seems simple, I'm going to close this won't do. If someone requires more complicated node classification, there's always hiera or external node classifier.

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages