Jira (PUP-8744) Using a variable in a Type on a parameter results in an error unless the variable was already loaded

[Nick Walker (JIRA)]

Nick Walker created an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded Issue Type: Bug Assignee: Unassigned Created: 2018/05/16 12:37 PM Priority: Normal Reporter: Nick Walker The Problem If you use a variable from say your params class in a type of a parameter then whether or not you can parse that class depends on whether you included a class that loaded params before the class you use the variable in. Anyway here's an example: https://github.com/npwalker/regex_variable/blob/master/manifests/profile/test.pp#L8 Suggested solution Either this should work every time or it should never work. I'd be fine with detection of this behavior and an outright failure. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Nick Walker (JIRA)]

Nick Walker commented on PUP-8744

Re: Using a variable in a Type on a parameter results in an error unless the variable was already loaded Henrik Lindberg Thomas Hallgren as I was discussing in the language room today.

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on PUP-8744

Re: Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Thomas Hallgren I think we need to make the type declarations for parameters only accept literal expressions - what do you think?

Add Comment

[Thomas Hallgren (JIRA)]

Thomas Hallgren commented on PUP-8744

Re: Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Yes, I agree with that. The type declaration is a static construct so allowing non-literals is a bug.

Add Comment

[Thomas Hallgren (JIRA)]

Thomas Hallgren commented on PUP-8744

Re: Using a variable in a Type on a parameter results in an error unless the variable was already loaded

If someone would want to do dynamic checking, that is possible, but it must be done in code (of course, since it's dynamic). A type can be parsed from a String. Example where $myvar is a regexp: $the_type = Type("Pattern[$myvar]") $value = $the_type.assert_type($value)

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-8744

Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Henrik Lindberg Fix Version/s: PUP 6.0.0

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Henrik Lindberg Sub-team: Language Team: Platform Core

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded Change By: Henrik Lindberg

h1. The Problem

If you use a variable from say your params class in a type of a parameter then whether or not you can parse that class depends on whether you included a class that loaded params before the class you use the variable in.   Anyway here's an example: https://github.com/npwalker/regex_variable/blob/master/manifests/profile/test.pp#L8

h1.  Suggested solution

Either this should work every time or it should never work.  I'd be fine with detection of this behavior and an outright failure.

UPDATE ----- The data types for parameters must be literal expressions and should error when a variable or function call is used.

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Kenn Hussey Flagged: Impediment

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Henrik Lindberg Fix Version/s: PUP 6.0.0 Fix Version/s: PUP 6.0.1

Add Comment

[Kenn Hussey (JIRA)]

Kenn Hussey updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Kenn Hussey Flagged: Impediment

Add Comment

[Eric Thompson (JIRA)]

Eric Thompson commented on PUP-8744

Re: Using a variable in a Type on a parameter results in an error unless the variable was already loaded Henrik Lindberg, Nick Walker is this still being targetted at 6.0.1?

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg updated an issue

Puppet / PUP-8744

Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Henrik Lindberg Fix Version/s: PUP 6.0.1 Fix Version/s: PUP 6.0.z

Add Comment

[Josh Cooper (JIRA)]

Josh Cooper updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Josh Cooper Fix Version/s: PUP 6.0.z

Add Comment

[David McTavish (Jira)]

David McTavish updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: David McTavish Labels: final_triage

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)

[Molly Waggett (Jira)]

Molly Waggett updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Molly Waggett Team: Froyo Phoenix

Add Comment

[Molly Waggett (Jira)]

Molly Waggett updated an issue

Puppet / PUP-8744 Using a variable in a Type on a parameter results in an error unless the variable was already loaded

Change By: Molly Waggett Labels: final_triage

Add Comment