Jira (FACT-3007) Facter 4 outputs hypervisors facts differently on Amazon 7

14 views
Skip to first unread message

Gabriel Nagy (Jira)

unread,
Apr 13, 2021, 5:36:02 AM4/13/21
to puppe...@googlegroups.com
Luchian Nemes created an issue
 
Facter / Bug FACT-3007
Facter 4 outputs hypervisors facts differently on Amazon 7
Issue Type: Bug Bug
Assignee: Gabriel Nagy
Created: 2021/04/13 2:35 AM
Fix Versions: FACT 4.1.0
Priority: Normal Normal
Reporter: Luchian Nemes

Running puppet facts diff on Solaris 11 SPARC gives the following output:

        "hypervisors.ldom.role_control": {
 
          "new_value": "false",
 
          "old_value": false
 
        },
 
        "hypervisors.ldom.role_io": {
 
          "new_value": "false",
 
          "old_value": false
 
        },
 
        "hypervisors.ldom.role_root": {
 
          "new_value": "false",
 
          "old_value": false
 
        },
 
        "hypervisors.ldom.role_service": {
 
          "new_value": "false",
 
          "old_value": false
 
        },

This may be due to how Facter 3 represents boolean values in general, as ldom facts appear to be strings when placed in the collection: https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/solaris/ldom_resolver.cc#L55
Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Gabriel Nagy (Jira)

unread,
Apr 13, 2021, 5:39:01 AM4/13/21
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Change By: Gabriel Nagy
Running *puppet facts diff* on Solaris 11 SPARC Amazon 7 gives the following output:
{code:json}
         "       ❌ hypervisors. ldom xen . role_control": { context
          "new_value": "false",
          "old_value": false
        },
        "       ❌ hypervisors. ldom xen . role_io": { privileged
          "new_value"       Output example : "false",
          "old_value": false       {
        },
         "hypervisors. ldom xen . role_root context ": {
          "new_value": " false pv ",
          "old_value": false null
        },
        "hypervisors. ldom xen . role_service privileged ": {
          "new_value": " false " ,
          "old_value": false null
        } ,
      }
 {code}

This may be due to how Facter 3 represents boolean values in general, as ldom facts appear to be strings when placed in the collection: https://github.com/puppetlabs/facter/blob/3.x/lib/src/facts/solaris/ldom_resolver.cc#L55

Gabriel Nagy (Jira)

unread,
Apr 13, 2021, 5:39:03 AM4/13/21
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Running *puppet facts diff* on Amazon 7 gives the following output:
{code:json}
       ❌ hypervisors.xen.context
      ❌ hypervisors.xen.privileged
      Output example:
       {
        "hypervisors.xen.context": {
          "new_value": "pv",
          "old_value": null
        },
        "hypervisors.xen.privileged": {
          "new_value": false,
          "old_value": null
        }
      }
{code}

Claire Cadman (Jira)

unread,
Apr 13, 2021, 9:19:04 AM4/13/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed

Mihai Buzgau (Jira)

unread,
Apr 13, 2021, 9:36:01 AM4/13/21
to puppe...@googlegroups.com
Mihai Buzgau updated an issue
Change By: Mihai Buzgau
Sprint: NW - 2021-04-14

Gabriel Nagy (Jira)

unread,
Apr 14, 2021, 3:39:01 AM4/14/21
to puppe...@googlegroups.com
Gabriel Nagy updated an issue
Change By: Gabriel Nagy
Release Notes Summary: Fix an issue where Facter 4 reported boolean additional values as strings for Solaris LDOM facts the hypervisors fact on Amazon 7 . The values are now represented as boolean, similar to match the Facter 3 behavior.
Labels: doc_reviewed

Claire Cadman (Jira)

unread,
Apr 14, 2021, 11:11:02 AM4/14/21
to puppe...@googlegroups.com
Claire Cadman updated an issue
Change By: Claire Cadman
Labels: doc_reviewed
Reply all
Reply to author
Forward
0 new messages