Jira (BOLT-1325) Send Puppet logging functions to the outputter

[Nick Lewis (JIRA)]

Nick Lewis created an issue

Puppet Task Runner / BOLT-1325 Send Puppet logging functions to the outputter Issue Type: Improvement Assignee: Unassigned Created: 2019/05/20 4:10 PM Priority: Normal Reporter: Nick Lewis Currently, the Puppet logging functions (notice, info, etc) call the logger directly. This means the messages are no longer sent to console below warn-level. We should add Bolt-specific versions of these functions that generate "log" events that are handled by the outputter. The human outputter should print the messages to stdout, the json outputter should ignore them, and the logger outputter should forward them to the logger. Add Comment

This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)

[Nick Lewis (JIRA)]

Nick Lewis updated an issue

Puppet Task Runner / BOLT-1325 Send Puppet logging functions to the outputter

Change By: Nick Lewis Sprint: Bolt Ready for Grooming

Add Comment

[Lucy Wyman (JIRA)]

Lucy Wyman updated an issue

Puppet Task Runner / BOLT-1325 Send Puppet logging functions to the outputter

Change By: Lucy Wyman Sprint: Bolt Ready for Grooming Kanban

Add Comment

[Nick Lewis (JIRA)]

Nick Lewis assigned an issue to Nick Lewis

Puppet Task Runner / BOLT-1325 Send Puppet logging functions to the outputter

Change By: Nick Lewis Assignee: Nick Lewis

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on BOLT-1325

Re: Send Puppet logging functions to the outputter Nick Lewis Did you start on this already? Isn't there an issue with the logging functions being all the same and hardwired into Puppet? I would like if there was a general way in puppet to switch the entire logging system to something else - i.e. use a different API.

Add Comment

[Nick Lewis (JIRA)]

Nick Lewis commented on BOLT-1325

Re: Send Puppet logging functions to the outputter

I started looking at it and yes I ran into the issue with their being hardwired. The problem with swapping out the logging system entirely is that we actually want log functions from user content to be handled differently than logging built into puppet. Specifically, if the user calls notice then we want to print that message on stdout, but if Puppet calls notice then we want it to be handled by the logger.

Add Comment

[Henrik Lindberg (JIRA)]

Henrik Lindberg commented on BOLT-1325

Re: Send Puppet logging functions to the outputter

Ah, I have also wanted something that works more like a puts() or print() than logging - i.e. a new function that would print to an "outputter" which would be either a "log as notice" or "stdout writer", "stderr writer" etc. This means users would call print() instead of notice().

Add Comment

[Nick Lewis (JIRA)]

Nick Lewis commented on BOLT-1325

Re: Send Puppet logging functions to the outputter

I agree. We just did a bunch of work to split the concepts of "output" and "logging" in Bolt, and I think this ticket would conflate them again, but this time for users. print() or similar seems much more straightforward.

Add Comment

[Nick Lewis (JIRA)]

Nick Lewis updated an issue

Puppet Task Runner / BOLT-1325

Send Puppet logging functions to the outputter

Change By: Nick Lewis Release Notes: New Feature

Add Comment

[Nick Lewis (JIRA)]

Nick Lewis updated an issue

Puppet Task Runner / BOLT-1325 Send Puppet logging functions to the outputter

Change By: Nick Lewis Release Notes Summary: This introduces a new function {{out::message()}}, which can be used to print a message to the user during a plan.

Add Comment