Jira (PUP-8270) PAL task_signature adds 'default' to some type descriptions

1 view
Skip to first unread message

Michael Smith (JIRA)

unread,
Dec 20, 2017, 1:47:03 PM12/20/17
to puppe...@googlegroups.com
Michael Smith assigned an issue to Thomas Hallgren
 
Puppet / Bug PUP-8270
PAL task_signature adds 'default' to some type descriptions
Change By: Michael Smith
Assignee: Thomas Hallgren
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Michael Smith (JIRA)

unread,
Dec 20, 2017, 1:47:03 PM12/20/17
to puppe...@googlegroups.com
Michael Smith created an issue
Issue Type: Bug Bug
Affects Versions: PUP 5.4.0
Assignee: Unassigned
Created: 2017/12/20 10:46 AM
Priority: Normal Normal
Reporter: Michael Smith

Using bolt task show on the following metadata file results in some strange artifacts

{
  "description": "Do a thing.",
  "parameters": {
    "foo": {
      "description": "The foo",
      "type": "String[1]"
    }
  }
}

results in

PARAMETERS:
- foo: String[1, default]
    The foo

I'm not sure where default is coming from. It doesn't seem to happen in all the examples I try however.

Henrik Lindberg (JIRA)

unread,
Dec 21, 2017, 4:57:02 AM12/21/17
to puppe...@googlegroups.com
Henrik Lindberg commented on Bug PUP-8270
 
Re: PAL task_signature adds 'default' to some type descriptions

String[1, default] has expanded the max number of chars. I think it should skip showing that - just like a String[default, default] is not generated for String.

Henrik Lindberg (JIRA)

unread,
Dec 21, 2017, 4:57:03 AM12/21/17
to puppe...@googlegroups.com

Thomas Hallgren (JIRA)

unread,
Dec 21, 2017, 7:22:02 AM12/21/17
to puppe...@googlegroups.com
Thomas Hallgren commented on Bug PUP-8270
 
Re: PAL task_signature adds 'default' to some type descriptions

The behavior is similar for all types of ranges so when changing this we should do it consistently and leave out the default max everywhere (includes Integer, Float, Array, Callable, and Tuple).

Thomas Hallgren (JIRA)

unread,
Dec 21, 2017, 7:41:03 AM12/21/17
to puppe...@googlegroups.com
Thomas Hallgren assigned an issue to Michael Smith
 
Change By: Thomas Hallgren
Assignee: Thomas Hallgren Michael Smith

Henrik Lindberg (JIRA)

unread,
Dec 21, 2017, 11:19:10 AM12/21/17
to puppe...@googlegroups.com

Henrik Lindberg (JIRA)

unread,
Dec 22, 2017, 7:19:03 AM12/22/17
to puppe...@googlegroups.com
Henrik Lindberg assigned an issue to Unassigned
 
Change By: Henrik Lindberg
Assignee: Michael Smith

Henrik Lindberg (JIRA)

unread,
Dec 22, 2017, 7:22:03 AM12/22/17
to puppe...@googlegroups.com
Henrik Lindberg updated an issue
Change By: Henrik Lindberg
Release Notes Summary: Data types like {{String\[0]}} were displayed as {{String\[0, default]}} (indicating that the max length is the default). This is unnecessary and the string form for all data types that take min/max length have been changed to not output the max when it is {{default}}.
Sprint: Bolt Kanban
Release Notes: Bug Fix

Geoff Nichols (JIRA)

unread,
Jan 3, 2018, 3:23:04 PM1/3/18
to puppe...@googlegroups.com

John Duarte (JIRA)

unread,
Oct 21, 2019, 10:52:05 AM10/21/19
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Risk Assessment: Needs Assessment No Action
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages