Jira (PDB-4525) PQL and AST should not return schema errors to user

7 views
Skip to first unread message

Austin Blatt (JIRA)

unread,
Oct 1, 2019, 5:12:04 PM10/1/19
to puppe...@googlegroups.com
Austin Blatt created an issue
 
PuppetDB / Improvement PDB-4525
PQL and AST should not return schema errors to user
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2019/10/01 2:11 PM
Priority: Normal Normal
Reporter: Austin Blatt

Both PQL and AST can return schema errors to the user. These errors are unintelligible without understanding the query engine.

clojure.lang.ExceptionInfo: Value does not match schema: (not (map? nil)) {:type :schema.core/error, :schema {:type Keyword, :field (cond-pre Keyword honeysql.types.SqlCall honeysql.types.SqlRaw {:select Any, Any Any}), Any Any}, :value nil, :error (not (map? nil))}

We should return a more useful error message. At a minimum we should identify the field that threw that error, the expected type, and the actual type and report that to the user.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Zachary Kent (Jira)

unread,
Feb 17, 2021, 2:27:03 PM2/17/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Labels: query-engine-improvements
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

David McTavish (Jira)

unread,
Feb 10, 2022, 10:26:02 AM2/10/22
to puppe...@googlegroups.com
David McTavish updated an issue
Change By: David McTavish
Priority: Normal Low
This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages