Jira (PUP-10786) Puppet Node Clean action's LoggerIO needs to implement `warn`

19 views
Skip to first unread message

Justin Stoller (Jira)

unread,
Nov 19, 2020, 12:07:03 PM11/19/20
to puppe...@googlegroups.com
Justin Stoller created an issue
 
Puppet / Bug PUP-10786
Puppet Node Clean action's LoggerIO needs to implement `warn`
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2020/11/19 9:06 AM
Priority: Normal Normal
Reporter: Justin Stoller

In the Puppet Node face's 'clean' action, we load the Puppet Server CA CLI as a library, passing in a 'LoggerIO' object as an adapter between the CA's logging facilities and Puppet's.

Previously, we only needed `inform` and `err` methods to call the relevant APIs in the CA - and it appears our LoggerIO adapter only implements those two methods.

With the new cadir default change (see SERVER-2896) we may `warn` as well which will now cause puppet node clean calls to fail with an undefined method on LoggerIO.

To fix this we should update the LoggerIO adapter to provide all the methods available in the Puppet Server CA's Logger.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Justin Stoller (Jira)

unread,
Nov 19, 2020, 12:10:02 PM11/19/20
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Nov 19, 2020, 12:10:02 PM11/19/20
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Nov 19, 2020, 12:10:09 PM11/19/20
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Nov 19, 2020, 12:12:03 PM11/19/20
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Nov 19, 2020, 12:13:02 PM11/19/20
to puppe...@googlegroups.com

Justin Stoller (Jira)

unread,
Nov 20, 2020, 1:14:03 PM11/20/20
to puppe...@googlegroups.com
Justin Stoller updated an issue
Change By: Justin Stoller
Method Found: Needs Assessment Automated Test

Justin Stoller (Jira)

unread,
Nov 23, 2020, 12:58:03 PM11/23/20
to puppe...@googlegroups.com
Justin Stoller updated an issue
Change By: Justin Stoller
Release Notes: Bug Fix
Release Notes Summary: A known issue with Puppet 7.0.0 was that the {{puppet node clean}} action would fail if the user was had their {{cadir}} in the legacy location or inside the {{ssldir}}. This was a regression and it no longer does so.

Justin Stoller (Jira)

unread,
Nov 23, 2020, 12:59:04 PM11/23/20
to puppe...@googlegroups.com

Maggie Dreyer (Jira)

unread,
Nov 30, 2020, 1:40:05 PM11/30/20
to puppe...@googlegroups.com
Maggie Dreyer updated an issue
Change By: Maggie Dreyer
Fix Version/s: Puppet 7.0.1
Fix Version/s: PUP 7.1.0

Claire Cadman (Jira)

unread,
Dec 9, 2020, 11:34:04 AM12/9/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages