Jira (FACT-1075) Add flag to display legacy facts in default output

2 views
Skip to first unread message

William Hopper (JIRA)

unread,
Jun 25, 2015, 7:58:11 PM6/25/15
to puppe...@googlegroups.com
William Hopper created an issue
 
Facter / New Feature FACT-1075
Add flag to display legacy facts in default output
Issue Type: New Feature New Feature
Assignee: Unassigned
Created: 2015/06/25 4:57 PM
Priority: Normal Normal
Reporter: William Hopper

We received a request post-Facter 3 release to add a flag to output the hidden legacy facts along with the rest of the new structured facts.

Not displaying legacy facts was originally intended to be a breaking change in Facter 3 as part of the shift towards structured facts. With that in mind, we may want to make it clear that this option and the legacy facts it supports are technically deprecated. We should probably sync up on the future of these facts at some point and how they relate to this new flag.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
Atlassian logo

Michael Smith (JIRA)

unread,
Jun 25, 2015, 8:20:10 PM6/25/15
to puppe...@googlegroups.com
Michael Smith commented on New Feature FACT-1075
 
Re: Add flag to display legacy facts in default output

Added PR #991 as one approach to handle this. It could be easily changed to hide legacy facts by default but provide a flag to show them.

Michael Smith (JIRA)

unread,
Jun 25, 2015, 8:20:13 PM6/25/15
to puppe...@googlegroups.com
Michael Smith updated an issue
 
Change By: Michael Smith
Affects Version/s: FACT 3.0.0

Michael Smith (JIRA)

unread,
Jun 25, 2015, 8:20:13 PM6/25/15
to puppe...@googlegroups.com
Michael Smith updated an issue
Change By: Michael Smith
Fix Version/s: FACT 3.1.0

Michael Smith (JIRA)

unread,
Jun 25, 2015, 8:27:10 PM6/25/15
to puppe...@googlegroups.com
Michael Smith updated an issue
Change By: Michael Smith
Comment:
Added PR #991 as one approach to handle this. It could be easily changed to hide legacy facts by default but provide a flag to show them.

Michael Smith (JIRA)

unread,
Jun 25, 2015, 8:28:15 PM6/25/15
to puppe...@googlegroups.com
Michael Smith updated an issue
Change By: Michael Smith
Fix Version/s: FACT 3.1.0
Fix Version/s: FACT 3.0.2

Michael Smith (JIRA)

unread,
Jun 26, 2015, 5:50:14 PM6/26/15
to puppe...@googlegroups.com
Michael Smith updated an issue
Change By: Michael Smith
Release Notes Summary: Provide an option to show hidden facts on command-line output.
Release Notes: Bug Fix

Garrett Guillotte (JIRA)

unread,
Jun 29, 2015, 1:44:13 PM6/29/15
to puppe...@googlegroups.com
Garrett Guillotte commented on New Feature FACT-1075
 
Re: Add flag to display legacy facts in default output

Are the legacy facts fully deprecated, as in we've defined plans for removing them?

William Hopper (JIRA)

unread,
Jun 29, 2015, 1:59:14 PM6/29/15
to puppe...@googlegroups.com

Kylo Ginsberg (JIRA)

unread,
Jun 29, 2015, 2:47:12 PM6/29/15
to puppe...@googlegroups.com

Garrett Guillotte: tldr: no we don't yet have a plan for removing the legacy facts.

Slightly longer version: obviously, we would only want to phase them out such that the change is generally seamless, and so we can't just remove them all or we'd break many modules.

Some of the ideas batted around (IIRC some conversations on IRC a while back) were:

  • remove them all at once
  • remove all but the ones most heavily used in modules (e.g. the operating system ones)
  • leave them all indefinitely
    And variations on the above.

And then the further question would be whether to add visible deprecation warnings (which might get spammy) or not.

We should probably take this thread to puppet-dev to get some consensus around a plan.

Kylo Ginsberg (JIRA)

unread,
Jun 29, 2015, 2:49:15 PM6/29/15
to puppe...@googlegroups.com

I'm +1 on adding a flag like --show-legacy.

Michael Smith (JIRA)

unread,
Jun 30, 2015, 4:35:35 PM6/30/15
to puppe...@googlegroups.com
Michael Smith assigned an issue to qa
 
Change By: Michael Smith
Status: Ready for  CI  Test
Assignee: qa

Eric Thompson (JIRA)

unread,
Jun 30, 2015, 6:11:14 PM6/30/15
to puppe...@googlegroups.com
Eric Thompson updated an issue
Change By: Eric Thompson
QA Risk Assessment: Medium
QA Risk Assessment Reason: customer request, possibly temporary for deprecation purposes.

Eric Thompson (JIRA)

unread,
Jun 30, 2015, 6:13:24 PM6/30/15
to puppe...@googlegroups.com

Michael Smith (JIRA)

unread,
Jun 30, 2015, 6:15:19 PM6/30/15
to puppe...@googlegroups.com
Michael Smith commented on New Feature FACT-1075
 
Re: Add flag to display legacy facts in default output

Some unit tests make sense, also an acceptance test. I'll add them.

Eric Thompson (JIRA)

unread,
Jun 30, 2015, 7:13:13 PM6/30/15
to puppe...@googlegroups.com

Eric Thompson (JIRA)

unread,
Jun 30, 2015, 7:13:24 PM6/30/15
to puppe...@googlegroups.com
Eric Thompson commented on New Feature FACT-1075
 
Re: Add flag to display legacy facts in default output

removed qa_status on this to remind us to set the testcase to automated after PR/merge.

Eric Thompson (JIRA)

unread,
Jul 2, 2015, 12:08:22 PM7/2/15
to puppe...@googlegroups.com

merged commit fb7c17c into puppetlabs:stable

Michael Smith (JIRA)

unread,
Jul 2, 2015, 5:55:24 PM7/2/15
to puppe...@googlegroups.com
Michael Smith assigned an issue to qa
Change By: Michael Smith
Status: Ready for  CI  Test
Assignee: qa

John Duarte (JIRA)

unread,
Jul 29, 2015, 6:43:52 PM7/29/15
to puppe...@googlegroups.com
John Duarte updated an issue
Change By: John Duarte
QA Status: Reviewed
This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c)
Atlassian logo

Claudia Petty (Jira)

unread,
Jun 21, 2023, 8:44:02 AM6/21/23
to puppe...@googlegroups.com
Claudia Petty updated an issue
Change By: Claudia Petty
Labels: new-feature
This message was sent by Atlassian Jira (v8.20.21#820021-sha1:38274c8)
Atlassian logo
Reply all
Reply to author
Forward
0 new messages