Jira (PDB-5567) Migrate PDB reports and resource_events inheritance based partitions to postgresql declarative partitions

34 views
Skip to first unread message

Joshua Partlow (Jira)

unread,
Nov 29, 2022, 4:25:02 PM11/29/22
to puppe...@googlegroups.com
Joshua Partlow created an issue
 
PuppetDB / Improvement PDB-5567
Migrate PDB reports and resource_events inheritance based partitions to postgresql declarative partitions
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2022/11/29 1:24 PM
Priority: Normal Normal
Reporter: Joshua Partlow

PDB-5554 intended to improve performance around partition remove by making use of `alter table detach partition concurrently`. But that can only be used with declarative partitions and our partitions are inheritance based.

Migrate resource_events and reports partitioning to declarative partitions.

https://www.2ndquadrant.com/en/blog/how-to-migrate-from-inheritance-based-partitioning-to-declarative-partitioning-in-postgresql/ is one example.

Need to validate that this migration won't have a significant impact on larger databases with a significant number of reports and events.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)
Atlassian logo

Joshua Partlow (Jira)

unread,
Nov 29, 2022, 4:47:03 PM11/29/22
to puppe...@googlegroups.com

Joshua Partlow (Jira)

unread,
Nov 29, 2022, 4:48:03 PM11/29/22
to puppe...@googlegroups.com

Nirupama Mantha (Jira)

unread,
Dec 1, 2022, 2:20:01 PM12/1/22
to puppe...@googlegroups.com

Sean McDonald (Jira)

unread,
Dec 7, 2022, 1:06:02 PM12/7/22
to puppe...@googlegroups.com

Joshua Partlow (Jira)

unread,
Dec 16, 2022, 7:01:02 PM12/16/22
to puppe...@googlegroups.com

Cas Donoghue (Jira)

unread,
Jan 4, 2023, 1:13:03 PM1/4/23
to puppe...@googlegroups.com
Cas Donoghue updated an issue
 
Change By: Cas Donoghue
Sprint: Skeletor 12/07/2022, Skeletor 12/21/2022 , Skeletor 01/18/2023

Cas Donoghue (Jira)

unread,
Jan 18, 2023, 1:25:02 PM1/18/23
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Sprint: Skeletor 12/07/2022, Skeletor 12/21/2022, Skeletor 01/18/2023 , Skeletor 02/01/2023

Cas Donoghue (Jira)

unread,
Feb 1, 2023, 1:17:01 PM2/1/23
to puppe...@googlegroups.com
Cas Donoghue updated an issue
Change By: Cas Donoghue
Sprint: Skeletor 12/07/2022, Skeletor 12/21/2022, Skeletor 01/18/2023, Skeletor 02/01/2023 , Skeletor 02/15/2023

Joshua Partlow (Jira)

unread,
Feb 3, 2023, 7:10:01 PM2/3/23
to puppe...@googlegroups.com

Joshua Partlow (Jira)

unread,
Feb 3, 2023, 7:15:03 PM2/3/23
to puppe...@googlegroups.com
Joshua Partlow updated an issue
 
Change By: Joshua Partlow
Release Notes: Enhancement
Release Notes Summary: The reports and resource_events tables were migrated to use PostgreSQL declarative partitioning in support of PDB-5554.

This changes requires a minimum of PostgreSQL 11.

Joshua Partlow (Jira)

unread,
Feb 3, 2023, 7:16:01 PM2/3/23
to puppe...@googlegroups.com
Joshua Partlow updated an issue
PDB-5554 intended to improve performance around partition remove by making use of `alter table detach partition concurrently`. But that can only be used with declarative partitions and our partitions are inheritance based.



Need to validate that this migration won't have a significant impact on larger databases with a significant number of reports and events.


NOTE: The minimum PostgreSQL version is now 11 with these migrations.

Joshua Partlow (Jira)

unread,
Feb 3, 2023, 7:16:03 PM2/3/23
to puppe...@googlegroups.com
Joshua Partlow updated an issue
PDB-5554 intended to improve performance around partition remove by making use of `alter table detach partition concurrently`. But that can only be used with declarative partitions and our partitions are inheritance based.

Migrate resource_events and reports partitioning to [declarative partitions|https://www.postgresql.org/docs/current/ddl-partitioning.html].

[https://www.2ndquadrant.com/en/blog/how-to-migrate-from-inheritance-based-partitioning-to-declarative-partitioning-in-postgresql/] is one example.

Need to validate that this migration won't have a significant impact on larger databases with a significant number of reports and events.

NOTE: * The minimum PostgreSQL version is now 11 with these migrations. *

Joshua Partlow (Jira)

unread,
Feb 10, 2023, 12:26:01 PM2/10/23
to puppe...@googlegroups.com
 
Re: Migrate PDB reports and resource_events inheritance based partitions to postgresql declarative partitions

This is in 2021.7.3-rc1-41-g502f631, and 2023.1.0-rc1-51-ga570859, both of which have gone through nightly PE integration CI. There are some 2021.7 failures that look to be scattered, unrelated abs/vmpooler allocation or connectivity type errors.

Joshua Partlow (Jira)

unread,
Feb 10, 2023, 12:26:02 PM2/10/23
to puppe...@googlegroups.com

Joshua Partlow (Jira)

unread,
Feb 10, 2023, 12:34:05 PM2/10/23
to puppe...@googlegroups.com

Jonathan Newman (Jira)

unread,
Apr 4, 2023, 4:40:02 PM4/4/23
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages