Jira (PUP-9193) puppet ignores exit code from windows exe package install because it uses 'start'

2 views
Skip to first unread message

Sean McDonald (JIRA)

unread,
Oct 2, 2018, 12:19:09 PM10/2/18
to puppe...@googlegroups.com
Sean McDonald created an issue
 
Puppet / Bug PUP-9193
puppet ignores exit code from windows exe package install because it uses 'start'
Issue Type: Bug Bug
Assignee: Unassigned
Created: 2018/10/02 9:18 AM
Environment:

Windows (all versions)

Labels: windows type_and_provider package
Priority: Normal Normal
Reporter: Sean McDonald

This effects all supported versions of puppet:

We use "cmd /c start" to execute exe package installs on Windows: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/windows/exe_package.rb#L45. Comments suggest this is because otherwise executables that are console apps will launch a new window (which is undesired).

However, the use of "start" means the calling process (i.e. puppet) will never see the actual exit code from the installation, only the exit code from the call to start (which will be 0: success)

This means from puppet's perspective exe package installs always succeed and puppet will always report a successful installation, regardless of whether or not the application install actually succeeded.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Atlassian logo

Branan Riley (JIRA)

unread,
Oct 2, 2018, 12:56:04 PM10/2/18
to puppe...@googlegroups.com

Sean McDonald (JIRA)

unread,
Oct 3, 2018, 1:33:03 PM10/3/18
to puppe...@googlegroups.com

Sean McDonald (JIRA)

unread,
Oct 3, 2018, 1:33:04 PM10/3/18
to puppe...@googlegroups.com

Jonathan Morris (JIRA)

unread,
Oct 23, 2018, 4:00:08 PM10/23/18
to puppe...@googlegroups.com

Branan Riley (JIRA)

unread,
Dec 12, 2018, 6:23:03 PM12/12/18
to puppe...@googlegroups.com

Josh Cooper (JIRA)

unread,
Feb 24, 2020, 3:05:05 PM2/24/20
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages