Jira (PDB-5025) Add unit tests with the AST queries that are present in the documentation

18 views
Skip to first unread message

Andrei Filipovici (Jira)

unread,
Feb 16, 2021, 11:55:02 AM2/16/21
to puppe...@googlegroups.com
Andrei Filipovici created an issue
 
PuppetDB / Task PDB-5025
Add unit tests with the AST queries that are present in the documentation
Issue Type: Task Task
Assignee: Unassigned
Created: 2021/02/16 8:54 AM
Priority: Normal Normal
Reporter: Andrei Filipovici

Query `["from", "nodes",
["in", "certname",
["from", "reports",
["extract", "certname"],
["limit", 1],
["order_by", [["certname", "desc"]]]]]]`
from the AST documentation fails.

Add multiple unit tests to cover the AST queries in the documentation.

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Atlassian logo

Bogdan Irimie (Jira)

unread,
Mar 10, 2021, 10:08:03 AM3/10/21
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Mar 10, 2021, 10:09:02 AM3/10/21
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Mar 10, 2021, 10:09:03 AM3/10/21
to puppe...@googlegroups.com

Andrei Filipovici (Jira)

unread,
Mar 23, 2021, 4:31:03 AM3/23/21
to puppe...@googlegroups.com

Bogdan Irimie (Jira)

unread,
Mar 24, 2021, 10:09:04 AM3/24/21
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-24.03.2021 , ready for triage 3

Andrei Filipovici (Jira)

unread,
Apr 2, 2021, 4:45:04 AM4/2/21
to puppe...@googlegroups.com
Andrei Filipovici updated an issue
Change By: Andrei Filipovici
Attachment: AST.postman_collection.json
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Andrei Filipovici (Jira)

unread,
Apr 2, 2021, 8:42:03 AM4/2/21
to puppe...@googlegroups.com
Andrei Filipovici commented on Task PDB-5025
 
Re: Add unit tests with the AST queries that are present in the documentation

Added a Postman collection with all the queries from the above mentioned documentation.
In addition to the query that fails in the description, the following query also fails on the facts endopoint:

["extract", [["function", "to_string", "value"]], ["=","name", "uptime_seconds"]]

Andrei Filipovici (Jira)

unread,
Apr 2, 2021, 8:44:03 AM4/2/21
to puppe...@googlegroups.com

There are also some errors in the documentation. There is an order_by on the timestamp field which doesn't exist anymore.
Some unbalanced parenthesis, unescaped quotes, etc.

Bogdan Irimie (Jira)

unread,
Apr 7, 2021, 9:04:04 AM4/7/21
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
 
Change By: Bogdan Irimie
Sprint: ghost-24.03.2021, ghost-7.04.2021 , HAHA/Grooming 2

Bogdan Irimie (Jira)

unread,
Apr 21, 2021, 3:26:03 AM4/21/21
to puppe...@googlegroups.com
Bogdan Irimie updated an issue
Change By: Bogdan Irimie
Sprint: ghost-24.03.2021, ghost-7.04.2021, ghost-21.04.2021 , HAHA/Grooming 2

Zachary Kent (Jira)

unread,
May 21, 2021, 3:57:03 PM5/21/21
to puppe...@googlegroups.com

Austin Blatt (Jira)

unread,
Jun 17, 2021, 5:08:01 PM6/17/21
to puppe...@googlegroups.com

Austin Blatt (Jira)

unread,
Jun 17, 2021, 5:14:02 PM6/17/21
to puppe...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages