Jira (PDB-5113) Log incoming command size

9 views
Skip to first unread message

Austin Blatt (Jira)

unread,
Apr 21, 2021, 5:36:03 PM4/21/21
to puppe...@googlegroups.com
Austin Blatt created an issue
 
PuppetDB / Improvement PDB-5113
Log incoming command size
Issue Type: Improvement Improvement
Assignee: Unassigned
Created: 2021/04/21 2:35 PM
Priority: Normal Normal
Reporter: Austin Blatt

To aid in determining which nodes are submitting large factsets, catalogs, or reports, when the special header set by the terminus is present we should log that size in the access logs.

When it's not present, it would be nice if we could log something that indicates it is not present (the standard for that log might be a "-"?), but zero would likely suffice too, as no real command would have that size.

Stashing it in the MDC should make it available to the access logs
https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/MDC.html
example in puppetserver of storing someting in the MDC - https://github.com/puppetlabs/puppetserver/pull/1689

the access log pattern is then controlled by a pattern defined in /etc/puppetlabs/puppetdb/request-logging.xml

Add Comment Add Comment
 
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Austin Blatt (Jira)

unread,
May 5, 2021, 2:40:03 PM5/5/21
to puppe...@googlegroups.com
Austin Blatt updated an issue
Change By: Austin Blatt
Sprint: HA 2020-05-19
Story Points: 2

Zachary Kent (Jira)

unread,
May 11, 2021, 11:56:03 AM5/11/21
to puppe...@googlegroups.com
Zachary Kent assigned an issue to Zachary Kent
Change By: Zachary Kent
Assignee: Zachary Kent

Zachary Kent (Jira)

unread,
May 12, 2021, 3:06:05 PM5/12/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Fix Version/s: PDB 6.16.2
Fix Version/s: PDB 7.3.2

Zachary Kent (Jira)

unread,
May 12, 2021, 3:07:03 PM5/12/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Release Notes: Not Needed

Zachary Kent (Jira)

unread,
May 21, 2021, 3:54:02 PM5/21/21
to puppe...@googlegroups.com
Zachary Kent updated an issue
Change By: Zachary Kent
Fix Version/s: PDB 7.3.2
Fix Version/s: PDB 7.4.0
Reply all
Reply to author
Forward
0 new messages