Jira (PUP-11345) Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

[Josh Cooper (Jira)]

Josh Cooper created an issue

Puppet / PUP-11345 Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods Issue Type: Bug Assignee: Unassigned Created: 2021/11/09 4:48 PM Priority: Normal Reporter: Josh Cooper Puppet::FileSystem methods generally assert that they are passed either a String or Pathname and raise ArgumentError if that isn't the case. For example: irb(main):009:0> Puppet::FileSystem.mkpath(nil) ... ArgumentError (FileSystem implementation expected Pathname, got: 'NilClass') However, Puppet::FileSystem.chmod raises an unhelpful TypeError trying to convert nil to a String: irb(main):007:0> Puppet::FileSystem.chmod(0644, nil) ... TypeError (no implicit conversion of nil into String) The chmod method should raise ArgumentError like the other methods Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11345 Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

Change By: Josh Cooper Fix Version/s: PUP 6.26.0 Fix Version/s: PUP 7.13.0

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11345

Re: Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods I ran into this while researching PUP-11312 and broke it out into a separate ticket and PR

Add Comment

[Josh Cooper (Jira)]

Josh Cooper assigned an issue to Josh Cooper

Puppet / PUP-11345

Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

Change By: Josh Cooper Assignee: Josh Cooper

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11345 Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

Change By: Josh Cooper Team: Coremunity

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11345 Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

Change By: Josh Cooper Sprint: Coremunity Kanban

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11345

Re: Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods Merged to 6.x in https://github.com/puppetlabs/puppet/commit/7f2e140eb48801f7fd859b00c7ba060e8034d14e

Add Comment

[Josh Cooper (Jira)]

Josh Cooper commented on PUP-11345

Re: Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

Passed CI in fb4a1dc506

Add Comment

[Josh Cooper (Jira)]

Josh Cooper updated an issue

Puppet / PUP-11345

Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Puppet::FileSystem.chmod now validates its arguments like other methods like mkpath, etc.

Add Comment

[Parker Leach (Jira)]

Parker Leach updated an issue

Puppet / PUP-11345 Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

Change By: Parker Leach Labels: docs_reviewed

Add Comment

This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)